MySql INSERT,VALUES problem

rob76

I am having problems trying to create a php script which will detect a visitors screen width/resolution and Insert it as a mysql record. This example shows roughly what I am trying to achieve

/ Database configurations /

$screenwidth = "<html><script type='text/javascript' language='JavaScript'>var resolution =screen.width;document.write(resolution);</script></html>";

$sql = "
INSERT INTO $table_name
(screenwidth)
VALUES
('$screenwidth')
";

etc. etc.

For some reason this query fails. I have tried to echo() the $screenwidth just to make sure that it contains a value, which it does, so that bits OK. I've also tried assigning a different value to screenwidth to check my SQL syntax is OK and that works fine.

The query I am trying to run though always fails. Could anyone help me on this.

Thanks

Rob

dcooper

try taking out the brackets in the sql statement

rob76

I've just tried it. Unfortunately, it makes no difference

dcooper

<?php
$screenwidth = "<html><script type='text/javascript' language='JavaScript'>var resolution =screen.width;document.write(resolution);</script></html>";

$screenwidth = addslashes($screenwidth);

$db = mysql_pconnect('localhost','username','password') or die (mysql_error());

mysql_select_db('name');

$query = "insert into $table_name screenwidth values ('".$screenwidth."')";

$result = mysql_query($query);
echo mysql_affected_rows();
?>

rob76

Thanks, I tried it but still it doesn't work, however it's given me a clue. When I used addslashes, the query worked but it inserted the actual string "<html><script type='text/javascript' etc. into the database as opposed to the screen width which is what I need.

What I don't understand is that <? echo $screenwidth; ?> prints the screen width eg. "1024" or whatever, but

INSERT into $table_name 'screenwidth' VALUES $screenwidth

inserts the string "<html><script type='text/javascript' etc. !??

I have a feeling I'm missing something very obvious here.

Any further ideas ?

bubblenut

Echo your insert wuery before running it and see if it is as expected. If it is change $result=mysql_query($query) to $result=mysql_query($query) or die(mysql_error());

HTH
Bubble

rob76

OK, I echoed the INSERT query on the line before running it and got "insert into mycount (screenwidth) values ('1280')" which is exactly what I want to happen, but guess what, when I looked in at the database record the value was not '1280' but
"<html><script type=\"text/javascript\" language=\"JavaScript\"> etc."

I changed $result=mysql_query($query) to $result=mysql_query($query) or die(mysql_error()); but it didn't make any difference. How would that help?

Still no nearer 😕

bubblenut

Look at the page source. You are trying to pass javascript varaibles into php directly you cannot do this. PHP is a server side language and javascript is a client side one.
HTH
Rob

rob76

Thanks, looks like it's back to the drawing board!

One question though (might be a stupid one), if it's not possible to pass a javascript variable to PHP how come <?echo $screenwidth;?> prints the value of the javascript variable to the screen but INSERT into $tablename (screenwidth) VALUES ('$screenwidth') won't insert into a database ?

Presumably the value of the js variable must be assigned to $screenwidth otherwise it wouldn't echo()

dcooper

k im clutching at straws here but try this 🙂

<?php
$screenwidth = "<html><script type='text/javascript' language='JavaScript'>var resolution =screen.width;document.write(resolution);</script></html>";

$screenwidth = addslashes($screenwidth);
$testvar = $screenwidth;

$db = mysql_pconnect('localhost','username','password') or die (mysql_error());

mysql_select_db('name');

$query = "insert into $table_name screenwidth values ('".$testvar."')";

$result = mysql_query($query) or die (mysql_error());
echo mysql_affected_rows();
?>

rob76

Ah, I understand now. The variable $screenwidth contains only the javascript. It prints to the screen because the browser interprets the javascript but mysql can only see the javascript therefore thats what appears in the database record.

Thanks all for your input.

Rob Horn