Parse error, help!

desolator

I am building a register page, I setup the database correctly but I have one line thats got a parse error

Parse error: parse error, unexpected T_STRING in c:\hostingsite\register.php on line 39

the line is:
showheader("Registration Success!");

it is right! doesn't work! please help!

Thanks

desolator

mrhappiness

would you mind posting the 5 lines above?

this very line seems correct, butmaybe you forgot some closing brackets or something else

desolator

here are the five lines above:
else
{
$Name = mysql_query("INSERT INTO personalize VALUES ('$Name', 'Password')");
setcookie("site_user", $Name, "/");
setcookie("site_pass, $Password, "/");

mrhappiness

you forgot a " after setcookie("site_pass

btw: if you use the php-tags provided by this forum you'll get a marvelous syntax-highlighting which helps searching for errors

else
{
$Name = mysql_query("INSERT INTO personalize VALUES ('$Name', 'Password')");
setcookie("site_user", $Name, "/");
setcookie("site_pass, $Password, "/");

btw #2: $Name won't contain the user's name after mysql_query

[edit]
i'll try to help even if you don't send me a pm, so it's not neccessary 😉
[/edit]

desolator

Thanks

desolator

What the?
All it says now when I register is USERNAME ALREADY TAKEN
go now http://24.82.218.113/register.html
look it will say username taken

mrhappiness

well, seems like soemthing's going wrong 😉

under what circumstances do you output this message?
or, in other words: how do you detect whether a username is taken or whether it's free?

desolator

hmmmmmm, I will display whole file:

<?php
function showheader ($title) {
?>

<html>
<HEAD>
<TITLE> <?php echo $title ?> </TITLE>
</HEAD>
<BODY BGCOLOR="#FFFFFF">
<CENTER>
<?php
}

function showfooter() {
?>
</CENTER>
</BODY>
</html>
<?php
}

mysql_connect("localhost", "root");
mysql_select_db("users");

if ($Password == $Password1) {
$user = mysql_query("SELECT * FROM personalize WHERE (Name='$Name')");
if (mysql_num_rows($user) > 0) {
showheader("Username taken!");
?>We are sorry to inform you that the username <?php echo $Name ?> Is taken.
<?php
showfooter();
exit;
}
else
{
$user = mysql_query("INSERT INTO personalize VALUES ('$Name', 'Password')");
setcookie("site_user", $Name, "/");
setcookie("site_pass", $Password, "/");
showheader("Registration Success!");
?>
You Have registered!. 
Username: <?php echo $Name ?>
 Password: <?php echo $Password ?>
<?php
}
}
else {
showheader("Registration Error!");
?>
Your Two Passwords Did Not Match
<?php
showfooter();
}
?>

mrhappiness

if ($Password == $Password1) 
{
  $sql="SELECT COUNT(name) alreadythere FROM personalize WHERE name='".$name."'";
  echo $sql;
  $user = mysql_fetch_assoc(mysql_query($sql));
  print_r($user);
  if ($user['alreadythere'] > 0) 
    echo 'taken';
  else
    echo 'not taken';
}

output?

desolator

Will that work? have you used it?

mrhappiness

i'm just curious to know which data you're sending to the database

give it a try and tell me whether it works or not

desolator

Umm, sorry to ask, but what do I replace it with?

mrhappiness

if ($Password == $Password1) {
$user = mysql_query("SELECT * FROM personalize WHERE (Name='$Name')");
if (mysql_num_rows($user) > 0) {
showheader("Username taken!");
?>We are sorry to inform you that the username <?php echo $Name ?> Is taken.
<?php
showfooter();
exit;
}

that's the part which should be replaced

desolator

crap now I got another parse error:
Parse error: parse error, unexpected '}' in c:\hostingsite\register.php on line 49

the line is just a single }

Parse error: parse error, unexpected T_ELSE in c:\hostingsite\register.php on line 50

mrhappiness

sry, read your code to fast 🙂

just write my code directly below mysql_select_db and leave everythng else like it is

i think you should use $_POST['name'] instead of $name 8same for all the other variables coming from the form

desolator

Okay one more thing I think:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in c:\hostingsite\register.php on line 26

Now my file looks like:

<?php
function showheader ($title) {
?>

<html>
<HEAD>
<TITLE> <?php echo $title ?> </TITLE>
</HEAD>
<BODY BGCOLOR="#FFFFFF">
<CENTER>
<?php
}

function showfooter() {
?>
</CENTER>
</BODY>
</html>
<?php
}

mysql_connect("localhost", "root");
mysql_select_db("users");

if ($Password == $Password1) {
$user = mysql_query("SELECT * FROM personalize WHERE (Name='$_POST['Name'])");
if (mysql_num_rows($user) > 0) {
showheader("Username taken!");
?>We are sorry to inform you that the username <?php echo $Name ?> Is taken.
<?php
showfooter();
exit;
}

if ($Password == $Password1) {
$user = mysql_query("SELECT * FROM personalize WHERE (Name='$POST['Name'])");
if (mysql_num_rows($user) > 0) {
showheader("Username taken!");
?>We are sorry to inform you that the username <?php echo $POST['Name'] ?> Is taken.
<?php
showfooter();
exit;
}
}
else
{
$user = mysql_query("INSERT INTO personalize VALUES ('$Name', 'Password')");
setcookie("site_user", $POST['Name'], "/");
setcookie("site_pass", $POST['Password'], "/");
showheader("Registration Success!");
?>
You Have registered!. 
Username: <?php echo $POST['Name'] ?>
 Password: <?php echo $POST['Password'] ?>
<?php
}

else {
showheader("Registration Error!");
?>
Your Two Passwords Did Not Match
<?php
showfooter();
}
?>

mrhappiness

use php-tags and (for testing purposes) only have the following code in your register.php

<?php
error_reporting(E_ALL);
mysql_connect("localhost", "root");
mysql_select_db("users"); 
if ($_POST['Password'] == $_POST['Password1']) 
{
  $sql="SELECT COUNT(name) alreadythere FROM personalize WHERE name='".$_POST['Name']."'";
  echo $sql;
  $user = mysql_fetch_assoc(mysql_query($sql));
  print_r($user);
  if ($user['alreadythere'] > 0) 
    echo 'taken';
  else
    echo 'not taken';
}
?>

what does it output?

desolator

It outputs this:

SELECT COUNT(name) alreadythere FROM personalize WHERE name='dead'Array ( [alreadythere] => 0 ) not taken

mrhappiness

seams fine doesn't it?

desolator

what do you mean?
Oh okay