Problem with if, else, elseif

[crseader]

I am trying to have my script check for conditions in the database based on three things and display an image based on the three things. Here is what i have so far.
if ($Recordset7->Fields('highalarm') == 0)
{
printf("<img src=\"%s\">", $greendot); break;
}
elseif ($Recordset7->Fields('highalarm') != 0)
{
printf("<img src=\"%s\">", $reddot); break;
}

with this i can check two conditions in the database and i want to check a third condition like
if ($Recordset1->Fields('error') == 139)
{
echo 'Error 139: Device Failed to Respond (the modbus device may be off or disconnected)';
} ?>
My Question - Is there any way to roll this into one instead of all these if else stuff, can i rool three condition checks into one here.
Please help
Thanks,
Cameron Seader

[John_Canyon]

if ($Recordset1->Fields('error') == 139)
{
echo 'Error 139: Device Failed to Respond (the modbus device may be off or disconnected)';
}
elseif ($Recordset7->Fields('highalarm') != 0)
{
printf("<img src=\"%s\">", $reddot); break;
}
else //Recordset7 == 0
{
printf("<img src=\"%s\">", $greendot); break;
}

This should work for you.

[crseader]

Here is what i have for the script below, is there any way that i can tweak this to maybe even go faster, right now this script below does not even work, i get a parse error.
Thanks,
Cameron Seader

			  switch ($Recordset1->Fields('dev_name'))
		{
		case 'AcquiSuite 8811-1 ': if ($Recordset8->Fields('error') == 139) 
									{ 
										printf("<img src=\"%s\">", $redx); break; 
									} 			
								   elseif ($Recordset8->Fields('highalarm') == 0)
									{
										 printf("<img src=\"%s\">", $greendot); break; 
									}
								   else ($Recordset8->Fields('highalarm') != 0)
								    {
										 printf("<img src=\"%s\">", $reddot); break;
									}									   
		case 'Panel A2 B1': if ($Recordset4->Fields('error') == 139) 
								{ 
										printf("<img src=\"%s\">", $redx); break; 
								} 
							elseif ($Recordset4->Fields('highalarm') == 0)
								{
									printf("<img src=\"%s\">", $greendot); break;
								}
							else ($Recordset4->Fields('highalarm') != 0)
								{
									printf("<img src=\"%s\">", $reddot); break;
								}								
		case 'Panel A2 B2 ': if ($Recordset3->Fields('error') == 139) 
								{ 
									printf("<img src=\"%s\">", $redx); break; 
								}			
							elseif ($Recordset3->Fields('highalarm') == 0)
								{
									printf("<img src=\"%s\">", $greendot); break;
								}
							else ($Recordset3->Fields('highalarm') != 0)
								{
									printf("<img src=\"%s\">", $reddot); break;
								}								
		case 'Panel A2 B3': if ($Recordset2->Fields('error') == 139) 
								{ 
									printf("<img src=\"%s\">", $redx); break; 
								} 
							elseif ($Recordset2->Fields('highalarm') == 0)
								{
									printf("<img src=\"%s\">", $greendot); break;
								}
							else ($Recordset2->Fields('highalarm') != 0)
								{
									printf("<img src=\"%s\">", $reddot); break;
								}								
		case 'Panel A1 A1': if ($Recordset5->Fields('error') == 139) 
								{ 
									printf("<img src=\"%s\">", $redx); break; 
								} 
							elseif ($Recordset5->Fields('highalarm') == 0)
								{
									printf("<img src=\"%s\">", $greendot); break;
								}
							else ($Recordset5->Fields('highalarm') != 0)
								{
									printf("<img src=\"%s\">", $reddot); break;
								}								
		case 'Panel A1 A2': if ($Recordset6->Fields('error') == 139) 
								{ 
									printf("<img src=\"%s\">", $redx); break; 
								} 
							elseif ($Recordset6->Fields('highalarm') == 0)
								{
									printf("<img src=\"%s\">", $greendot); break;
								}
							else ($Recordset6->Fields('highalarm') != 0)
								{
									printf("<img src=\"%s\">", $reddot); break;
								}								
		case 'Panel A1 A3': if ($Recordset7->Fields('error') == 139) 
								{ 
									printf("<img src=\"%s\">", $redx); break; 
								} 
							elseif ($Recordset7->Fields('highalarm') == 0)
								{
									printf("<img src=\"%s\">", $greendot); break;
								}
							else ($Recordset7->Fields('highalarm') != 0)
								{
									printf("<img src=\"%s\">", $reddot); break;
								}								
		default: printf("<img src=\"%s\">", $redx); break;
		}

[crseader]

is there some way possibly that i can do some kind of for loop maybe ?????

[Weedpacket]

I think some arrays would be advisable; not sure just how, 'cos I started to go crosseyed looking at the code.

YOu get the parse error because of things like

else ($Recordset2->Fields('highalarm') != 0)

You don't need (and shouldn't have) a condition expression after the else.

But each case could be simplified a fair bit anyway:

case 'Panel A2 B3':
	echo "<img src=\"";
	if ($Recordset2->Fields('error') == 139)
		echo $redx;
	elseif ($Recordset2->Fields('highalarm') == 0)
		echo $greendot;
	else
		echo $reddot;
	echo "\">";
	break;

or

case 'Panel A2 B3':
	echo "<img src=\"".
		($Recordset2->Fields('error') == 139
		? $redx;
		: ($Recordset2->Fields('highalarm') == 0
		  ? $greendot;
		  : $reddot
	))."\">";
	break;

Assuming (I haven't rigorously looked) that the only thing that changes from case to case is which Recordset is being looked at, an array

$Recordsets=array(
'Panel A2 B3'=>$Recordset2,
'Panel A2 B2'=>$Recordset3,
...
);

And then the whole switch would collapse down to

$Recordset = $Recordsets[$Recordset1->Fields('dev_name')];
echo "<img src=\"".
	($Recordset->Fields('error') == 139
	? $redx;
	: ($Recordset->Fields('highalarm') == 0
	  ? $greendot;
	  : $reddot
))."\">";

A bit more time and domain knowledge might see a better thought-out array put together.

[crseader]

The others work, but the array gets a parse error.
Thanks for all your help i really appreciate it.
Cameron