Printing javascript causing line breaks in the code, causing errors

[Carl_Conrad]

I have a random image generator on my site. The images are randomized in random.php and then that page prints out a link that links to a pop-up javascript window.

The problem is that when the PHP prints the code, it's breaking it up after it prints the random image variables it created, causing an error in the javascript. The javascript still works, but error messages come up for those coming to the site.

I've posted the echo code below, as well as what results in the final page.

echo "<a href=\"java script:randWin('$directory_depth$random_image[1]')\" onclick=\"randWin('$directory_depth$random_image[1]');return false\"><img border=\"0\" src=\"$directory_depth$random_image[0]\"></a>";

(and it's one line in the file, the board just breaks it up here...)

Final result...

<a href="java script:randWin('pics/archive9/cwdata/a9p7.html
')" onclick="randWin('pics/archive9/cwdata/a9p7.html
');return false"><img border="0" src="randimg/71.gif">

How do I get it to print without line breaks?

[python_q]

Check the strings within the $random_image array. There's probably a newline at the end of them. If so, rtrim($random_image[1],"\n") should do the trick.

[sarahk]

check out python_q's suggestion but I'd also change my code as follows

echo "<a href=\"javascript:randWin('{$directory_depth}{$random_image[1]}')\" onclick=\" randWin('{$directory_depth}{$random_image[1]}');return false\"><img border='0' src='{$directory_depth}{$random_image[0]}'></a>";

[Carl_Conrad]

python_q:

Where do I add that. I know little about PHP, and get a parse error when I add it. I added the code below...

<?php 

#random images example

#this is your file

$file = "/home/mcconaha/public_html/randimg/images1.txt";


#open the file

$fp = file($file); 

#generate a random number

srand((double)microtime()*1000000); 

#get one of the entries in the file

$random_image = $fp[array_rand($fp)]; 

#split the image from the link

$random_image = explode(' ', $random_image);

#display the entry

echo "<a href=\"java script:randWin('{$directory_depth}{$random_image[1]}')\" onclick=\"randWin('{$directory_depth}{$random_image[1]}');return false\"><img border='0' src='{$directory_depth}{$random_image[0]}'></a>";


?> 

Thanks for your help thus far...

[suntra]

Your code is strange !! Try this instead :

 <?php  

#random images example 

#this is your file 

$file = "/home/mcconaha/public_html/randimg/images1.txt"; 


#open the file 

$fp = file($file);  

#generate a random number 

srand((double)microtime()*1000000);  

#generate a random number between 0 and the number of elements in $fp

$random_value = rand(0, count($fp));

#take the randomly chosen value in $random_image

$random_image = $fp[$random_value];

#display the entry 

echo "<a href=\"java  script:randWin('{$directory_depth}{$random_image[1
]}')\" onclick=\" randWin('{$directory_depth}{$random_image[1]}');re
turn false\"><img border='0' src='{$directory_depth}{$random_image[0]}'></a>"; 


?>

A question : why do you put "{" and "}" in JavaScript ??

Also, your problem with the new line was because you used explode()... it always lets the newline at the end of the line, it does not remove it.

[Carl_Conrad]

The {} were because of a suggestion in this thread.

The reason for using explode was because this pulls the information from a text file. In it, there is a URL for the image, and then a URL for a corresponding HTML file. Click the image, get the correct photo gallery page with the image on it. So both have to match.

The text file looks like this...

randimg/1.gif pics/archive19/cwdata/a19p3.html
randimg/11.gif pics/archive19/cwdata/a19p5.html
randimg/51.gif pics/archive15/cwdata/a15p1.html
randimg/31.gif pics/archive18/cwdata/a18p2.html
randimg/41.gif pics/archive16/cwdata/a16p3.html
randimg/21.gif pics/archive18/cwdata/a18pp11.html
randimg/61.gif pics/archive13/cwdata/a13p1.html
randimg/71.gif pics/archive9/cwdata/a9p7.html

Do you know of a way to do that without explode? It looks like your way would work if I only needed one value from the file, but I need both to make the pop-up go to the correct page depending on the image...

[suntra]

What about this ?

<?php   

#random images example 

#this is your file 

$file = "/home/mcconaha/public_html/randimg/images1.txt";  


#open the file 

$fp = file($file);   

#generate a random number 

srand((double)microtime()*1000000);   

#generate a random number between 0 and the number of elements in $fp 

$random_value = rand(0, count($fp)); 

#take the randomly chosen value in $random_image 

$random_image = explode(" ", $fp[$random_value]); 

$image_url = trim($random_image[0]);

$gallery_url = trim($random_image[1]);

#display the entry 

echo "<a href=\"javascript:randWin('$directory_depth$image_url')\" onclick=\"randWin('$directory_depth$gallery_url');return false\"><img border='0' src='$directory_depth$image_url'></a>";  


?>

[Carl_Conrad]

That code prints on one line (hooray!), but doesn't print the links. This is the output of that code using the text file I posted above...

<a href="java script:randWin('a')" onclick=" randWin('a');return false"><img border='0' src='r'>

Ideas?

HANG ON... Heh...used the code you had up there first... Sorry.

[Carl_Conrad]

WORKS! Thanks so much. This has been a very, very annoying problem...

[Carl_Conrad]

OK, it works...but only part of the time. If you go to mcconaha.com you'll see what I mean. Sometimes it doesn't return anything at all. And I checked the text files to make sure there were no blank lines at the end, and there aren't. Ideas?

[suntra]

Replace

$random_value = rand(0, count($fp));  

by

$random_value = rand(0, count($fp) - 1);  

[Carl_Conrad]

Yep, that seemed to take care of it. Thanks so much...

[sarahk]

randWin('{$directory_depth}{$random_image[1]}');

A question : why do you put "{" and "}" in JavaScript ??

The braces (curly brackets) don't get as far as the javascript. These ensure that PHP parses the variables correctly. PHP can't parse an array without them so in the case of $random_image[1] they are necessary.

They aren't always used and aren't always necessary but are a "best practice".

View the source in the browser and you will see that the braces are gone.