[Resolved] preg_replace issues!!!

[stew]

hey there guys on the last line of the code below i get the error below... i have no idea whats going on, so a little help (from anyone) would be appreciated!

$threadpost = preg_replace("/\[.email\](.*)\[\/.email\]/","<a href=\"mailto:$1\">$1</a>",$threadpost);
        $threadpost = preg_replace("/\[.email=(.*)\](.*)\[\/.email\]/","<a href=\"mailto:$1\">$2</a>",$threadpost);

    $threadpost = preg_replace("/\[img\](.*)\[\/img\]/","<img src=\"$1\" alt=\"\" border=\"0\" />",$threadpost);   /// line 135

error:

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /data/sites/6376247832/www/web/v3/community/thread.php on line 135

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /data/sites/6376247832/www/web/v3/community/thread.php on line 135

Parse error: parse error in /data/sites/6376247832/www/web/v3/community/thread.php on line 135

[.email](.)[\/.email] and [.email=(.)](.*)[\/.email] shouldn't have the '.' before email i just added them so that you can see the tags without them being parsed by this board!!!

[pyro]

This code worked for me (and I fixed the greedieness issued that you'd be bound to run into... 😉)

<?PHP
$threadpost = preg_replace("/\\[email\\](.*?)\\[\\/email\\]/","<a href=\"mailto:$1\">$1</a>",$threadpost);
$threadpost = preg_replace("/\\[email=(.*?)\\](.*?)\\[\\/email\\]/","<a href=\"mailto:$1\">$2</a>",$threadpost);
$threadpost = preg_replace("/\\[img\\](.*?)\\[\\/img\\]/","<img src=\"$1\" alt=\"\" border=\"0\" />",$threadpost);   /// line 135
?>

[stew]

cheers dude...

ive actually just been reading up about preg_replace in the manual and i was just wondering if you could explain what greediness and ungreediness means....

oh and i still get the same error for some reason....

stew

[pyro]

Sure thing.

Basically, PHP's quantifiers (such as * and +) are greedy, by default. This means that they will match as much as possible. Take this example:

[email][e-mail][/email] and [email][e-mail][/email]

your first regex statment would match like this:

[email][color=red][e-mail][/email] and [email][e-mail][/color][/email]

Resulting in:

<a href="mailto:[e-mail]&#91;/email&#93; and &#91;email&#93;[e-mail]">[e-mail]&#91;/email&#93; and &#91;email&#93;[e-mail]</a>

However, if we set the matching to lazy (using ?) it will break at the first occurence of [/email], rather than that last, and will result in two matches:

[email][color=red][e-mail][/color][/email] and [email][color=red][e-mail][/color][/email]

Resulting in:

<a href="mailto:[e-mail]">[e-mail]</a> and <a href="mailto:[e-mail]">[e-mail]</a>

Hope that helps... 🙂

[stew]

i still got the same error after having tried the code you gave but, then i removed:

$threadpost = preg_replace("/\[img width=([0-9]+) height=([0-9]+)\s*\](.+?)\[\/img\]/i","<img src="\\3" alt="" border="0" width="\\1" height="\\2" />",$threadpost);
        $threadpost = preg_replace("/\[img height=([0-9]+) width=([0-9]+)\s*\](.+?)\[\/img\]/i","<img src="\\3" alt="" border="0" width="\\2" height="\\1" />",$threadpost);

and it worked fine.... any ideas?

there IS a '\ ' after the first '/' in each preg_replace fucntion.... but for some reason it doesn't show up on the preview or post.!

[pyro]

In your replacements, you did not escape the inner double quotes.

[stew]

cheers dude worked like a charm!

[pyro]

Good deal... 🙂