help with this dynamic listbox (time)

[aron]

i hacked a script that i found that was running a date listbox. as in

[month] [day] [year].

i hacked it to do time. (i dunno if its the correct way of doing it thoe)

[houre (12 hour time)] [minute]

function TimeSelector($inName)
{

/ make hour selector /
echo "<SELECT NAME=" . $inName . "Hour>\n";
for($currentHour=1; $currentHour <= 12; $currentHour++)
{
echo "<OPTION VALUE=\"$currentHour\"";
echo ">$currentHour\n";
}
echo "</SELECT>";
echo ":";
/ make minute selector /
echo "<SELECT NAME=" . $inName . "Minute>\n";
for($currentMinute = 00; $currentMinute <= 59; $currentMinute++)
{
echo "<OPTION VALUE=\"$currentMinute\"";
echo ">$currentMinute\n";
}
echo "</SELECT>";

}
<?php TimeSelector("time1"); ?>

but in my database its a time field so if the time is 12:30

i want to auto select 12 for the houre and 30 for the minute.

this is how i display the time.

<? print $line["auction_time_open"];?>

cheers.
aron.

[LordShryku]

Well, I would think this would be better off in a 24 hour format, but anyway, provided you've done the query before this, all you need is a simple explode, if statement in the options.

function TimeSelector($inName, $curTime)
{
   $splitTime = explode(":",$curTime);
   $hour = $splitTime[0];
   $minute = $splittime[1];

   /* make hour selector */
   echo "<SELECT NAME=" . $inName . "Hour>\n";
   for($currentHour=1; $currentHour <= 12; $currentHour++)
   {
      echo "<OPTION VALUE=\"$currentHour\"";
      if($currentHour == $hour) {
         echo " selected";
      }
      echo ">$currentHour\n";
   }
   echo "</SELECT>";
   echo ":";
   /* make minute selector */
   echo "<SELECT NAME=" . $inName . "Minute>\n";
   for($currentMinute = 00; $currentMinute <= 59; $currentMinute++)
   {
      echo "<OPTION VALUE=\"$currentMinute\"";
      if($currentMinute == $minute) {
         echo " selected";
      }
      echo ">$currentMinute\n";
   }
   echo "</SELECT>";
} 


// Then add the time from the DB to be passed to the function

TimeSelector("time1", $line["auction_time_open"]);

[aron]

you said it would be better to do in 24 hr is that a big job to change it. would you be able to help. if not that cool ill just leave it 12 houre.

cheers
aron.

[LordShryku]

Well, I don't know how many of your other scripts it would affect, and you should probably check the database to see that how it's storing it (I'm fairly sure the default is 24 hour). But for this script, all you should have to do is change your hour loop from 12 to 24...

[aron]

i cant change it to 24 houre because i have a am / pm select box. and it will be too much mucking around to change it.

another quick question. in my minute display it ment to display minutes from 00 to 59 so 00,01,02,03,04....55,56,57,58,59 but it displays it like this. 0,1,2,3,4....55,56,57,58,59 it misses the 0 (zero) on the minutes from 00 to 09. any way to fix this.

cheers aron.

[LordShryku]

just string another zero on there for the quick fix.

for($currentMinute = 00; $currentMinute <= 59; $currentMinute++)
{
   if(strlen($currentMinute)==1) {
      $currentMinute = "0".$currentMinute;
   }
   echo "<OPTION VALUE=\"$currentMinute\"";
   if($currentMinute == $minute) {
      echo " selected";
   }
   echo ">$currentMinute\n";
} 

[aron]

it all work good.

i want to do what you have shown to me for my date drop field now.

function TimeSelector($inName, $curTime)
{
$splitTime = explode(":",$curTime);
$hour = $splitTime[0];
$minute = $splitTime[1];

im pretty sure i can figure the rest out just need help with the splitting for date.

in my database its a date field stored in this format 2003-12-18

cheers.
aron.

[LordShryku]

$curDate = "2003-11-18";

$splitDate = explode("-",$curDate);
$year      = $splitDate[0];
$month     = $splitDate[1]; 
$day       = $splitDate[2];

[aron]

it all work except that the start years are wrong.

/ make year selector /
echo "<SELECT NAME=" . $inName . "Year>\n";
$startYear = date("Y", $useDate);
for($currentYear = $startYear - 5; $currentYear <= $startYear+5;$currentYear++)
{
echo "<OPTION VALUE=\"$currentYear\"";
if($currentYear == $year) {
echo " selected";
}
echo ">$currentYear\n";
}
echo "</SELECT>";

}

it starts at 1965 and finishes at 1975. not ment to be that looking at the script its ment to go 5 years forward from 2003 and 5 years back from 2003..

any ideas. is the server time set wrond or something.
cheers aron.

[LordShryku]

What's $useDate? The second arguement to the date function should be a timestamp. So if $useDate is a date, you should strtotime.

$startYear = date("Y", strtotime($useDate)); 

[aron]

firstly i fixed that date problem i removed this accedidently
/ if date invalid or not supplied, use current time /
if($useDate == 0)
{
$useDate = Time();
}

ok it all works now. so im moving the site from my testing server over to a live server.

lets say testserver is the testing server and liveserver is the live server.

on the test server evrything works 100% ok

on the liveserver it comes up with "Could not connect to database2 table"

the only thing i have changed is the database connection string pass, server, username. now it connects ok as it would say "Could not connect to the database server"

looking at the code it errors on line this line.

$sql = "SELECT * FROM postcodes WHERE Pcode=$postcode ORDER BY Locality";
$sql_result = mysql_query($sql,$connection) or die ("Could not connect to database2");
$rows = mysql_num_rows($sql_result);

if i change this WHERE Pcode=$postcode to WHERE Pcode='$postcode' its works but it dosent select everthing from the table postcode where the postcode is whatever it got from the querystring.

this is the querystring
admin_image.php?id=232&postcode=4305

this must be a php server problem. any suggestions.

just looked at the 2 servers.

the testingserver is on a Windows NT version 4.0
the liveserver is UNIX type: L8

is this the problem

[LordShryku]

might be a register_globals difference.
try changing this

$sql_result = mysql_query($sql,$connection) or die ("Could not connect to database2"); 

to this

$sql_result = mysql_query($sql,$connection) or die ("Error: ".mysql_error()."<br /><br />".$sql);

Should give you the error message and echo the SQL to the screen.

[aron]

i ddi what you said and his is what it produced.

Error: You have an error in your SQL syntax near 'ORDER BY Locality' at line 1

SELECT * FROM postcodes WHERE Pcode= ORDER BY Locality

i dont understand why it works on 1 server and not another.

cheers.
aron.

[LordShryku]

Like I said, probably a register globals problem. It's because you're using $postcode instead of $_GET['postcode']

[aron]

is there an easy why to fix it. can i ring the hosting company up and ask them to change something.

because i have 38 php pages and everypage uses this format to request a post and also querystring.

also all the save and update scripts use the same coding.

cheers.

[LordShryku]

You could try. I doubt they'll change it for you though....

[aron]

you said registered globals.

[LordShryku]

Yeah, you're asking them to turn register_globals on

[aron]

i fond this would it work

php_flag register_globals on
php_value arg_separator.output &amp;

cheers aron.