$query works but i still get a returned error

[-__webdreamer__]

I am not sure what the problem is here. The script runs and deletes the relevent row but still returns "DATA from albums loaded
row id 658 did not get sent
Error deleting row!
Warning: Cannot modify header information - headers already sent by (output started at /home/pferrie/public_html/vinrev/adm/deleteid.php:2) in /home/pferrie/public_html/vinrev/adm/deleteid.php on line 21
"

<?
if (isset($_GET['tablename'])) {   

    echo "DATA from <b>{$_GET['tablename']}</b> loaded<br>";
} else {   

echo  "<i>$tablename</i> did not get sent<br>";
}
if (isset($_GET['id'])) {   

    echo "row id= <b>{$_GET['id']}</b><br>";
} else {   

 echo "row id <i>$id</i> did not get sent<br>";
}


include("connection.php");
$query = mysql_query("DELETE FROM $tablename WHERE id= $id")or die("<br>ther was an error<br>															tablename:= $tablename<br>																	
row id:= $id");
if(!mysql_query($query)) {
    echo"Error deleting row!");
}  

Header("Location: delete.php?success=$success");

?>

I am php newbie and might be missing the obviuos

Cheers Paul

example
http://thor.ancilenetworks.co.uk/~pferrie/vinrev/adm/myadmin.html
"Delete record"

[matto]

hi,

looks as if you tried to do something twice:

$query = [FIRST:] mysql_query("DELETE FROM $tablename WHERE id= $id")or ...
if(![SECOND:]mysql_query($query))

each time you place mysql_query(...) in the code, it is executed!
and at 2nd time, you try to execute $query (which is a flag (true or false) that tells you whether the FIRST query has succeded) instead of the SQL statement.

I assume you intended this:

$query_ok = mysql_query("DELETE ...");
if(!$query_ok)
die("there was an error");

or:

mysql_query("DELETE ...") or die("there was an error");

hope this helps.

[-__webdreamer__]

Still returns the same error

$query_ok = mysql_query("DELETE FROM $tablename WHERE id= $id"); 
if(!$query_ok) {
die("there was an error"); 
}else{
Header("Location: delete.php?success=$success");
}

[laserlight]

The problem is with the header()

Your output (i.e. the echo) must come after the header(), unless you resort to output buffering.

[-__webdreamer__]

I removed the top script altogether
I now have

<?
$query_ok = mysql_query("DELETE FROM $tablename WHERE id= $id");  

if(!$query_ok) { 
die("there was an error");  

}else{ 
Header("Location: delete.php?success=$success"); 
}
?>

still the same error

[laserlight]

Is that the entire script?

Another thing you'll have to watch out for is a blank line at the top.
That is also considered output.

[-__webdreamer__]

this is the page as it is

<link href="global.css" rel="stylesheet" type="text/css"> 
<?
/*
if (isset($_POST['tablename'])) {   

    echo "DATA from <b>{$_GET['tablename']}</b> loaded<br>";
} else {   

echo  "<i>$tablename</i> did not get sent<br>";
}
if (isset($_POST['id'])) {   

    echo "row id= <b>{$_GET['id']}</b><br>";
} else {   

 echo "row id <i>$id</i> did not get sent<br>";
}
*/
include("connection.php");
$query_ok = mysql_query("DELETE FROM $tablename WHERE id= $id"); 
if(!$query_ok) 
die("there was an error"); 
Header("Location: delete.php?success=$success");
?>

[laserlight]

What's on line 1?
What about the include?

[-__webdreamer__]

Line 1 is the link to the style.css

the connection file

<?

$database=mysql_connect ("localhost", "pferrie", "****") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("pferrie_vinrev"); 


function fail($errorMsg) {
    // URL-Encode error message
    $errorMsg = urlencode($errorMsg);

// Output error information and exit
print "&result=Fail&errormsg=$errorMsg";
exit;
}

?>

[-__webdreamer__]

Bugger time to leave for my day job 🙁 : (
Hopfully we can get this sorted later.

Paul

[laserlight]

Line 1 is the link to the style.css

Exactly.
It is output, so you get an error from header() later down the code.