File Upload &gt;&gt;Please help!

File Upload >>Please help!

kpowning

Ok, I can't get this script to work for me. I need it to upload the image to my folder destination and copy the link to the image that was uploaded to my table membersrigs into column Vehicle Image (blob).

Here is my code.. PLEASE HELP!

<?php require_once('mydatabase'); ?>
<? 
if ($_POST['Submit']){ 
$temp_name = $HTTP_POST_FILES['mypic']['tmp_name']; 
$size = $HTTP_POST_FILES['myfile']['size']; 
$type = $HTTP_POST_FILES['myfile']['type']; 
if ($size == 0 || $size > 512000){ 
echo "The file does not exist or is too big."; 
} elseif ($type != "image/gif" && $type != "image/jpeg" && $type != "image/png") { 
echo "This type of file is not supported."; 
} else { 
$picinf = getimagesize($temp_name); 
$width = $picinf[0]; 
$height = $picinf[1]; 
if ($width > 300 || $height > 200){ 
echo "The maximum image dimension is 300x200."; 
} else { 
$uploadpath = "/members/images/"; //Dont forget to chmod it. 
        switch ( $picinf[2] ) {  

             case 0:  

             echo "Couldnt upload: Unknown file type"; 
                break;  

             case 1:  

                $dest = $uploadpath.uniqid('img').'.gif';  

                break;  

             case 2:  

            $dest = $uploadpath.uniqid('img').'.jpg';  
            break;  
         case 3:  
            $dest = $uploadpath.uniqid('img').'.png';  
            break;  
        }  
        if ( $dest != '' ) {  

        if ( move_uploaded_file( $source, $dest ) ) {  

            echo 'File successfully stored.<BR>';  
            mysql_query("INSERT INTO membersrigs 'Vehicle Image' VALUES ('temp_name')"); 

        } else {  

            echo 'File could not be stored.<BR>';  

        }  




} else {
echo 'file successfully uploaded';
}
}
}
}
?> 
<html><title>Upload</title> 
<body>
<FORM ACTION="<?php $post_SELF ?>" METHOD=POST 
ENCTYPE="multipart/form-data"> 
<INPUT TYPE="file" NAME="mypic" SIZE=30> 
<INPUT TYPE="submit" NAME="Upload File"> 
</FORM>
</body>
</html>

flatpooks

heres some code i use that works:

// get the existing filenames
$res = mysql_query("select thumb_name,full_name from photos where photo_id=" . $_POST['photo_id']);
$oldpics = mysql_fetch_assoc($res);

// the image thing - how to know to update it?
$newpic = 0;
$thumbname = "";
$fullname = "";

if (!empty($FILES['pic_name']['name']) && is_uploaded_file($FILES['pic_name']['tmp_name'])){
// make the names
$thumbname = "pt" . $FILES['pic_name']['name'];
$fullname = "pf" . $FILES['pic_name']['name'];

// save the thumbnail
if ($_POST['fmt'] == 'P')
	resize2file($_FILES['pic_name']['tmp_name'],120,160,"../img/pthumb/" . $thumbname,85);
else
	resize2file($_FILES['pic_name']['tmp_name'],160,120,"../img/pthumb/" . $thumbname,85);

// save the full pic
move_uploaded_file($_FILES['pic_name']['tmp_name'],"../img/pfull/" . $fullname);
// signal new pic
$newpic = 1;

}

// now the photo record
$sql = "update photos set caption='" . my_addslashes($POST['caption']) . "',keywords = '" . my_addslashes($POST['keywords']) . "',psection_id = " . $_POST['psection'];

// did they select another pic
if ($newpic == 1)
$sql .= ",thumb_name = '" . $thumbname . "',full_name = '" . $fullname . "',format = '" . $_POST['fmt'] . "'";

$sql .= " where photo_id = " . $_POST['photo_id'];

$res = mysql_query($sql);

if (!$res){
$_SESSION['error_code'] = ERR_UPDATE_FAILED;
header("Location: cms_error.php");
die();
}

// delete the old files
if ($newpic == 1 && $oldpics['full_name'] != $fullname){
unlink("../img/pfull/" . $oldpics['full_name']);
unlink("../img/pthumb/" . $oldpics['thumb_name']);
}

kpowning

Great, but still I'm lost. Does this require GD library? Plus, I'm a newbie, so please explain some of the code if you will..

flatpooks

ok heh yah it does require gd

it basically creates thumbnails of uploaded images and stores the thumbnail and the original in diff folders on the server and sets a link in the database to point to the file (filenames are stored in the db not the images themselves) ... then it checks if the image was an update of an existing image so it doesnt unlink the newly uploaded version

also u have to chmod the image folders so u have permission to write to them

essentially if u dont need thumbnails u can scratch that part of the code and just use the bits that copy the file to the dest folder

[edit]
u seem to be messing up with filenames and chking if the file was uploaded
[/edit]

hope that helps
🙂

kpowning

Ok I got this script to upload correctly to my folder, but how can I make it also insert the image link into my database?
Table = membersrigs
Column = Vehicle Image (blob)

I can't seem to get this... Please help!

<?php require_once('mydatabase'); ?>
<?php
if ($HTTP_POST_VARS['submit']) {
  print_r($HTTP_POST_FILES);
  if (!is_uploaded_file($HTTP_POST_FILES['file']['tmp_name'])) {
    $error = "You did not upload a file!";
    unlink($HTTP_POST_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
    //a file was uploaded
    $maxfilesize=10240;

if ($HTTP_POST_FILES['file']['size'] > $maxfilesize) {
  $error = "file is too large";
  unlink($HTTP_POST_FILES['file']['tmp_name']);
  // assign error message, remove uploaded file, redisplay form.
} else {
  if ($HTTP_POST_FILES['file']['type'] != "image/gif" AND $HTTP_POST_FILES['file']['type'] != "image/pjpeg") { 
    $error = "This file type is not allowed";
    unlink($HTTP_POST_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
   //File has passed all validation, copy it to the final destination and remove the temporary file:
   copy($HTTP_POST_FILES['file']['tmp_name'],"/members/images/".$HTTP_POST_FILES['file']['name']);
   unlink($HTTP_POST_FILES['file']['tmp_name']);
   print "File has been successfully uploaded!";
   exit;
 }
} 
  }
}
?>

<html>
<head></head>
<body>
<form action="<?=$PHP_SELF?>" method="post" enctype="multipart/form-data">
<?=$error?>
<br><br>
Choose a file to upload:<br>
<input type="file" name="file"><br>
<input type="submit" name="submit" value="submit">
</form>
</body>
</html>

flatpooks

well u wouldnt put the link into a blob field as such (altho im sure u actually could do it) ... have a text field that contains the filename (and optionally the path to the image folder) and use that in the <img...> tag when displaying the html

kpowning

Sorry man, could u give me an example? I'm really new at this, trying to put two and two together..

Thanks..

flatpooks

ok in ur table 'membersrigs' put a column of type varchar (say 250 length) called imgname (for example) ... then in ur sql stuff u would do something like:

$res = mysql_query("insert into membersrigs (imgname,...etc...) values ('" . $_FILES['pic_name']['name'] . "',---other values---)");

if (!$res)
error.................

that should do the trick
k?
😉

kpowning

ok, tried that and nothing is being inserted into my table, I added the following after the image upload script:

$res = mysql_query("insert into membersrigs 'Vehicle Image' values ('" . $_FILES['tmp_name']['name'] . "')");

flatpooks

$res = mysql_query("insert into membersrigs 'Vehicle Image' values ('" . $_FILES['tmp_name']['name'] . "')");

should be:

$res = mysql_query("insert into membersrigs (vehicle_image) values ('" . $_FILES['tmp_name']['name'] . "')");

spaces are a bad thing in field names and the brackets around the field name is essential ... and do urself a favor ... make all ur field names lower case or u will go mad later trying to remember what the case is

kpowning

Here is my full code.. Please review it!

Also, thanks for the input on the casing and fields, but I even tried both ways, Vehicle_Image and Vehicle Image, still with no luck..

SORRY FOR DOUBLE POSTING!!! I HIT NEW THREAD INSTEAD OF REPLY...

 
<?php require_once('..mydatabase'); ?> 
<?php 
if ($HTTP_POST_VARS['submit']) { 
  print_r($HTTP_POST_FILES); 
  if  (!is_uploaded_file($HTTP_POST_FILES['file']['tmp_n
ame'])) { 
    $error = "You did not upload a file!"; 
    unlink($HTTP_POST_FILES['file']['tmp_name']); 
    // assign error message, remove uploaded file, redisplay form. 
  } else { 
    //a file was uploaded 
    $maxfilesize=10240; 

if ($HTTP_POST_FILES['file']['size'] > $maxfilesize) { 
  $error = "file is too large"; 
  unlink($HTTP_POST_FILES['file']['tmp_name']); 
  // assign error message, remove uploaded file, redisplay form. 
} else { 
  if ($HTTP_POST_FILES['file']['type'] != "image/gif" AND $HTTP_POST_FILES['file']['type'] != "image/pjpeg") {  
    $error = "This file type is not allowed"; 
    unlink($HTTP_POST_FILES['file']['tmp_name']); 
    // assign error message, remove uploaded file, redisplay form. 
  } else { 
   //File has passed all validation, copy it to the final destination and remove the temporary file: 
   copy($HTTP_POST_FILES['file']['tmp_name'],"/members/images/".$HTTP_POST_FILES['file']['name']); 
   unlink($HTTP_POST_FILES['file']['tmp_name']); 
   print "File has been successfully uploaded!"; 
   exit; 
 } 
}  
  } 
} 
$res = mysql_query("insert into membersrigs (Vehicle Image) values ('" . $_FILES['tmp_name']['name'] . "')"); 
if (isset($HTTP_POST_FILES['file'])) 
echo 'file' 
?> 
<html> 
<head></head> 
<body> 
<form name="form1" method="POST" enctype="multipart/form-data"> 

  <?=$error?> 
  <br> 
  <br> 
  Choose a file to upload:<br> 
  <input type="file" name="file"> 
  <br> 
  <input type="submit" name="submit" value="submit"> 
</form> 
</body> 
</html>

flatpooks

instead of ur 'copy(....)' line use:

// save the full pic
move_uploaded_file($FILES['your_file_input_name_on_the_html_form']['tmp_name'
],"your_image_path/" . $FILES['your_file_input_name_on_the_html_form']['name'];

the query:

mysql_query("insert into membersrigs (vehicle_image) values ('" . $_FILES['your_file_input_name_on_the_html_form']['name'] . "')");

this assumes that:

you have a column in ur membersrigs table called 'vehicle_image' that is a varchar type

[edit]
so that would be:

mysql_query("insert into membersrigs (vehicle_image) values ('" . $_FILES['file']['name'] . "')");
[/edit]

kpowning

ok, now on this same line.. I get an error:
unexpected ";" on line 25 witch includes all of this:

// save the full pic 
move_uploaded_file($_FILES['file']['tmp_name'],"/members/images/" . $_FILES['file']['name'];

any ideas?

flatpooks

errrrr try putting a closing bracket at the end of the statement before the terminating ;

maybe?

kpowning

tried that, but then I get the same error on the next line that has a closing bracket already included on it.

here is part of the code where this is happening:

if ($HTTP_POST_FILES['file']['size'] > $maxfilesize) {
      $error = "file is too large";
      unlink($HTTP_POST_FILES['file']['tmp_name']);
      // assign error message, remove uploaded file, redisplay form.
    } else {
      if ($HTTP_POST_FILES['file']['type'] != "image/gif" AND $HTTP_POST_FILES['file']['type'] != "image/pjpeg") { 
        $error = "This file type is not allowed";
        unlink($HTTP_POST_FILES['file']['tmp_name']);
        // assign error message, remove uploaded file, redisplay form.
      } else {
       //File has passed all validation, copy it to the final destination and remove the temporary file:
       // save the full pic 
       move_uploaded_file($_FILES['file']['tmp_name'],"/webapp/vhosts/gspot@gspotracing.com/members/images/" . $_FILES['file']['name']);
$HTTP_POST_FILES['file']['name']);
       unlink($HTTP_POST_FILES['file']['tmp_name']);
       print "File has been successfully uploaded!";
       exit;
     }
    } 
  }
}
mysql_query("insert into membersrigs (vimage) values ('" . $_FILES['file']['name'] . "')");

flatpooks

ummmmm i dont mind helping u but really these are basic syntax errors that u should spot if u are a php programmer:

$HTTP_POST_FILES['file']['name']);

remove that line ... it does nothing but cause a syntax error

flatpooks

and while ur at it:

if ($HTTP_POST_FILES['file']['type'] != "image/gif" AND $HTTP_POST_FILES['file']['type'] != "image/pjpeg") {

whats with the 'AND' ?????

it should be &&

kpowning

Yes, I'm very new at this and your help is very.very,very much appreciated, I have been trying to complete this for 4 days now over 8 hours a day. Seriously can't get it to insert into the database.
I changed "Vehicle Image" in my table to "vimage" and it is varchar (225).
Now I don't get an error, the image is uploaded to the directory on my server, but still no path in my database column. It's blank..

???

Thanks again..

flatpooks

if ($HTTP_POST_FILES['file']['size'] > $maxfilesize) {
$msg = "file is too large";
unlink($HTTP_POST_FILES['file']['tmp_name']);
}
else if ($HTTP_POST_FILES['file']['type'] != "image/gif" && $HTTP_POST_FILES['file']['type'] != "image/pjpeg") {

$msg = "This file type is not allowed";
unlink($HTTP_POST_FILES['file']['tmp_name']);
}
else {
move_uploaded_file($FILES['file']['tmp_name'],"/webapp/vhosts/gspot@gspotracing.com/members/images/" . $FILES['file']['name']);
// unlink($HTTP_POST_FILES['file']['tmp_name']);
$msg = "File has been successfully uploaded!";
// exit; <----------- this causes an exit BEFORE the query gets executed!!!

mysql_query("insert into membersrigs (vimage) values ('" . $_FILES['file']['name'] . "')");
}

echo $msg;

flatpooks

check back cos i made a small change to the script