Textfields dont fully populate

[-__webdreamer__]

Hello again guys

This week i have been on here and made a few posts regarding a small admin site app
http://thor.ancilenetworks.co.uk/~pferrie/vinrev/adm/myadmin.html

Most of it is now working thank god, but still have have problems fully populating the textfields when i go to edit a record.
Only one of the fields fully populates with the data returned from the $query
If i view the source file via the broswer(right click / view source) i can see that the data has been sent ok
<input type='text' name='format' size=25 maxlength=25 value=cd format>
But all i see is "cd"
Anyone

cheers

Paul

[BuzzLY]

ALWAYS use quotes around ALL of your attribute values.

<input type="text" name="format" size="25" maxlength="25" value="cd format">

HTH

[-__webdreamer__]

So how would i do that with php echo?

    printf("<input type='hidden' name='id' value=%s>	
	Artist <br><input type='text' name='artist' size=25 maxlength=25 value=%s><br>
	Title <br><input type='text' name='title' size=25 maxlength=25 value=%s><br>
	Picture <br><input type='text' name='picture' size=25 maxlength=25 value=%s><br>
	Review  <br><textarea name='review' cols=30 rows=5>%s</textarea><br>
	Label<br><input type='text' name='label' size=25 maxlength=25 value=%s><br>
	Format <br><input type='text' name='format' size=25 maxlength=25 value=%s><br>
	Price <br><input type='text' name='price' size=10 maxlength=8 value=%s><br>
	Rating <br><input type='text' name='rating' size=10 maxlength=8 value=%s><br>\n", 
	$myrow["id"], 
	$artist=$myrow["artist"], 
	$title=$myrow["title"], 
	$picture=$myrow["picture"], 
	$review=$myrow["review"], 
	$lable=$myrow["label"], 
	$format=$myrow["format"], 
	$price=$myrow["price"],
	$rating=$myrow["rating"]);
  } while ($myrow = mysql_fetch_array($result));
	echo "<br><input type='submit' value='Submit' name='submit'>";
echo "<input type='reset' value='Reset' name='reset'></form>\n";
}

[tomwerner]

instead of using ' you can use \" which works better. Like the previous post, put it round all your attributes, not just the numerical ones.

[BuzzLY]

1. ALWAYS put double quotes around tag attributes. ALL of them. Including numbers. In other words, <input type="hidden" name="id" value=23> is NOT right. It should be value="23". Got that? Ok.

2. When using associative arrays, get in the habit of using SINGLE quotes. PHP interprets that to mean "exactly what's in between the quotes." It's not absolutely necessary, but it's a good programming practice.

printf("<input type=\"hidden\" name=\"id\" value=\"%s\">	
Artist <br><input type=\"text\" name=\"artist\" size=\"25\" maxlength=\"25\" value=\"%s\"><br>
Title <br><input type=\"text\" name=\"title\" size=\"25\" maxlength=\"25\" value=\"%s\"><br>
Picture <br><input type=\"text\" name=\"picture\" size=\"25\" maxlength=\"25\" value=\"%s\"><br>
Review  <br><textarea name=\"review\" cols=\"30\" rows=\"5\">%s</textarea><br>
Label<br><input type=\"text\" name=\"label\" size=\"25\" maxlength=\"25\" value=\"%s\"><br>
Format <br><input type=\"text\" name=\"format\" size=\"25\" maxlength=\"25\" value=\"%s\"><br>
Price <br><input type=\"text\" name=\"price\" size=\"10\" maxlength=8 value=\"%s\"><br>
Rating <br><input type=\"text\" name=\"rating\" size=\"10\" maxlength=\"8\" value=\"%s\"><br>\n", 
$myrow['id'], 
$artist=$myrow['artist'], 
$title=$myrow['title'], 
$picture=$myrow['picture'], 
$review=$myrow['review'], 
$lable=$myrow['label'], 
$format=$myrow['format'], 
$price=$myrow['price'],
$rating=$myrow['rating']);

Of course, you could do this just as easily, which is a little easier to interpret:

<?php	
$id=$myrow['id'];
$artist=$myrow['artist'];
$title=$myrow['title'];
$picture=$myrow['picture'];
$review=$myrow['review'];
$lable=$myrow['label'];
$format=$myrow['format'];
$price=$myrow['price'];
$rating=$myrow['rating']);
?>
echo <<<EOS
<input type="hidden" name="id" value="$id">
Artist <br><input type="text" name="artist" size="25" maxlength="25" value="$artist"><br>
Title <br><input type="text" name="title" size="25" maxlength="25" value="$title"><br>
Picture <br><input type="text" name="picture" size="25" maxlength="25" value="$picture"><br>
Review  <br><textarea name="review" cols="30" rows="5">$review</textarea><br>
Label<br><input type="text" name="label" size="25" maxlength="25" value="$label"><br>
Format <br><input type="text" name="format" size="25" maxlength="25" value="$format"><br>
Price <br><input type="text" name="price" size="10" maxlength=8 value="$price"><br>
Rating <br><input type="text" name="rating" size="10" maxlength="8" value="$rating"><br>
EOS;