foreach problems!

lsalsich

I am trying to create a list of 'swears' to block from being used in an on-line application. I need to create an XML document to do so. The php code below is intended to take each 'swear' from the array $myArray as $value and then add it to the XML code in $begin and $end - to create a single line of XML per swear.

It works if I only echo 2 variables, not with all three. As you will see, I have $end commented out. Any suggestions?!?!?!

Im so stumped here!!

<?php
$myArray = file("badwords.txt");

$begin = <<< End_Text1
<ban type="word" value="
End_Text1;

$end = <<< End_Text2
" />
End_Text2;

foreach($myArray as $value)
{
echo "$begin";
echo "$value";
//echo "$end";
echo "<br>\n";
}
?>

Luke

Weedpacket

What do you mean "it works with two variables but not all three"? What happens if you echo all three, and what should happen; and what happens when you only use two?

lsalsich

What should happen is that it would produce one line of code for each $value in $myArray, sandwiched inbetween $begin and $end. Like this:

<ban type="word" value="example_swear" />
<ban type="word" value="example_swear2" />
<ban type="word" value="example_swear3" />
etc.

Whne I echo all three variables, it produces a blank page, although I get no errors.

When I echo only two variables, it produces the two exactly as I wanted. For instance:

echo $begin;
echo $value;

Produces:

<ban type="word" value="example_swear

echo $value;
echo $end;

produces:

example_swear" />

But,

echo $begin;
echo $value;
echo $end;

produces a blank page.......

I need help! this is driving me nuts!

Luke

Weedpacket

You're looking at this in a browser, aren't you? Have you tried using the browser's "View Source" facility?

lsalsich

very nice idea! On viewing the source, I do see that the 'blank page' is just not showing the code, but it is being generated - although not quite correctly.

when I echo all three variables like"

foreach($myArray as $value)
{
echo "$begin$value$end\n";

}

it echoes as:

Any idea why the line break is after $value (example_swear)?

It should be:

Luke

Weedpacket

When you read a file in with file(), the array entries that result still have the trailing newlines attached. trim() each $value before displaying it.

lsalsich

Thanks, amigo. that did it. Big help! 😃