File upload problem...

HalfLife

Here is my code:

<?php

print ("<form name=\"form1\" method=\"post\" action=\"\" enctype=\"multipart/form-data\">"); 
print ("<input type=\"file\" name=\"imagefile\"><br>");
print ("<input type=\"submit\" name=\"submit\" value=\"Submit\">");
if(isset( $submit )) {
	copy ($_FILES['imagefile']['tmp_name'], "files/".$_FILES['imagefile']['name']) or die ("Could not copy"); 
	echo ""; 
	echo "Name: ".$_FILES['imagefile']['name']." "; 
 	echo "Size: ".$_FILES['imagefile']['size']." "; 
 	echo "Type: ".$_FILES['imagefile']['type']." "; 
 	echo "Copy Done....";
}
print ("</form>
");

?>

The problem is that once I click the submit button the page is loaded for a few seconds and then loads the exact same page, no "Could not copy" massage and no "Name:,Size:,Type:...".
I check the "files/" dir and the uploaded file is not there.
The CHMOD permission of "files/" is 777.

bad76

action=\"\"

😕

Hi, I think
you are missing the action...

madd_maxx

Try to set an absolute path for your file target:

/file/......

otherwise delete the "or die" maybe you will got a better error message from your server....

HalfLife

Nope.
Absolute path doesn't work.
And when I delete the Or Die message it's the same thing, no errors, just the same page, like nothing happened...

HalfLife

Ok, I know what the problem is.
Apparently, I'm not the only one who is having this problem.
The problem is with the form's encryption method.
I read that other people that tried a file upload using a form based on Post and Enctype=multipart/form-data got no data from the form.
Someone said that it works with Get method but I'm afraid it will create a too long adress line, and I don't know how to do it.

Please help me!! This is really important!!!

HalfLife

Sorry for bumping but please help me! This is important!

madd_maxx

the get methode is certainly wrong. you have to use the form with post.

Form tag:
Use this if you want to target to the same site. Otherwise use the name of the target in the action field:

<form action="<?php print $_SERVER['PHP_SELF'] ?>" method="post" enctype="multipart/form-data">

Then try to check it with the simple code below:

<?php
$target = "/files/" . $_FILES['imagefile']['name'];

	//Check if upload alright -> else write an error
	if(is_uploaded_file($_FILES['imagefile']))	{
		@move_uploaded_file($_FILES['imagefile']['tmp_name'], $target);
	}
	else	{
		print("Couldn´t upload file\n");
	}

Let me know if it works

HalfLife

It says "Couldn't upload file".
You can check it here:
http://www.bluesky-online.net/emblem/publish2.php

rheroux

This script works fine for me for uploading files.

Take from it what you will. 😉


<?php
if($_POST['upload'])
{

$dir = "files/";

$upfile_name = $_FILES['upfile']['name'];

if($upfile_name == "")
{

echo "No file chosen to upload!";

}

elseif(file_exists($dir.$upfile_name))
{

echo "File exists on server already.  Rename the file and try uploading again.";

}

else
{

if(is_uploaded_file($upfile))

{

copy($_FILES['upfile']['tmp_name'], $dir.$upfile_name);

echo "File ".$upfile_name." uploaded successfully.";

}

}


}

else

{

?>

<table width="400" border="0" cellpadding="5" cellspacing="0">
<form method="post" action="" enctype="multipart/form-data">
<tr>
<td>
File:
</td>
<td>
<input type="file" name="upfile">
</td>
</tr>
<tr>
<td colspan="2">
<input type="submit" name="upload" value="Upload">
</td>
</tr>
</form>
</table>

<?php

}

?>

djKale

I ran around for a while trying to get file uploads to work for me and this is what did it. There is no size checking so you'll have to add that.
Note that I had to specify the full server path to copy the file to a new location. (/hsphere/local/home/testing/tmp/$img1_name)
The code came straight off the "PHP Fast and Easy Web Development" CD.

The HTML form:

<FORM METHOD="post" ACTION="do_upload.php" ENCTYPE="multipart/form-data">

<p><strong>File to Upload:</strong><br>
<INPUT TYPE="file" NAME="img1" SIZE="30"></p>

<P><INPUT TYPE="submit" NAME="submit" VALUE="Upload File"></p></FORM>

And the PHP:

<?

if ($img1_name != "") {

@copy("$img1", "/hsphere/local/home/testing/tmp/$img1_name")
	or die("Couldn't copy the file.");

} else {

die("No input file specified");

}

?>

Kale

HalfLife

It's not working...

http://www.bluesky-online.net/emblem/publish2.php

I get the "No input file specified" message...

Velausanakha

There's a good tute on www.devshed.com, I think its devshed that its on for this sorta thing.

HalfLife

Okay, I tried a different approach:

<html>
<head>
</head>
<body>
<form enctype="multipart/form-data" action="" method="post">
<input type="hidden" name="MAX_FILE_SIZE" value="100000"> File:
<input name="userfile" type="file">
<input type="submit" value="Upload">
<?php
	$userfile = $HTTP_POST_FILES['userfile']['tmp_name'];
	$userfile_name = $HTTP_POST_FILES['userfile']['name'];
	$userfile_size = $HTTP_POST_FILES['userfile']['size'];
	$userfile_type = $HTTP_POST_FILES['userfile']['type'];
	$userfile_error = $HTTP_POST_FILES['userfile']['error']; 

if ($userfile_error > 0) {
	echo 'Problem: ';
	switch ($userfile_error)
	{   case 1:
		echo 'File exceeded upload_max_filesize';
		break;
		case 2:
		echo 'File exceeded max_file_size';
		break;
		case 3:
		echo 'File only partially uploaded';
		break;
		case 4:
		echo 'No file uploaded';
		break;
	}
	exit;
} 


$upfile = '/emblem/files/'.$userfile_name; 

if (is_uploaded_file($userfile)){
	if (!move_uploaded_file($userfile, $upfile)){
		echo 'Problem: Could not move file to destination directory';
		exit;
	}
} else {
	echo 'Problem: Possible file upload attack. Filename: '.$userfile_name;
	exit;
}
echo 'File uploaded successfully<br /><br />'; 
?> 

</form>
</body>
</html>

http://www.bluesky-online.net/emblem/publish2.php
It gives me this error message: Warning: move_uploaded_file() [function.move-uploaded-file]: open_basedir restriction in effect. File(/emblem/files/armorsmall.jpg) is not within the allowed path

Again, 'Files/' dir is 777

HalfLife

You have no idea how to solve this??

mattsinclair

/emblem/files/

is probably not a directory.

try

$upfile = 'emblem/files/'.$userfile_name;

$upfile = '/home/content/b/l/u/blueskyonline/emblem/files/'.$userfile_name;

HalfLife

Whoa, okay, I tired the second one (/home/content/b/l/u/blueskyonline/emblem/files/) and I got a big error:
Warning: move_uploaded_file() [function.move-uploaded-file]: open_basedir restriction in effect. File(/tmp/phpp20g9q) is not within the allowed path(s): (/home/content/b/l/u/blueskyonline) in /home/content/b/l/u/blueskyonline/html/emblem/publish2.php on line 39

Warning: move_uploaded_file(/tmp/phpp20g9q) [function.move-uploaded-file]: failed to create stream: Operation not permitted in /home/content/b/l/u/blueskyonline/html/emblem/publish2.php on line 39

Warning: move_uploaded_file() [function.move-uploaded-file]: Unable to move '/tmp/phpp20g9q' to '/home/content/b/l/u/blueskyonline/emblem/files/gifted.jpg' in /home/content/b/l/u/blueskyonline/html/emblem/publish2.php on line 39
Problem: Could not move file to destination directory

Same link.

mattsinclair

maybe you are restricted to a certain path in the php ini...

HalfLife

huh?

mattsinclair

if you read the error it produces, you'll see that it makes reference to the PHP.INI value called "open_basedir"

here is what it says in php.ini

open_basedir, if set, limits all file operations to the defined directory and below. This directive makes most sense if used in a per-directory or per-virtualhost web server configuration file. This directive is NOT affected by whether Safe Mode is turned On or Off.

looks like, this value is turned ON, limiting you to working with files which are in your own directory. juding by your home directory, i am assuming you are working on a large server and you're not the sysadmin. the sysadmin may not want you to upload files...who knows, but php wont allow you to work with any file outside of the open_basedir path (probably "/home/content").

you might have to ask the sysadmin to change it

HalfLife

Thanks,
I asked the support if tehy could change it but unfortunately they couldn't...

Do you know a webhost that allows file upload?