[Resolved] Parse error in update statement

mOk

Hi,

Can anyone see the problemo? I am el stumpo on this one...

$sql = "UPDATE songs WHERE songid = "".$sid."\" SET title="".$title."\", copyright="".$copyright."\", credit="".$credit."\", lyricfiletxt="".$lyricfiltxt."\", lyricfileimg="".$lyricfileimg."\", wmafile="".$wmafile."\", rmfile="".$rmfile."\", mp3file="".$mp3file."\", user1="".$user1."\" ";

Thanks in advance...

LordShryku

Is it a parse error or a syntax error? I'm thinking the latter because your WHERE statement should come after your SET statement.

mOk

It is a Parse Error and occurs regardless of the location of my WHERE statement.

//build the update query
$sql = "UPDATE songs SET title="".$title."\", copyright="".$copyright."\", credit="".$credit."\", lyricfiletxt="".$lyricfiltxt."\", lyricfileimg="".$lyricfileimg."\", wmafile="".$wmafile."\", rmfile="".$rmfile."\", mp3file="".$mp3file."\", user1="".$user1."\" WHERE songid = "".$sid."\" ";

Thanks.

mOk

When I change how I quote my variables I get a syntax error

Error in query: . You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'All WHERE songid=1' at line 1

$sql = "UPDATE songs SET title=$title WHERE songid=$sid ";

Not sure why it is pointing at line 1 though... this statement is on line 21

TIA

mOk

Now it works!

$sql = "UPDATE songs SET title='$title' WHERE songid=$sid ";

single quote on the var

either php sucks! or the documentation out there is inconsistent...

LordShryku

You still need to quote the variables

$sql = "UPDATE songs 
        SET    title='".$title."' 
        WHERE  songid='".$sid."'";

mOk

Why do I need to quote the variables? Is there a side effect that I'm missing (like the data not actually passing complete)?

Because this string is doing the job...

//build the update query
$sql = "UPDATE songs SET title='$title', copyright='$copyright', credit='$credit', lyricfiletxt='$lyricfiletxt', lyricfileimg='$lyricfileimg', wmafile='$wmafile', rmfile='$rmfile', mp3file='$mp3file', user1='$user1' WHERE songid = '$sid' ";

LordShryku

The SQL needs to know when the string begins and ends just like PHP does. Otherwise, the SQL will be looking at something like this

UPDATE table
SET blah=blah, blah2=blah2, blah3=blah3

How's it supposed to know where blah ends and blah2 begins?