[Resolved] UPDATE and $HTTP_VARS I dont get the problem...

runee

Heres my code which is suppose to update a number of rows and bind them to a user id which is a primary key from another table but I keep getting
Parse error: parse error, unexpected T_VARIABLE in uppdaterar_kunder.php on line 45
I think I have tried all kinds of known quotations, but maybe I am attacking this the wrong way

Thanks!

<?php require_once('Connections/MySQL.php'); ?>
<?php
$colname_anstalld = "1";
if (isset($HTTP_GET_VARS['anstallnings_id'])) {
$colname_anstalld = (get_magic_quotes_gpc()) ? $HTTP_GET_VARS['anstallnings_id'] : addslashes($HTTP_GET_VARS['anstallnings_id']);
}
mysql_select_db($database_MySQL, $MySQL);
$query_anstalld = sprintf("SELECT * FROM employees WHERE anstallnings_id = %s", $colname_anstalld);
$anstalld = mysql_query($query_anstalld, $MySQL) or die(mysql_error());
$row_anstalld = mysql_fetch_assoc($anstalld);
$totalRows_anstalld = mysql_num_rows($anstalld);

$maxRows_MCI_free = 3;
$pageNum_MCI_free = 0;
if (isset($HTTP_GET_VARS['pageNum_MCI_free'])) {
$pageNum_MCI_free = $HTTP_GET_VARS['pageNum_MCI_free'];
}
$startRow_MCI_free = $pageNum_MCI_free * $maxRows_MCI_free;

mysql_select_db($database_MySQL, $MySQL);
$query_MCI_free = "SELECT * FROM par100 WHERE saljare_anstallnings_id = '16'";
$query_limit_MCI_free = sprintf("%s LIMIT %d, %d", $query_MCI_free, $startRow_MCI_free, $maxRows_MCI_free);
$MCI_free = mysql_query($query_limit_MCI_free, $MySQL) or die(mysql_error());
$row_MCI_free = mysql_fetch_assoc($MCI_free);

if (isset($HTTP_GET_VARS['totalRows_MCI_free'])) {
$totalRows_MCI_free = $HTTP_GET_VARS['totalRows_MCI_free'];
} else {
$all_MCI_free = mysql_query($query_MCI_free);
$totalRows_MCI_free = mysql_num_rows($all_MCI_free);
}
$totalPages_MCI_free = ceil($totalRows_MCI_free/$maxRows_MCI_free)-1;
?>
<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<p>Uppdaterar <?php echo $row_anstalld['namn']; ?>'s kontakter</p>
<p>
<?php do { ?>
<?php mysql_query(UPDATE par100 SET (saljare_anstallnings_id=$HTTP_GET_VARS[anstallnings_id]) where (primarnyckel=$row_MCI_free['primarnyckel'])) ?>
<?php } while ($row_MCI_free = mysql_fetch_assoc($MCI_free)); ?>
</p>
</body>
</html>
<?php
mysql_free_result($anstalld);

mysql_free_result($MCI_free);
?>

[code=php]<?php require_once('Connections/MySQL.php'); ?>

<?php mysql_query(UPDATE par100 SET (saljare_anstallnings_id=$HTTP_GET_VARS[anstallnings_id]) where (primarnyckel=$row_MCI_free['primarnyckel'])) ?>

superwormy

Queries are strings, and need to be in quotes:


<?php

mysql_query("UPDATE par100 SET  saljare_anstallnings_id = " . $HTTP_GET_VARS['anstallnings_id'] . " WHERE ( primarnyckel = " . $row_MCI_free['primarnyckel'] . " ) ");

?>

runee

Is this a variable/string convert problem, or am I way out here. The primarnyckel is the primarykey which is set to auto increment (int)

hmmm, have been stuck for 4 days now, but then again, I have only "coded" (with help from dreamweaver) SQL for 14 days...

Thanks for any suggestions! 😃

ahundiak

Try adding the line:
if (mysql_errno()) die(mysql_error());
after the query.

nova

As far as I can tell, it has nothing to do with the query, but you forgot the ; at the end of your mysql_query(). You also forgot to put it in between " and ".

I would however recommend you use quotes in your mysql statements because it can cause some strange errors if you dont. Example;

mysql_query("UPDATE par100 SET `saljare_anstallnings_id`='$HTTP_GET_VARS[anstallnings_id]' where `primarnyckel`='$row_MCI_free['primarnyckel']'");

runee

Now I got this...
Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in c:\inetpub\wwwroot\uppdatera_nya_kunder.php on line 43

hmmm, more errors :p why???

runee

Maybe if I explain what I want to do it is easier to come up with a proper solution...

I have two tables, one with telemarketing people and one with prospects.

What I want to do is to give out 100 new prospects to the sales people from the available ones (not connected to any sales person).

But I'm messing something up when I try to get the value from the anstallnings_id (empoyment ID) and then update the first 100 sorted by name of the prospects with the employment ID.

😕 It can't be the first time something like this has been coded? Please give me some more directions, I have search with google and on this newsboard but didn't find anything that can help me.

Thanks in advance

runee

<?php $anstallnings_id=$row_anstalld['anstallnings_id'] ?>
<?php do { ?>
<?php mysql_query("UPDATE $row_MCI_free SET " . $anstallnings_id . " WHERE ( primarnyckel = " . $row_MCI_free['primarnyckel'] . ""); ?>
<?php echo $row_MCI_free['saljare_anstallnings_id']; ?> <?php echo $anstallnings_id; ?> <?php echo $row_MCI_free['primarnyckel']; ?> 
  <?php } while ($row_MCI_free = mysql_fetch_assoc($MCI_free)); ?>

Now it parses but it doesn't update anything in the database...

runee

<?php $anstallnings_id=stripslashes($row_anstalld['anstallnings_id']) ?>
<?php do { ?>
<?php mysql_query("UPDATE par100 SET `saljare_anstallnings_id`=".$anstallnings_id." WHERE `primarnyckel`=".$row_MCI_free['primarnyckel'].""); ?>
<?php } while ($row_MCI_free = mysql_fetch_assoc($MCI_free)); ?>

working version, horray! I don't know if the stripslashes did any good, it was there when I changed a lot of other stuff... I don't dare to remove it 😃

Thanks everyone for the pushes in the right direction