geustbook keeps overwriting current entry

[forcer]

when i add an entry to my guestbook instead of listing them it is overwriting my current entry so instead of having all the entries its only displaying the one newest entry.

i have tried alot. but nothing has worked i have posted the code below, if any1 can see anything wrong please help

thanx

<?php
ob_start();

$name = $_POST['name'];
$email = $_POST['email'];
$homepage = $_POST['homepage'];
$location = $_POST['location'];
$message = $_POST['message'];

$date = gmdate("H:i, jS F");

$outputstring = "<p><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\">Name:</font> <a href=mailto:$email>".$name."</a>\n<br><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\">Date:</font> ".$date."\n";
if ($location)
	$outputstring .="<br><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\">Location:</font> ".$location."\n";
if ($homepage)
	$outputstring .= "<br><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\">Homepage:</font> <a href=$homepage>".$homepage."</a>\n</p>";
	$outputstring .= "<p>".$message."\n\n</p><hr>";



@ $fp = fopen("list.txt", "r+");

  flock($fp, 2); 

  if (!$fp)
  {
	echo "<p><strong> Your Addition to the Guestbook could not be processed at this time.  "
         ."Please try again in a few minutes.</strong></p></body></html>";
    exit;
  } 

  fwrite($fp, $outputstring);
  flock($fp, 3); 
  fclose($fp);

ob_end_clean();
header('location: guestbook.php');
die(' ');
?>

[superwormy]

You're opening the file as "r+" which places the file pointer at the beginning of the file and will overwrite anything thats already in there.

Use a different mode if you want to append new entries.

[forcer]

what different modes can i use.

i need one that adds it to the top of the file.. but ontop of the actualy content thats already in the file and not over the top of it

[Shrike]

The other options will place the pointer at the end of the file. To get something into the start you'd have to read the entire contents into a string, truncate the file, add your new string to the start of $filestring and re-write the file.

[forcer]

haha how would i do that? sorry i aint that advanced with php yet! 😛

[Shrike]

$fhandle = fopen($file, "a"); // Open file for reading, also use b param if using Windows
$fdata = fread($fhandle, filesize($file)); // Read the data
@fclose($fhandle); // Close the file
$fdata = $yournewstring."\n".$fdata; // Append your new string
$fhandle = fopen($file, "w+"); // Open the file again for writing, truncate to 0
fputs($fhandle, $fdata); // Add data back
@fclose($fhandle); // Close file

[jsim]

Shrike,
"a" mode, according to PHP documentation, is for opening file for
WRITING ONLY with placing file pointer to the end of file. "a+" provides reading. So only one line in source code needed to be changed:

//instead @ $fp = fopen("list.txt", "r+"); 
@ $fp = fopen("list.txt", "a"); 

Aditionally, if file doesn't exists fopen() with a "a" mode will attempt to create it.

[Shrike]

Oops my bad 😉

[forcer]

thanx jsim... but i have another question

when new entries are added they are added to the bottom of the file instead of the top. but i want the newest entries to be at the top.

[Shrike]

To get something into the start you'd have to read the entire contents into a string, truncate the file, add your new string to the start of $filestring and re-write the file.

Deja vu?

$fhandle = fopen($file, "r"); // As Jism rightly pointed out
$fdata = fread($fhandle, filesize($file)); // Read the data 
@fclose($fhandle); // Close the file 
$fdata = $yournewstring."\n".$fdata; // Append your new string 
$fhandle = fopen($file, "w+"); // Open the file again for writing, truncate to 0 
fputs($fhandle, $fdata); // Add data back 
@fclose($fhandle); // Close file

[forcer]

i afdded that code.

	$fhandle = fopen($file, "r"); 
	$fdata = fread($fhandle, filesize($file));
	@fclose($fhandle);
	$fdata = $outputstring."\n".$fdata;
	$fhandle = fopen($file, "w+");
	fputs($fhandle, $fdata);
	@fclose($fhandle);

is that over the top of..

fwrite($fp, $outputstring);
flock($fp, 3); 
fclose($fp);

or underneath it.. because now its not adding an entry at all

[forcer]

bump!

any1 know what ive done rong

[nick_perkins]

make sure that $file and $outputstring are defined and then the top doce should work fine without the need for the bottom code at all

[Shrike]

Also the flock() call is fairy muff if you want to add some security to the board.