[Resolved] getting image info from txt file

istanbull

i want to use a txt file to get image info when showing images in my gallery.
the code is below.

i get these variables from tthe previous page
$album
$dos
$resim

i can see the image right, but it doesnt show the info from the text

<?php
if (file_exists("albumler/".$album."/resim.txt"))
{
$fp = fopen("albumler/".$album."/resim.txt","r");
$array = file("albumler/".$album."/resim.txt");
}
?>
<img src="<?php echo "$dos$resim"; ?>" border="1">

<?php
$i=0;
while (substr($array[$i],0,strlen($resim)) != substr($resim,0,strlen($resim)) && $i<=count($array))
$i++;
echo "<b>".substr($array[$i],strlen($resim))."</b>";
?>

stolzyboy

are you getting any errors, you could also just try including the .txt file instead of using file functions...

AstroTeg

Just off the top of my head, shouldn't the 2nd line refer to $fp?

$fp = fopen("albumler/".$album."/resim.txt","r");
$array = file("albumler/".$album."/resim.txt");

Shouldn't it be:

$fp = fopen("albumler/".$album."/resim.txt","r");
$array = file($fp);

That might fix something.

The 2nd thing I noticed is your while loop. You don't have any '{' or '}' in there. So your while loop loops, but all it does is increment $i. I think you want to increment $i and issue the echo statement as well. The code would be:

while (substr($array[$i],0,strlen($resim)) != substr($resim,0,strlen($resim)) && $i<=count($array))
{
  $i++;
  echo "<b>".substr($array[$i],strlen($resim))."</b>";
}  // end  while (substr($array[$i],0,strlen($resim)) != substr($resim,0,strlen($resim)) && $i<=count($array))

Shrike

You don't actually need them because while() (as with if() for() until() etc ) are language constructs and not functions 🙂

http://uk.php.net/manual/en/control-structures.while.php

It's still a good idea to use them to avoid confusion though 😉

stolzyboy

Originally posted by Shrike
You don't actually need them because while() (as with if() for() until() etc ) are language constructs and not functions 🙂

http://uk.php.net/manual/en/control-structures.while.php

It's still a good idea to use them to avoid confusion though 😉

If your blocks to execute are on the same line, it doesn't seem his are, he increments $i and echo's stuff, that would need {}'s

WinterDragon

well!! He doesn't need the file pointer, because the file() function returns an array with the whole file in it... no need for $fp = fopen(), just a waste of space... anyways. 😛

AstroTeg

Originally posted by Shrike
You don't actually need them because while() (as with if() for() until() etc ) are language constructs and not functions 🙂

Right, but try this:

if(1)
  echo 'In the if statement line 1';
  echo 'In our out?';

if(0)
  echo 'In the if statement line 1';
  echo 'In or out?';

if(1)
  echo 'In the if statement line 1'; echo 'In our out?';

if(0)
  echo 'In the if statement line 1'; echo 'In or out?';

You don't need the '{' and '}', but the '{' and '}' will associate more than 1 line of code as a block. In the above examples, regardless if the if() is true or false, the 2nd line always executes.

Looking at istanbull's code, it appears his goal is to execute the $i++ and the echo statement, which means he has no choice but to use '{' and '}'.

AstroTeg

Originally posted by WinterDragon
well!! He doesn't need the file pointer, because the file() function returns an array with the whole file in it... no need for $fp = fopen(), just a waste of space... anyways. 😛

My bad... It didn't look right and I didn't bother looking it up.

Shrike

😃 🆒 :rolleyes: 😉

Not to mention the fact that brackets improve readability. Stop playing devils advocate Shrike 😉

AstroTeg

Originally posted by Shrike
Stop playing devils advocate Shrike 😉 [/B]

🙂

For 1 line of code, I love leaving the braces/brackets off - looks a little better in my opinion, but its all coding style. What gets fun is when you start dealing with nested for() statements:

for($a = 0; $a < count($somearray); $a++)
  for($b = 0; $b < count($somearray[$a]); $b++)
    echo $somearray[$a][$b];

Shrike

For 1 statement I like the and/or structure, very perl-ish

$a and doStuff();

Although I've not figured out yet why

$a and return true

doesn't work 😉

Thread hijacking...hmm :p

istanbull

i am a newbie 🙂
what's wrong?
here is the code adress
gallery

the first page you must see is
liste.php

i changed resim.php to the below

<?php
if (file_exists("albumler/".$album."/resim.txt"))
{
	$fp = fopen("albumler/".$album."/resim.txt","r");
	$array = file("$fp");
}
?>
<img src="<?php echo "$dos$resim"; ?>" border="1"><br>
<?php
$i=0;
while (substr($array[$i],0,strlen($resim)) != substr($resim,0,strlen($resim)) && $i<=count($array))
  	{
$i++;
echo "<b>".substr($array[$i],strlen($resim))."</b>";
	}
?>

but it doesn't work

i want to search the resim.txt which exists in the folder
album/$album/
when $resim is equal to starting of any line in resim.txt
show the line after the length of $resim

you can see all files from the adress 🙂

istanbull

i changed to this

<?php
if (file_exists("albumler/".$album."/resim.txt"))
{
	$fp = fopen("albumler/".$album."/resim.txt","r");
	$array = file("albumler/".$album."/resim.txt");
}
else 
	{ echo "what will i read? there is no file here";}
?>

and get this

--- what will i read? there is no file here

the folder is wrong 🙂
not: albumler/$album/resim.txt
my file is: album/$album/resim.txt

i must pay attention 🙂

my new code is

<?php
if (file_exists("album/".$album."/resim.txt"))
{
	$fp = fopen("album/".$album."/resim.txt","r");
	$array = file("album/".$album."/resim.txt");
}
else 
	{ echo "dosya yok ki";}
?>
<img src="<?php echo "$dos$resim"; ?>" border="1"><br>
<?php
$i=0;
while (substr($array[$i],0,strlen($resim)) != substr($resim,0,strlen($resim)) && $i<=count($array))	
$i++;
echo "<b>".substr($array[$i],strlen($resim))."</b>";	
?>

i dont use { }

istanbull

and also
cut the line

$fp = fopen("album/".$album."/resim.txt","r");

thanks