pagination problem

reemon1

what is wrong with this code for a pagination, the link for the next page of the list does not work

<?php 

@mysql_connect("localhost", "root") or die("ERROR--CAN'T CONNECT TO SERVER"); 
@mysql_select_db("mydb") or die("ERROR--CAN'T CONNECT TO DB"); 

$limit          = 2;                
$query_count    = "SELECT count(*) FROM employees";     
$result_count   = mysql_query($query_count);     
$totalrows      = mysql_num_rows($result_count); 

   // $page = $totalrows /  $limit; 

if(empty($page)){ 
    $page = 1; 
} 


$limitvalue = $page * $limit - $limit; 
$query  = "SELECT * FROM employees LIMIT $limitvalue, $limit";         
$result = mysql_query($query) or die("Error: " . mysql_error()); 

if(mysql_num_rows($result) == 0){ 
} 

echo("<table>"); 

while($row = mysql_fetch_array($result)){ 

echo "<tr><td>"; 
echo $row["first"]; 
echo "</td><td>"; 
echo $row["last"]; 
echo "</td></tr>" ; 
} 

echo"</table>"; 

if($page != 1){ 
    $pageprev = $page--; 

    echo"<a href=\'$PHP_SELF&page=$pageprev\'>PREV</a>"; 
}else{ 
    echo"PREV"; 
} 

$numofpages = $totalrows / $limit; 

for($i = 1; $i <= $numofpages; $i++){ 
    if($i == $page){ 
        echo($i."&nbsp;"); 
    }else{ 
        echo("<a href=\'$PHP_SELF?page=$i\'>$i</a>&nbsp;"); 
    } 
} 


if(($totalrows % $limit) != 0){ 
    if($i == $page){ 
        echo($i."&nbsp;"); 
    }else{ 
        echo("<a href=\'$PHP_SELF?page=$i\'>$i</a>&nbsp;"); 
    } 
} 

if(($totalrows - ($limit * $page)) > 0){ 
    $pagenext = $page++; 

    echo("<a href=\'$PHP_SELF?page=$pagenext\'>NEXT</a>"); 
}else{ 
    echo"NEXT"; 
} 

mysql_free_result($result); 

?>

Weedpacket

What does it do instead?

reemon1

it display the first two employee correctly
and it also display
link for prev and next but the link is not working they appear as if they were text not blue link

Weedpacket

In other words, I presume you mean that
in

if(($totalrows - ($limit * $page)) > 0){ 
        $pagenext = $page++; 

    echo("<a href='$PHP_SELF?page=$pagenext'>NEXT</a>"); 
}else{ 
    echo"NEXT"; 
}

$totalrows - ($limit*$page) is never > 0.

One problem you have is that
$pagenext = $page++;
won't make $pagenext equal to $page+1. You want
$pagenext = $page+1;
there. Similarly for previous pages.

Lessee:

$totalrows - ($limit*$page) > 0
$totalrows > $limit*$page
$totalrows/$limit > $page
$numofpages > $page

Okay... so the test will fail if the number of pages is equal to or fewer than the current page (presumably equal to, though you never can tell with some people).

And $numof pages will be the problem. $totalrows is always going to equal 1, because exactly one row will be returned from the query "SELECT COUNT(*)" - one row with one record containing the number you're actually after. And if $totalrows==1, then $numofpages is going to be 0.5, which is definitely less than 1, so the test fails.