Can someone help me?

skdzines

Can someone tell me what this error means and how I could fix it?

Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result resource in /home/mysite/public_html/project/products2.php on line 5

This is the query I'm trying to do:

$prod=mysql_fetch_row(mysql_query("SELECT productID, productName, productDesc, productPrice FROM products"));

Then I'm trying to echo the results like this:

while ($prod){
$prodID=$prod[0];
$prodName=$prod[1];
$prodDesc=$prod[2];
$prodPrice=$prod[3];
	echo("
	<tr>
		<td width='89'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodID."'</font></td>
    	<td width='175'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodName."'</font></td>
    	<td width='216'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodDesc."'</font></td>
    	<td width='106'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodPrice."'</font></td>
    	<td width='54'><input type='text' name='".$prodID."qty'</td>
  	</tr>
  	");
	}

Can someone help? Please!!

Thanks

LordShryku

Split your query and your fetch up. That's usually a problem of a bad query/connection.

$sql = "SELECT productID, 
               productName, 
               productDesc, 
               productPrice 
        FROM   products";

$res = mysql_query($sql) or die(mysql_error());
$prod = mysql_fetch_row($res);

skdzines

Okay, I really don't get this. I tried what you said LordShryku but then it just gave me an error saying 'No Database Selected'

I keep getting this error:
Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result resource in /home/mysite/public_html/project/products2.php on line 5

The way I have the query structured has worked for me numerous times in other scripts and now doesn't seem to want to.

This is the code on the page:

<?
require('connect.php');
require('connect_var.php');

$prod=mysql_fetch_row(mysql_query("SELECT productID, productName, productDesc, productPrice FROM products"));

echo("
<html>
<head>
<title>Product List</title>
</head>
<body>
<form method='post' action='/project/verify2.php'>
<table width='655' border='0' cellspacing='0' cellpadding='0'>
  <tr> 
    <td width='89'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><strong>Product 
      ID</strong></font></td>
    <td width='175'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><strong>Product 
      Name</strong></font></td>
    <td width='216'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><strong>Product 
      Description</strong></font></td>
    <td width='106'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><strong>Price</strong></font></td>
    <td width='54'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><strong>Qty</strong></font></td>
  </tr>
");
while ($prod){
$prodID=$prod[0];
$prodName=$prod[1];
$prodDesc=$prod[2];
$prodPrice=$prod[3];
	echo("
	<tr>
		<td width='89'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodID."'</font></td>
    	<td width='175'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodName."'</font></td>
    	<td width='216'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodDesc."'</font></td>
    	<td width='106'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>'".$prodPrice."'</font></td>
    	<td width='54'><input type='text' name='qty' size='3'></td>
  	</tr>
  	");
}
echo("
<tr>
	<td colspan='5' align='right'><br><br><input type='submit' value='Submit'>
</table>
</form>
</body>
</html>
");
mysql_close($dblink);
?>

Basically I want to grab every row in the products table and display them with the While loop.

But for some reason it will not. Like I said, I tried splitting up the query and still didn't work.

Any other suggestions anyone?

Thanks

Weedpacket

So have you made sure a database is selected? The error message is saying you haven't. LordShryku was suggesting you do a bit of debugging to try and find out what the problem is; it wasn't supposed to be a final answer because no-one can give that yet.

skdzines

Yes the database is selected. The database I'm calling is 'project' and the table I'm trying to call is 'products'

I have the call to the database in the require('connect.php'); which looks like this:

<?
$dblink=mysql_connect ($dbhost, $dbuser, $dbpass) or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ($db);
?>

And the values for the 'connect.php' are in the require('connect_vars.php'); and look like this:

<?PHP
$dbhost="localhost";
$dbuser="mysite";  //changed user for purpose of displaying here
$dbpass="password"; //changed pass for purpose of displaying here
$db="project";
?>

I only got the 'No database selected' error when I tried splitting up the query. If I have is structured the way I've been using it then I get the Warning: mysql_fetch_row(); error.

Thanks for your help,

LordShryku

Looks like you got your requires backwards then

require('connect.php');
require('connect_var.php');

if the variables that connect.php need are in connect_var.php, this should be the other way around. Try swapping them.

skdzines

Thanks LordShryku. I hate when it is something so simple as that.

Now for my next issue. It doesn't seem like my while loop is working. Basically I have about a half dozen items in my products table. I want to query all of the products and store them in the variable $prod and then assign the values of productID, productName, etc. from the database into their own variable, then for every product that is in the database it should write it to the screen in the following table row like so:

$prod=mysql_fetch_row(mysql_query("SELECT productID, productName, productDesc, productPrice, image FROM products"));
$prodID=$prod[0];
$prodName=$prod[1];
$prodDesc=$prod[2];
$prodPrice=$prod[3];
$prodImage=$prod[4];
while ($prod){
	echo("
	<tr>
		<td width='89'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>$prodID</font></td>
		<td width='107'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>$prodImage</font></td>
    	<td width='200'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>$prodName</font></td>
    	<td width='200'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>$prodDesc</font></td>
		<td width='23'></td>
    	<td width='82'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>\$$prodPrice</font></td>
    	<td width='49'><input type='text' name='qty' size='3'></td>
  	</tr>
  	");
}

It seems like the page wants to hang when I attempt this, so therefore I believe it is wrong. Any suggestions?

Thanks

LordShryku

Well, I find that lumping all the calls into one line can cause the page to take longer to load. Usually not by much, but every milisecond counts. Also, setting a variable for each one seems a little un-neccesary. As just out of preference, I use mysql_fetch_array, but that's just an opinion. And someone's gonna have to confirm this, but I think double quotes are the standard for quoting values in HTML, but then, the font tag is depreciated also. Anyway, here's what I would do:

$sql = "SELECT productID, 
               productName, 
               productDesc, 
               productPrice, 
               image 
        FROM   products";

$res = mysql_query($sql);
while($prod = mysql_fetch_array($res)) {
   echo "<tr>
           <td width='89'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prod['productID']."</font></td>
           <td width='107'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prod['image']."</font></td>
           <td width='200'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prod['productName']."</font></td>
           <td width='200'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prod['productDesc']."</font></td>
           <td width='23'></td>
           <td width='82'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>\$".$prod['productPrice']."</font></td>
           <td width='49'><input type='text' name='qty' size='3'></td> 
         </tr>";
}

skdzines

Thanks again LordShryku. It now does what I want it to.

Although now I have another question. I have changed the page a little bit so that every item in the array will display with an 'add to cart' button instead of a text box to have the user enter in the qty they wish to purchase. The code is as follows:

$sql = "SELECT productID, 
               productName, 
               productDesc, 
               productPrice, 
               image 
        FROM   products"; 

$res = mysql_query($sql); 
while($prod = mysql_fetch_array($res)) {
$prodID=$prod['productID'];
$prodImage=$prod['image']; 
$prodName=$prod['productName'];
$prodDesc=$prod['productDesc'];
$prodPrice=$prod['productPrice'];
   echo ("
   <table width='750' border='0' cellspacing='0' cellpadding='0'>
  <tr> 
    <td width='72' rowspan='2' valign='top'>".$prodImage."</td>
    <td width='49'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>Item #: <b>".$prodID."</b></font></td>
    <td width='106'>&nbsp;</td>
    <td width='419'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>".$prodName."</b></font></td>
	<td width='53'>&nbsp;</td>
    <td width='104'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>\$".$prodPrice."</b></font></td>
  </tr>
  <tr> 
    <td colspan='3'><br>
      <font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prodDesc."</font></td>
	  <td>&nbsp;</td>
    <td width='104'><br>
      <form name= method='post' action='/project/view_shopping_cart.php'>
        <input type='submit' value='Add to Cart'>
		<input type='hidden' name='prodID' value=".$prodID.">
		<input type='hidden' name='prodPrice' value=".$prodPrice.">
		<input type='hidden' name='prodName' value=".$prodName.">
		<input type='hidden' name='prodQty' value='1'>
      </form> </td>
  </tr>
</table>
<br>
<hr align='left' width='750' noshade><br>
</body>
		"); 
}

Once the user selects an item it will take them to their shopping cart and display what they have in it. Problem is, how can I make it has an array to keep displaying what they have in their shopping cart until it reaches the end, sort of like the latter when pulling from the db?

This is what I tried doing but it keeps going in an endless loop becuase $prodID will always be true:

<?
session_start(); 
  $_SESSION['prodID'] = $prodID;
  $_SESSION['prodQty'] = $prodQty;
  $_SESSION['prodPrice'] = $prodPrice;
  $_SESSION['prodName'] = $prodName;

if($prodID){
	$productTotal=$prodQty * $prodPrice;
	echo ("
	<table width='592' border='0' cellspacing='0' cellpadding='0'>
  <tr> 
    <td colspan='2'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><strong>You 
      have the following items in your shopping cart:</strong></font></td>
    <td width='92'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>&nbsp;</font></td>
  </tr>
  <tr> 
    <td width='62'>&nbsp;</td>
    <td width='438'>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr> 
    <td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>Qty:</font></strong></td>
    <td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>Name:</font></strong></td>
    <td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>Price:</font></strong></td>
<td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>Total:</font></strong></td>
  </tr>");
while($prodID){
 	echo ("
		<tr> 
    		<td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><input type='text' value=".$prodQty."></font></strong></td>
    		<td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prodName."</font></strong></td>
    		<td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prodPrice."</font></strong></td>
<td><strong><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$productTotal."</font></strong></td>
</tr>
	");
	}
	echo ("</table>
	<br>
	<br>
	<a href='/project/products2.php'>Continue Shopping</a>");
}
?>

Any suggestions? Is this also correct for storing their sessions and cookies in case they come back at a later date, so it will still display what is in their cart?

Thanks

bowchow79

A quick summary of your code as I see it:

<? 
session_start();  

$_SESSION['prodID'] = $prodID; 
$_SESSION['prodQty'] = $prodQty; 
$_SESSION['prodPrice'] = $prodPrice; 
$_SESSION['prodName'] = $prodName; 

if($prodID)
{
   // some output
   while($prodID){  // some more output  } 
   // some final output
} 
?>

I see no actual loop here - just a single item being stored in $SESSION and a check to see if it's there. Set up an array of items and then store that array to a $SESSION variable. Perhaps when you get the items from the database, or every time the user adds a new item to their cart, do something like

$_SESSION['ItemArray'][] = Array($prodID,$prodQty,$prodPrice,$prodName)

Then, to loop through all such items in the array, try:

$TmpArray = $_SESSION['ItemArray'];
foreach($TmpArray as $Item)
{
   // put your loop output here, replacing $prodID with $Item[0], etc
}

Of course, your exact implementation would be different (can you do a foreach on an array in the session superglobal directly? I'm not sure...), plus you'd probably want to add keys to your array, but still. Hope this helped!

skdzines

okay, I sort of have it working now, but with errors.

This is what I have for the products page:

<?
require('connect_var.php');
require('connect.php');

echo("
<html>
<head>
<title>Product List</title>
</head>
<body>
");
$sql = "SELECT productID, 
               productName, 
               productDesc, 
               productPrice, 
               image 
        FROM   products"; 

$res = mysql_query($sql); 
while($prod = mysql_fetch_array($res)) {
$prodID=$prod['productID'];
$prodImage=$prod['image']; 
$prodName=$prod['productName'];
$prodDesc=$prod['productDesc'];
$prodPrice=$prod['productPrice'];
   echo ("
   <table width='750' border='0' cellspacing='0' cellpadding='0'>
  <tr> 
    <td width='72' rowspan='2' valign='top'>".$prodImage."</td>
    <td width='49'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>Item #: <b>".$prodID."</b></font></td>
    <td width='106'>&nbsp;</td>
    <td width='419'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>".$prodName."</b></font></td>
	<td width='53'>&nbsp;</td>
    <td width='104'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>\$".$prodPrice."</b></font></td>
  </tr>
  <tr> 
    <td colspan='3'><br>
      <font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prodDesc."</font></td>
	  <td>&nbsp;</td>
    <td width='104'><br>
      <form name= method='post' action='/project/view_shopping_cart.php'>
        <input type='submit' value='Add to Cart'>
		<input type='hidden' name='prodID' value=".$prodID.">
		<input type='hidden' name='prodPrice' value=".$prodPrice.">
		<input type='hidden' name='prodName' value=".$prodName.">
		<input type='hidden' name='prodQty' value=1>
      </form> </td>
  </tr>
</table>
<br>
<hr align='left' width='750' noshade><br>
</body>
		"); 
}

echo("

</body>
</html>
");
mysql_close($dblink);
?>

And this is what I have for the view_shopping_cart.php page:

<? 
session_start();

@ $new = $HTTP_GET_VARS['prodID'];

if ($new){
	//new item selected
	if(!isset($HTTP_SESSION_VARS['cart'])){
		$HTTP_SESSION_VARS['cart'] = array();
		$HTTP_SESSION_VARS['items'] = 0;
		$HTTP_SESSION_VARS['total_price'] = '0.00';
	}
	if(isset($HTTP_SESSION_VARS['cart'][$new])){
		$HTTP_SESSION_VARS['cart'][$new]++;
	}else{
		$HTTP_SESSION_VARS['cart'][$new]= 1;
		$HTTP_SESSION_VARS['total_price'] = calculate_price($HTTP_SESSION_VARS['cart']);
		$HTTP_SESSION_VARS['items'] = calculate_items($HTTP_SESSION_VARS['cart']);
	}
}
if($HTTP_SESSION_VARS['cart']&&array_count_values($HTTP_SESSION_VARS['cart'])){
	echo("
		<table width='750' border='0' cellspacing='0' cellpadding='0'>
	  <tr> 
		<td width='368'><p><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>Name</b></font></p>
		<p>&nbsp;</p></td>
		<td width='138'><p><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>Price</b></font></p>
		<p>&nbsp;</p></td>
		<td width='194'><p><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>Qty</b></font></p>
		<p>&nbsp;</p></td>
		<td width='50'><p><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><b>Total</b></font></p>
		<p>&nbsp;</p></td>
	  </tr>
	");
		foreach($cart as $new => $prodQty){
		echo ("
			<td><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prodName."</font></td>
			<td><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$prodPrice."</font></td>
			<td><font size='1' face='Verdana, Arial, Helvetica, sans-serif'><input type='text' size='2'value='".$prodQty."'></font></td>
			<td><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>".$HTTP_SESSION_VARS['items']."</font></td>
		  </tr>
		  ");
		 }
		echo (" </table>
		<br> 
		<br> 
		<a href='/project/products2.php'>Continue Shopping</a>"); 
}else{
	echo 'There are no items in your cart.';
	echo '<hr />';
} 
?>
<?
// functions 

function calculate_price($cart){
	//sum total for all items in the cart
	$price = 0.0;
	if(is_array($cart)){
		foreach($cart as $new => $prodQty)
		$price +=$prodPrice * $prodQty;
	}
	return $price;
}

function calculate_items($cart){
	//sum total for items in shopping cart
	$items = 0;
	if(is_array($cart)){
		foreach($cart as $new => $prodQty){
			$items += $prodQty;
		}
	}
	return $items;
}
?>

it sort of works at times. if I call the shopping cart page without adding any items it will display the message saying there are no items in the cart. Otherwise if I select a product to add to the cart, the shopping_cart page gives this error: Warning: Invalid argument supplied for foreach() in /home/whatnott/public_html/project/view_shopping_cart.php on line 35. Then If I refresh the page it shows what is in the cart but doesn't display the total for the product and it also only displays the first word of the product name. Then if I continue to shop and add products, it adds the products but changes all of the product names to the newest product selected.

You can see what I mean by going to www.whatnott.com/project/products2.php

I hope someone can help me. I'm new to this sort of thing, especially this complex in php and need the help.

Thanks