[Resolved] If statement help

[ctsttom]

I am writing a shoutbox system (Example: webfroot.co.nz) and its almost compleate but i have built in a ip blocking system and also a vaildity checker to make sure the name and shout contents arent empty now the ip checker is working so if i block my self it acutally stops the shout from being added to the mysql data base but when i get to the next step which is to decide if the data submited is valid or not it just compleatly ignores the whole section... heres the code and i hope u can see what i mean

<?php

include("config.php");

// Check if blocked

mysql_query("USE " . $dbname . ";");
	$result = mysql_query("SELECT ip FROM blocked;");
	while($query_data = mysql_fetch_row($result))
		{

		if ($query_data[0] == $ip)
			{
				header("Location: index.php?msg=You cannot post a shout at this time beacuse your computer has been blocked, if you think this is in error please email [email][e-mail][/email]");
			}

				else // THE ELSE IS IGNORED AND THEN THE SCRIPT ENDS AND I DONT KNOW WHY

			{

				// Check for validity

				if ($nick == "" OR $shout == "")
					{
						header("Location: index.php?msg=Both fields must be completed!");
					}
						else
					{
						$date = date(Y) . "-" . date(m) . "-" . date(d);
						mysql_query("USE $dbname;");
						mysql_query("INSERT INTO $tblname (nick, shout, created, ip) VALUES ('$nick', '$shout', '$date', '$ip');");
						header ("Location: index.php?msg=Shout Added!");
					};
			};
	};
?>

[drew010]

i think one problems is having all that code in a while loop. possibly a problem with register globals too.

see if this code will work

<?php 

include("config.php"); 

// Check if blocked 

$blocked = FALSE;
mysql_query("USE " . $dbname . ";"); 
$result = mysql_query("SELECT ip FROM blocked;"); 
while($query_data = mysql_fetch_row($result)) 
{ 
    if ($query_data[0] == $ip) 
    {
        $blocked = TRUE;
        break;
    }
}

if($blocked == TRUE) {
    header("Location: index.php?msg=You cannot post a shout at this time beacuse your computer has been blocked, if you think this is in error please email [email][e-mail][/email]"); 
} else { 
    // Check for validity 
    if ($_POST[nick] == "" OR $_POST[shout] == "") 
    { 
        header("Location: index.php?msg=Both fields must be completed!"); 
     } else  { 
            $date = date(Y) . "-" . date(m) . "-" . date(d); 
            mysql_query("USE $dbname;"); 
            mysql_query("INSERT INTO $tblname (nick, shout, created, ip) VALUES ('$nick', '$shout', '$date', '$ip');"); 
            header ("Location: index.php?msg=Shout Added!"); 
     }
} 

?> 

[ctsttom]

thx thats sorted it m8