can't make it work

lisawebs

2 weeks and nothing!
I've changed the code several times
and is not working at all!,
I've tried the "" , and the ''
around field_names and variables,
and it doesn't work...

http://www.usa21.net/lisawebs_demo.php3

Norman_Graham

Hi Lisa

WHAT doesn't work? What error messages do you get? Which part of the code is causing problems?

Norm

lisawebs

although I changed the syntax of SQL sentences
in different ways, nothing is working
the program doesn't write, update or read (based on first 3 fields)

last version shows an error, when trying to write,
assuming the VALUE of a field as the NAME of that field,

but i already changed the syntax so many times,
and there's always a different error

Norman_Graham

Sorry Lisa

The link is now broken, so I can't look at your code. I suggest you post the relevant parts directly to the forum and remember to use the PHP encasing tags so that it looks like PHP.

Norm

lisawebs

//The program is supposed to
//read,write,update,delete and show all records.
//only writing works...
//
//What's wrong:
//- doesn't read, and doesn't show the msg "record not found"
//- doesn't update, and shows the right msg
//- doesn't delete, and shows msg as ok.
//- doesn't show all records (and standard SELECT * FROM...)
//
//I've tested each sql statement on PHPMYADMIN
//and works fine, of course, replacing variables with
//vaues in quotes.

<?php
// THIS IS ONE WHOLE PIECE OF PHP
//==============================
//=== G L O B A L S
//==============================
$flag = -1 ;
$msg = "" ;
$tmsg = array();
$tmsg[0] = "" ;
$tmsg[8] = "server unavailable";
$tmsg[9] = "cannot find database";
$tmsg[1] = "cannot find record" ;
$tmsg[2] = "cannot create record" ;
$tmsg[3] = "cannot update record" ;
$tmsg[4] = "cannot delete record" ;
$tmsg[12] = "record created";
$tmsg[13] = "record updated" ;
$tmsg[14] = "record deleted" ;
$rows = "";
$rec_date = $POST['rec_date'];
$rec_unit = $POST['rec_unit'];
$rec_code = $POST['rec_code'];
$rec_desc = $POST['rec_desc'];
//=============================
//=== F U N C T I O N S
//=============================
function db_connect(){
$flagthis = 0;
$dbcnx = mysql_connect("http://mysql_ourinternet.us/", "lisaweb_test","test1");
if (!$dbcnx) {
$flagthis = 8;
}
if (! @mysql_select_db("lisaweb_test") ) {
$flagthis = 9;
}
return $flagthis;
}

//-----------------------------
function fmyread($opthis){
global $rows, $rec_date, $rec_unit, $rec_code, $rec_desc ;
$flagthis = 0;
$sql = "SELECT * FROM sia_test WHERE rec_date = $rec_date AND rec_unit = $rec_unit AND rec_code = $rec_code LIMIT 1";
$result = mysql_query($sql);
if (!$result){ $flagthis = $opthis;}
else { $rows = mysql_fetch_array($result) ; }
return $flagthis;
}

//--------------------------------------
function fmycreate($opthis){
global $rec_date, $rec_unit, $rec_code, $rec_desc ;
$flagthis = 0;
$sql = "INSERT INTO sia_test ( rec_date , rec_unit , rec_code , rec_desc , rec_id ) VALUES ('$rec_date', '$rec_unit', '$rec_code', '$rec_desc', '')" ;
$result = mysql_query($sql);
if (!$result) { $flagthis = $opthis; }
return $flagthis;
}

//--------------------------------------
function fmyupdate($opthis){
global $rec_date, $rec_unit, $rec_code, $rec_desc ;
$flagthis = 0;
$sql = "UPDATE sia_test SET rec_desc = $rec_desc WHERE rec_date = $rec_date AND rec_unit = $rec_unit AND rec_code = $rec_code LIMIT 1";
$result = mysql_query($sql);
if (!$result) { $flagthis = $opthis; }
return $flagthis;
}

//--------------------------------------
function fmydelete($opthis){
global $rec_date, $rec_unit, $rec_code, $rec_desc ;
$flagthis = 0;
$sql = "DELETE FROM sia_test WHERE rec_date = $rec_date AND rec_unit = $rec_unit AND rec_code = $rec_code LIMIT 1";
// $sql = "REPLACE FROM sia_table WHERE rec_date = $rec_date AND rec_unit = $rec_unit AND rec_code = $rec_code LIMIT 1";
$result = mysql_query($sql);
if (!$result) { $flagthis = $opthis; }
return $flagthis;
}

//--------------------------------------
function fmyselect($opthis){
global $rec_date, $rec_unit, $rec_code, $rec_desc ;
$flagthis = 0;
$sql = "SELECT * FROM sia_test ";
$result = mysql_query($sql);

echo(" <script> \n ");
echo(" var t = new Array() \n ");
$rows = mysql_fetch_array($result) ;
$i = 0;
while ( $rows = mysql_fetch_array($result) ) {
echo(" t[$i] = "."'". "$rows[$rec_date]" .
- "$rows[$rec_desc]" . "'" . " \n ");
$i++;
}
echo(" </script> \n ");

if (!$result) { $flagthis = $opthis; }
return $flagthis;
}
//==== EXECUTION CONTINUE HERE ===========================
//==== EXECUTION CONTINUE HERE ===========================
//==== EXECUTION CONTINUE HERE ===========================

if (isset($POST['opcode'])) {
$opcode = $POST['opcode'];
if ($opcode > 0){ $flag = 0;}
} else $opcode = 0;

if ($flag == 0){ $flag = db_connect($flag); }
if ($flag == 0){
if ($opcode == 1) { $flag = fmyread($opcode); }
if ($opcode == 2) { $flag = fmycreate($opcode); }
if ($opcode == 3) { $flag = fmyupdate($opcode); }
if ($opcode == 4) { $flag = fmydelete($opcode); }
if ($opcode == 5) { $flag = fmyselect($opcode); }
}

$msg = $tmsg[$flag];
if ($flag > 0) { $msg = $tmsg[$flag] ; }
else { if ($opcode > 1) { $msg = $tmsg[$opcode+10]; } }

//=================================================
// CREATING JAVASCRIPT FUNCTION TO GET FLAGS & DATA
// numeric vars must be without quotes
//=================================================
echo(" <script> \n ");
echo(" var flagphp = $flag \n ");
echo(" var opcode = $opcode \n ");
echo(" var msgphp = '$msg' \n ");
echo(" var t = new Array('','','','','') \n ");
echo(" function storedata(){ \n ");
echo(" t[1] = '$rec_date' \n ");
echo(" t[2] = '$rec_unit' \n ");
echo(" t[3] = '$rec_code' \n ");
echo(" t[4] = '$rec_desc' \n ");
echo(" } \n ");
echo(" </script> \n ");

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE>DEMO</TITLE>
<META content=... name=description>
<META content=... name=keywords>
<META content=document name=resource-type>
<META content=global name=distribution>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

function sendreg(whattodo){
document.phptran.opcode.value = whattodo // 7=read, 8=update, 9=write
document.phptran.submit()
}

</script>
</head>
<BODY bgcolor="#003300" text="#ffc000" LINK="#00aaaa" VLINK="#00aaaa" ALINK="#00aaaa" MARGINWIDTH=0 MARGINHEIGHT=0 LEFTMARGIN=0 TOPMARGIN=0>

<form name=phptran ACTION="<?php echo($PHP_SELF); ?>" METHOD=POST>
<input type=hidden name=opcode value="">

<table width=500 align=center>
<tr><td colspan=2><br><br><font size=3>Testing PHP-Mysql <a href="mailto:lisawebs@yahoo.com"> by lisawebs@yahoo.com</a><br>Database name: <strong>lisaweb_test</strong><br>Table name: <strong>sia_test</strong><br>Table Structure:<br>rec_date  - VARCHAR(10)<br>rec_unit   - VARCHAR(1)<br>rec_code - VARCHAR(1)<br>rec_id - INT(4) autoincrement - PRIMARY INDEX<br>rec_desc - VARCHAR(20)<BR><a href="lisawebs_demo.txt" target="_blank">CLICK TO SEE PHP CODE</A><BR><BR> </td>
</tr><tr>
<td>Date: </td><td> <input type=text name=rec_date value="" size=10></td>
</tr><tr>
<td>Unit: </td><td> <input type=text name=rec_unit value="" size=1></td>
</tr><tr>
<td>Code: </td><td> <input type=text name=rec_code value="" size=1></td>
</tr><tr>
<td>Description: </td><td> <input type=text name=rec_desc value="" size=20><br>
</tr><tr>
<td colspan=2>
<input type=reset value="clear screen">
<input type=button value=read onClick="sendreg(1)">
<input type=button value=create onClick="sendreg(2)">
<input type=button value=update onClick="sendreg(3)">
<input type=button value=delete onClick="sendreg(4)">
<input type=button value=show_all onClick="sendreg(5)">
<br><br>... ashamed about this, but I won't give up
</td></tr></table>
<br><br>
</form>

function showdata(){
document.phptran.rec_date.value = t[1]
document.phptran.rec_unit.value = t[2]
document.phptran.rec_code.value = t[3]
document.phptran.rec_desc.value = t[4]
}

if (msgphp != "")
alert(msgphp)

if (flagphp == 0 & opcode == 1)
storedata()

if (opcode == 5){
document.write('<br>Records<br>')
for (i=0;i<t.length;i++){ document.write(t) }
}
</script>

</body>
</html>

Norman_Graham

Dear Lisa

I think this is over my head. I suspect your code is 10 times more complicated that it needs to be. I don't understand all this flag stuff. What is $opthis and where is it defined? What is $flag? It is defined once as -1 and then your if-statements check if it has a value of 0, which presumably it doesn't.

I'm probably not competent enough to help you - I can't make any sense of the code.

Sorry

Norm

lisawebs

I intend to use this program
as a common gateway to databse,
passing/receiving data_values (from/to other htms)
using jscript (from other htms)

in the future, the INPUT fields will be HIDDEN,
just to receive the values to perform I/O operations.

$opcode is the global var saying which operation
is being performed (read,write,etc)

$opthis is the function local var containing $opcode value,
I'm not familiar with var scope, etc

as soon as I can perform the I/O functions well
I'll optimize this code, but that's why is a little complicated,
I need to test also, the jscript generation (which works)

now write, update and delete works fine
but i can't read and retrieve row values...

ahundiak

in fmyselect:

You are calling mysql_fetch_array before your main fetch loop. This will cause the first record to be skipped. Was that intentional?

Echo out $rec_date and $rec_desc just to verify they have values.

Check for errors after the mysql_query statement.

Probably should use mysql_fetch_assoc instead of fetch array unless $rec_date is numeric? Either one should actually work.

And if mysql_connect fails then don't try to select a database.

BTW, exposing your database like this seems very dangerous. But I assume you will be adding sufficient checks to prevent people from messing things up.