Serious while loop help!

oprpg

Hey... I made a code with 2 while loops for a forum, and it made the table... "wierd". You can see how "wierd" it is here. Anyways, I would greatly appreciate some help. Heres the code:

<?php

include"functions.php";

include"header.php";

echo "<center>Welcome to JBoards.

<br><br>
<table border=1 width=500>
<tr><td width=2 border=0><center></td><td width=450><center><b>Thread</b></td><td width=13><center><b>Posts</td><td width=35><center><b>Mods</b></center></td></tr>";

echo "</table>";

echo "<table border=1 border=500>";

$loopy = mysql_query("SELECT * FROM topics");   /*50*/
while ($loopz = mysql_fetch_array($loopy)) {

echo "
<tr bgcolor='#4AA746'><td width=478><b><font color='#ffffff'>$loopz[name]</td></tr>";

$loopc = mysql_query("SELECT * FROM forums WHERE topicid='$loopz[topicid]'");   /*50*/
while ($loopd = mysql_fetch_array($loopc)) {

echo "<tr>";

echo "<td width=2><center></td><td width=450><a href=forum.php?f=$loopd[id]>$loopd[title]</a><br> - $loopd[desc]</td><td width=13>CS</td><td width=35>$loopd[mods]";

echo "</tr>";


}
}

echo "</table>";

?>

LordShryku

Okay, so let's start with your HTML. The center tags in your td tags should be align options. Given, they probably work as-is, but even if you used them, you should close them. Also, you're attributes should be quoted. Plus, all of your blank table cells are rather disturbing, but they probably have some purpose I'm guessing. All that said, this could all be done with one query, joining the tables, and one loop.

$sql = "SELECT f.* 
          FROM topics t, forums f
         WHERE t.topicid = f.topicid";
$result = mysql_query($sql);
while($row=mysql_fetch_array($result)) {
   // do your stuf here
}