global variables off - what's missing in this query?

[orionblue]

Hi there,

I have just installed PHP locally to test my scripts with globals set to off (my remote server is set to on and the scripts all work there) but I am having trouble with a few things here and there. The following code is not working locally, so I'm assuming it's a problem w my variables. $numrows is set further up in the script. How should I be passing/setting these variables?

	
if(empty($page))
		{ 
			$page = 1; 
		} 
	$limitvalue1 = $page*$limit-($limit); 

$sql = "SELECT * from hr_photos 
		WHERE l_id='$_REQUEST[l_id]' 
		LIMIT $limitvalue1, $limit"; 
$sql_result = mysql_query($sql) or die ("Couldn't execute query");

if ($numrows > 0 ) 
	{
		while ($myrow = mysql_fetch_array($sql_result)) 
			{ 
				$filename = $myrow["filename"];
				$pid = $myrow["p_id"];
				$p_caption = $myrow["p_caption"];
				$aid = $myrow["account_id"];
				$lid = $myrow["l_id"];

				echo "<a href='photo_large.php?lid=$lid&pid=$pid#photos' target=blank><img src=\"$photoPath/$aid/$lid/$filename\" height=70 border=1 hspace=2 vspace=0 alt='$p_caption'></a>";
			} 
	} 
	else 
		{
			print "There are no photos available for this listing.";
		}
mysql_close();

thank you for any help...

[kevinsequeira]

what exactly is the problem. if globals is set OFF then u need to use $POST['varname'] or $GET['varname'] when u refer to a variable in a page. you setr variables the same way as before.

<form name="test_form" method="POST" action="form_action.php">
<input type="text" name="f_name">
</form>

//form_action.php
//globals ON u can use
echo $f_name;
//globals OFF u have to use
echo $POST['f_name'];
//if method was get then use
echo $GET['f_name'];

reg
kevin

[orionblue]

Thank you, but there is no form on the page. The variable $_REQUEST[l_id] is passed from <A HREF> on a previous page. I understand how passed variables are retrieved from a form or through an url, but this particular snippit retrieves a collection of photographs from a table where the id is x. The id is being passed (I can echo it) but 'there are no photos for this listing' is echoed along with it.

I'm not sure what variables here have to be changed, since they are all declared earlier on in the same script - ie. $limit, $page, $limitvalue1. If the variable is declared earlier in the script (with no input from outside sources), I don't know what to change the variables to ($GET/$REQUEST/$_POST etc.) or if they even need to be, and, if not, then what is the problem?

thanks again

[kevinsequeira]

$sql = "SELECT * from hr_photos WHERE l_id='$_REQUEST[l_id]'
LIMIT $limitvalue1, $limit";

change it to

$sql = "SELECT * from hr_photos
WHERE l_id='$_GET[l_id]'
LIMIT $limitvalue1, $limit";

also try echo $sql to see what it evaluates to
reg
kevin

[orionblue]

thanks Kevin,

I'll give that a go - I thought that REQUEST and GET did relatively the same thing, is there a reason GET would be more appropriate?