== comparison probs

fetish

okay...

i've got an if statement:

if(access_level(current_user()) > 0 ||
current_user() == $row["author"])
{
blah
}

the first part of the if statement evaluates how I expect it to and should be fairly self explanatory.

The next part (current_user() == $row["author"])

seems to evaluate to true even when currentuser() is 0 and $row["author"] is not zero... Am i overlooking something?

manzellb

ahundiak

You probably want to use && (AND) instead of || (OR)

fetish

I should clarify - the blah code displays a panel where you can edit or delete a posting to small bulleting board system.

I want any admin to be able to do this, and also the author of the post, so an and statement would be innappropriate.

Regardless, the second clause is always evaluating to true...

LordShryku

While this may not be the problem, it would help your performance to set current_user() as a variable.

$user = current_user();
if(access_level($user) > 0 || $user == $row["author"]) {
   blah;
} 
/* current_user is only ran/evaluated once */

if(access_level(current_user()) > 0 ||
current_user() == $row["author"])
{
blah
}
/* current_user is ran/evaluated twice. Not counting how many more times you use it on the page */

Just a suggestion. Should save you processing time.

ahundiak

So you have tried
if (current_user() == $row['author'])

And it's always true? Or are you basing the "always true" on your compund if statement?

I suppose you might try
if((access_level(current_user()) > 0) ||
(current_user() == $row["author"]))

That removes any question of precedence.

Or maybe $row is not in scope? Really reaching here.

fetish

I seem to think I have fixed the problem - current_user() now returns NULL instead of 0 when there is no current user - btw, I had tracked down the problem to the second statement; but it's working...... for now.

0- mrb