??passing $sql query as a parameter

[lisawebs]

Why the following doesn't work?

$avalues = array();
$avalues[1] = $datavalue;
$sql = "UPDATE table SET fieldname = '$avalues[1]' ";
doupdate($sql);

function doupdate($sql);
global $avalues;
$result = mysql_query($sql);
....
// $result is ALWAYS false
// but WAIT!, when I place the $sql =... line
// inside the function it WORKS!,

WHY? I'm doing this?

I intend to have only one function per I/O transaction,
instead of writing one for each table,
If I'd had do this, then every time I want to change or test
a new method for I/O I'd have to change many functions,
so thew probability to have errors increase.

[AstroTeg]

What does your query look like when you echo $sql to the browser?

I'd take a guess there's some issues with how you're handling $avalues and having it included in string $sql.

Also, global variables are rather evil and I'd highly recommend moving away from using them - instead of using global $avalues; - pass $avalues when calling the function: function doupdate($sql, $avlues).

[superwormy]

You're not declaring this function correctly:

function doupdate($sql);

You need to do this:

function doupdate($sql){

// all the stuf inside of the function goes here, BETWEEN BRACKET

} // this is the end of your function