A big headache for me....looping through results, validate, if ok, insert

cruz610

Hey everyone...take a look at the script below because I am in need of some serious help 🙁 Right now I am stuck. The script is supposed to loop through information submitted from a form (5 rows of 3 of the same variables, i.e. one <tr></tr> copied 5 times). Variable names are changed to be 'cinstitution1','cinstitution2' etc up to 5. What I need to do is validate EACH of these BEFORE the individual statement gets inserted. Any ideas? Thanks all, this would be a big help!

<?
$nocash=$_POST['nocash'];
if ($nocash==1) {
	$cquery=("INSERT INTO u_cash (user_id,id,institution,accountnumber,value,ownership) VALUES ('".$_SESSION['user_id']."','','','','','')");
		if (!(@ mysql_query($cquery, $connection))) {
		showerror();
		die('Query Failed');
	}
}
else{
	for ($i=1; $i<=5;$i++){
		$cid=$i;
		$cinstitution[$i]=addslashes($_POST['cinstitution'.$i]);
		$cacctnumber[$i]=addslashes($_POST['cacctnumber'.$i]);
		$cvalue[$i]=addslashes($_POST['cvalue'.$i]);
		$cownership[$i]=addslashes($_POST['cownership'.$i]);
		if (!empty($cinstitution[$i]) || !empty($cacctnumber[$i]) || !empty($cvalue[$i]) || !empty($cownership[$i])) {
			if (empty($cinstitution)) $errors .= "Please enter the name of the instution for cash account #".$i.".\n";
			if (empty($cacctnumber)) $errors .= "Please enter the account number for cash account #".$i.".\n";
			if (empty($cvalue)) $errors .= "Please enter the value of cash account #".$i.".\n";
			if (empty($cownership)) $errors .= "Please enter the name of the owner of cash account #".$i.".\n";
		}
		if (empty($errors)) {
				$cquery=("INSERT INTO u_cash (user_id,id,institution,acctnumber,value,ownership) VALUES ('".$_SESSION['user_id']."','".$i."','".$cinstitution[$i]."','".$cacctnumber[$i]."','".$cvalue[$i]."','".$cownership[$i]."')");
				if (!(@ mysql_query($cquery, $connection))) {
					showerror();
					die('Query Failed');
				}
			}
	}
}
?>

LordShryku

Do you have magic_quotes_gpc enabled? Just wondering, since you're manually adding slashes. Also, do you set an initail var for $errors anywhere?

cruz610

I am coding this to be used on any server that has php installed, not just ones with magic quotes which is why I manually add them. And yes, $errors is set way up earlier...this was just a snippet from the code and a lot of other queries follow this same format which is why i ask 🙂

LordShryku

Ok, so what exactly is failing?

cruz610

Nothing is failing. That code there works perfectly except that it inserts data before I want it to be inserted. I want it to loop through ALL of the arrays first to validate the data and THEN have it insert the data. Right now it inserts data at the end of each loop.

LordShryku

Ok, I see. So why not set $cquery up as an array, put the query in the array if everything is okay, then once the loop is done, loop through the array to do the inserts.

cruz610

That sounds like it would work...do you think you could give me a helping hand with the array though? I am learning as I go and this array stuff is stumping me😕 While I get the basic ideas, I am not sure just yet how to get it to do that. Thanks 🙂

cruz610

nm...i think i got it 🙂

$qarray = array();
	for ($i=1; $i<=5;$i++){
		$cid=$i;
		$cinstitution[$i]=addslashes($_POST['cinstitution'.$i]);
		$cacctnumber[$i]=addslashes($_POST['cacctnumber'.$i]);
		$cvalue[$i]=addslashes($_POST['cvalue'.$i]);
		$cownership[$i]=addslashes($_POST['cownership'.$i]);
//		if (!empty($cinstitution[$i]) || !empty($cacctnumber[$i]) || !empty($cvalue[$i]) || !empty($cownership[$i])) {
//			if (empty($cinstitution)) $errors .= "Please enter the name of the instution for cash account #".$i.".\n";
//			if (empty($cacctnumber)) $errors .= "Please enter the account number for cash account #".$i.".\n";
//			if (empty($cvalue)) $errors .= "Please enter the value of cash account #".$i.".\n";
//			if (empty($cownership)) $errors .= "Please enter the name of the owner of cash account #".$i.".\n";
//		}
		$qarray[$i]="INSERT INTO u_cash (user_id,id,institution,acctnumber,value,ownership) VALUES ('".$_SESSION['user_id']."','".$i."','".$cinstitution[$i]."','".$cacctnumber[$i]."','".$cvalue[$i]."','".$cownership[$i]."')";
		}
	//if (empty($errors)) {
		foreach ($qarray as $current) { 
			//$cquery=("INSERT INTO u_cash (user_id,id,institution,acctnumber,value,ownership//) VALUES ('".$_SESSION['user_id']."','".$i."','".$cinstitution[$i]."','".$cacctnumber[$i]."','".$cvalue[$i]."','".$cownership[$i]."')");
			//if (!(@ mysql_query($cquery, $connection))) {
			//	showerror();
			//	die('Query Failed');
			//}
		//}
		echo "$current <br>";
	}

As you can see I edited out a bunch of stuff but thats just for testing purpose...the array itself works and outputs what it is supposed to 🙂 Thx for the great idea!

LordShryku

Glad I could help 🙂