problem of foreach()

valen53

i got a page contain few of edit function, such as..
i select the 100 record. Then i can change the "status" - one of the select option. At the same time, i can change the time also. below is the code i used.

foreach ($_POST['status'] as $status) {
   foreach ($status as $status1) {
      foreach ($status1 as $status2) {
 ......my_sql update statement .. 
}}}

foreach ($_POST['TIME_START'] as $TIME)  {
     foreach ($TIME as $TIME1) {
        foreach ($TIME1 as $TIME2) {
 ......my_sql update statement .. 
}}}

foreach ($_POST['TIME_END'] as $END)  {
      foreach ($END as $END1) {
	        foreach ($END1 as $END2) {        

 ......my_sql update statement .. 
}}}

But the problem is when update the records, it was quite slow. i think that it was running the foreach() quite many time then cause it slow.
So any method can make it faster or compile the foreach() ?
thank to any comment.

ahundiak

Can you post the html <select> element for status field? It's not clear to me why you have nested arrays.

I would have expected something like:

$statuses = $_POST['status'];
$timeStarts = $_POST['TIME_START'];
$timeEnds = $_POST['TIME_END'];
for($i=0; count($statuses); $i++) {
  $status = $statuses[$i];
  $timeStart = $timeStarts[$i];
  $timeEnd = $timeEnds[$i];
  ... Update All 3 fields ...
}

superwormy

Post what your array looks like too, it seems like you have an awefully lot of nesting...

I would expect it to be slow because you're running a CRAPLOAD of MySQL queries... how many times does that mysql_query() functoin get called in your script?

valen53

the coding was something like that, i use ['.$empid.']['.$row[APPLY_DATE].']['.$REC.'] as primary key. That why i need
foreach() to get the data.

$pointer = $pointer + 1; 
$insertTemp = mysql_query("insert into TEMP_EMP2(super_id,emp_id,pointer,apply_date,REC) values('$ecmHR','$row[EMP_ID]', '$pointer', '$row[APPLY_DATE]','$REC' )"); 
...
<td><div align="center"><font size="2"> 
<input name="TIME_START['.$empid.']['.$row[APPLY_DATE].']['.$REC.']" type="text" value="'.$row[TIME_START].'" size="4" maxlength="4"></font></div></td>
<td><div align="center"><font size="2"> 
<input name="TIME_END['.$empid.']['.$row[APPLY_DATE].']['.$REC.']" type="text" value="'.$row[TIME_END].'" size="4" maxlength="4"> </font></div></td>
<td><div align="center"> 
<select name="status['.$empid.']['.$row[APPLY_DATE].']['.$REC.']" class="cssLine1L4">
<option value="1" selected>Not Yet</option>
<option value="0">Approve</option>
...

ahundiak

First suggestion would be to use a single column as your primary key. Probiably be easier in the long run.
In any event, add a hidden field to your table row containing just the primary key information.

<tr>
<input type="hidden" name="id[]" value="primary key values" />
<input type="text" name="TIME_START[]" value="whatever" />
...

Now it's a simple question of looping through the arrays as I showed in my first reply.

Also, retrieving is usually much faster than updating so you might want to retrieve the record, check for actual changes then only update if a change is detected.