My save password is not working

leetcrew

My save password is not working. Please help me, thanks. 🙂
globals.php

$save = trim ((!empty($HTTP_POST_VARS['save'])) ? $HTTP_POST_VARS['save'] : $HTTP_GET_VARS['save'] );


if ( $save )
{
	$io_cookies->setval("username", $request_username, time()+60*60*24*30*12); 
	$io_cookies->setval("password", $request_password, time()+60*60*24*30*12); 
} else 
{
	$io_cookies->setval("username", $request_username, time()+3600);
	$io_cookies->setval("password", $request_password, time()+3600);
}

cookies.php


function setval($cookie_name, $value=NULL, $expire=NULL )
{
	setcookie ( $GLOBALS['prefix'] . $cookie_name, $value, $expire, getvar("cookie_path"), getvar("cookie_domain") );
}

daveyboy

hard to say exactly where it could be going wrong. what is $io_cookies?

you might want to try $GET and $POST instead of $HTTP_POST_VARS etc.

certainly, saving a password in a cookie is a f*cking stupid thing to do. don't. you MUST NOT store any sensitive data in cookies. instead, store the session id and stick all your sensitive data in $_SESSION, where the client cannot access or manipulate it.

leetcrew

thanks for a reply. $io_cookies is a class name. All cookies are secured. If they have been tampered by any way, the script will delete that cookie. It will log the user out. All info from cookies are encrypted. the script will check it from time to time.

here is the my cookie source code.

./classes/cookies.php


<?php

class io_cookies
{
	function getval($cookie_name)
	{
		if (!isset( $cookie_name) )
			return 0;
		else
			return $_COOKIE[ $GLOBALS['prefix'] . $cookie_name];
	}

function setval($cookie_name, $value=NULL, $expire=NULL )
{
	global $HTTP_VAR_DATA;
	setcookie ( $GLOBALS['prefix'] . $cookie_name, $value, $expire, $HTTP_VAR_DATA[cookie_path], $HTTP_VAR_DATA[cookie_domain] );
}
}

$io_cookies = new io_cookies;

?>

the administrator of this program has an option wether to use cookies or sessions. as of now, i am coding on a cookie option

cheers =)