[Resolved] File upload incorrect.

[benson]

Hello,
I f i want too upload an file i push the button and give the pad.
But if i submit the form without giving an pad it still thinks that there was an pad given ?

Th code:

if ($_FILES["avatar"])
		{
		$ext = explode(".", $_FILES["avatar"]["name"]);
		$filehash=md5($_FILES["avatar"]["name"]);
		$_FILES["avatar"]["name"] = substr($filehash, 0, 10).".".$ext[1];
		$tmpfile = "images/avatars/".$_FILES["avatar"]["name"];
		$size = $_FILES["avatar"]["size"];
		if($size <= "20000")
			{
			if(!file_exists($tmpfile))
				{
				move_uploaded_file($_FILES['avatar']['tmp_name'], $tmpfile);
				}
			else
				{
				$_FILES["avatar"]["name"] = substr($filehash, 5, 15).".".$ext[1];
				move_uploaded_file($_FILES['avatar']['tmp_name'], $tmpfile);
				}
			chmod($tmpfile, 0755);
			echo 'De avatar is opgeslagen.<br>';
			$avat_pad = $tmpfile;
			}
		else
			{
			Echo "Je avatar is te groot: ".$size."/20000 Bytes</font>";
			}
		}

The target is that if someone uploads an file the var $avat_pad is the pad.
If not inserted an file pad (empty) there should be NO pad in the $avat_pad var.
But there is !!!!!

Kan someone explain why ?

[benson]

Nobody ?

[leatherback]

Hey Benson,

read your post again, and you'll see why there is no answer.. Where is the variable you are asking questions about!?

J.

[benson]

8th line from under to above: $avat_pad = $tmpfile;

[leatherback]

My apologies.

But I think I know what is happening? Could it be that it checks not just wether a filename exists, but also accepts folders? So if you check

if(!file_exists($tmpfile))

where

$tmpfile = "images/avatars/".$FILES["avatar"]["name"];
and
$FILES["avatar"]["name"] = ""

you will always get a false, thus move to the next section, bring along: $tmpfile = "images/avatars/"which is parsed to the $avat_pad = $tmpfile;

??
Maybe??

[benson]

that can/is be correct.
But i think the first line is somehow not working:
if($_FILES['avatar'])
{

This should say : If no avatar go to else if yes an avatar proceed?!

or must i use another something like
if($_FILES['avatar'] == "")
{

[benson]

I changed it all to this :

if ($_FILES["avatar"] != " ")
		{
		$ext = explode(".", $_FILES["avatar"]["name"]);
		$filehash=md5($_FILES["avatar"]["name"]);
		$_FILES["avatar"]["name"] = substr($filehash, 0, 10).".".$ext[1];
		$tmpfile = "images/avatars/".$_FILES["avatar"]["name"];
		$size = $_FILES["avatar"]["size"];
		if($size <= "20000")
			{
			if(!file_exists($tmpfile))
				{
				move_uploaded_file($_FILES['avatar']['tmp_name'], $tmpfile);
				chmod($tmpfile, 0755);
				$avat_pad = $tmpfile;
				}
			else
				{
				$_FILES["avatar"]["name"] = substr($filehash, 5, 15).".".$ext[1];
				move_uploaded_file($_FILES['avatar']['tmp_name'], $tmpfile);
				chmod($tmpfile, 0755);
				$avat_pad = $tmpfile;
				}
			echo 'De avatar is opgeslagen.<br>';
			}
		else
			{
			Echo "Je avatar is te groot: ".$size."/20000 Bytes</font>";
			}
		}

But this outputs:
Warning: chmod(): Unable to access images/avatars/d41d8cd98f. in /home/virtual/site15/fst/var/www/html/register.php on line 313

Warning: chmod(): No such file or directory in /home/virtual/site15/fst/var/www/html/register.php on line 313

lol i think it's doing what you said but what can i do about that ?

[leatherback]

Hehe,

Without looking any further then the first line:

if ($_FILES["avatar"] != " ")

should read:

if ($_FILES["avatar"] != "")

Hope this is it!

J.

[benson]

It wasn't 😢

I really really don't know how that can be.
Empty is empty right ?

[leatherback]

Hm..
Need to think before i post..

It can be actually.. $_FILE["avatar"] is defined.. (The formelent is there right? But the name should be empty, right?

So..

if ($_FILES["avatar"]["NAME"] != "")

Anyway.. If you keep getting trouble: Check print_r($_FILES); to see the structure & content of the aray..

J.

[benson]

lol
It was so simple indeed.
You made the code work very very very many thanks for that.

It worked.

Thnx for all,
benson