[Resolved] Problem with a mysql_num_rows() error message

Drebin

I'm getting the following error message:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in C:\apache\htdocs\newsboard\story.php on line 22

I'm trying to make a basic news posting script and I have the following code in a file called 'story.php'. Does anyone know what I have done wrong?

Thanks.

<?php>
require_once("connect.php");
?>

<?php
// Selects the fields that will be displayed
$query="SELECT news_title,news_story,from news ORDER BY news_ID DESC";
$result=mysql_query($query,$connect);

// This formats the table
echo "<table width=400, border=1, align='center'>\n";
echo "<tr><td>
<font color='navy'>Newsboard</td></tr>";

// This writes the data that has been selected
for($i=0;$i<mysql_num_rows($result);$i++){
list($news_title,$news_story)=mysql_fetch_row($result);

echo "<tr><td>$news_title $news_story</td>\n";

}

mysql_close($connect);

// This closes the table
echo "</tr><tr><td bgcolor='red'>&nbsp</td></tr>\n";
echo "</table>\n";

</body>
</html>

njm

You have a problem with your query. Try:

$query="SELECT news_title,news_story,from news ORDER BY news_ID DESC";
$result=mysql_query($query,$connect) or die(mysql_error());

but it looks like you have a comma too many (directly after news_story).

hth, njm

cwissy

also, it may be a wise idea to put in a bit of error checking, so wrap the table output code in

[FONT=courier new]if($result)
{
<table output code>
}else{
echo "<p>Sorry, either there is no news today or someone stole the database!</p>"
}[/FONT]

(the result of a mysql_query will be false if it fails)

Drebin

You're right, I did have an extra comma after news_story. That's what caused the error.

Thanks for fixing the error and for posting those error checking lines of code.

I've now changed it a bit so that only the title is displayed on the story.php page and i've linked the news_ID so that when the visitor clicks on a story, they're taken to "showstory.php" and the whole story is displayed.