how to check if country and city are correct?

ainars

I need some help how to check if user has selected correct city in form. I use Java script and if user selects a country there is another list with cities being displayed (cities of this country). Sometimes it doesn't work correctly and I need the script to check if user selected the correct city.

What i need is:
1) if user selects country "USA", he can select only one of cities located in USA. If user selected no city, 'New York' will be entered in MySQL.

2) the same with germany.

3) not all countries have city lists. If user selected a country without city list, nothing must be entered in MySQL.

Below are my functions. It looks that they work fine, but the problem is that from time to time there is no city entered in MySQL even if user selected USA or Germany. I tested it many times - it works for me, but not for all users. I changed it many times - no success.

Thank you.

if ($country == 'USA' && $city != 'New York' and $city != 'Washington' and $city !='San Francisco') {
$city1 == 'New York'
}
else {
$city1 == '$city'
}

if ($country == 'Germany' && $city != 'Berlin' and $city != 'Frankfurt' and $city !='Cologne') {
$city1 == 'Berlin'

}
else {
$city1 == '$city'
}

if ($country != 'USA' and $country != 'Germany') {

        $city1 = '';
        }

AstroTeg

First thing that stands out is: $city1 == '$city'

Two problems here. First is you're using double equals which is a comparison operation, not an assignment operation which is what I think you're looking for.

Second problem is you're using single quotes when you meant to use double quotes, but for this operation, you don't need any quotes.

What I think you're looking for is:

$city1 = $city;

And make sure you remember to include the ';' at the end of these lines. I'm not sure if these were typos when copying the code into your post or if this is the actual code...

ainars

thank you for your reply, AstroTeg. these were typos. in my script i have 3 countries with city list (about 30 cities for each country), and other countries without city list... what I wrote it's just an example, but in my script everything is correct:

$city1 = $city;

and I included ';' at the end of these lines.

As I wrote, it works for me - I tested it many times, but some users (20-30 per day) in some way can submit this form without any city for countries "USA" and "Germany" (when script says - if they don't select any city for USA and Germany, default cities "New York" and "Berlin" must be entered in MySQL.

AstroTeg

Hmm, without seeing the exact code and what the users are entering can make this tough.

I'm assuming if you rely on any JavaScript that you've already tested your form with JavaScript disabled and see how your PHP page handles it.

What happens when the user submits twice (either by multiple clicks on the submit button or hitting refresh on the output page)?

Have you tested in other browsers?

I'm thinking you have a logic bug in your code somewhere that folks are accidentally invoking. In a case like this, it can be tough to troubleshoot without being able to reproduce the problem. You may need to have your PHP code keep a log of the data being submitted and some how track it with the data making it to the database. When you come across a record that is blank, check the log and to see exactly the data that was submitted (you may need to use time stamps in the database and the log so you can match them up a bit easier). With knowledge of the data being submitted, you may find a reason why your logic is failing or at the least, you should be able to reproduce the problem.

leatherback

Hi,

I read you have many cities to check..

Just an idea for perhaps a cleaner = easier debugable code:

Create a file with countries / cities.

In this file you make countryarrays:
$usa[], $germany, ...

which holds all the cities in that country. Then in the main page, you include this file, and you can then much easier check your input:

if(! inarray($city, $usa))
{
echo "Wrong city!";
}

ainars

Thank you, leatherback.

But I just faced with other problem. I use PHP Nuke and my visitors can choose many languages of interface. So, there may be problems to display specific charachters of non-English languages.

I just posted new thread about this problem.

http://www.phpbuilder.com/board/showthread.php?s=&threadid=10265671