Function That Takes Arguments - Need Format

Volitics

Below is a function that I'm trying to get to work. It's not outputting anything. The script works ok if I leave the code outside of the function.

Can anyone tell me how to get the function below to assign values to the $DestHeight and $DestWidth variables?

$Picture = "LargePicture.jpg";

function SetDimensions($ToBeDownsizedImage){

list($Width, $Height, , $Attributes) = getimagesize($ToBeDownsizedImage);

if (($Width > 100) OR ($Height > 100)) {

if ($Width >= $Height){
$DestWidth = 100;
$DestHeight = $DestWidth / ($Width / $Height);
}else{
$DestHeight = 100;
$DestWidth = $DestHeight / ($Height / $Width);
	}

}
return($DestHeight, $DestWidth);

}

$DestHeight = SetDimensions($Picture);
$DestWidth = SetDimensions($Picture);

// It's not outputting anything here.
echo $DestHeight;
echo $DestWidth;

Thanks.

AstroTeg

Return is typically used as

return $variable;

Using return() is documented to work, but I don't think you can put multiple variables in (maybe you can and I don't know any better - I'd guess they'd be treated like an array but if this was the case, you'd at least see "Array" displayed instead of nothing).

Typically, to pass back more than one value, you put those values in an array:

// ... function dimension(...)
$aArray = array();
$aArray[0] = $var1;
$aArray[1] = $var2;
return $aArray;
}  // end function ...

Then to make use of the data, you might do:

$aMyNewArray = dimension();
// now $aMyNewArray contains the array returned

// or you could do:
list($var1, $var2) = dimension();
// This approach takes the array values and puts them into individual variables using the list command.

The other approach would be to pass the variables by reference, but generally speaking, this isn't the ideal way to go.

Volitics

AstroTeg

Thank you for the help.

Volitics

AstroTeg;

It works great! Here's what I've done.

//......

$DimensionArray = array();
$DimensionArray[0] = $Width;
$DimensionArray[1] = $Height;
$DimensionArray[2] = $DestWidth;
$DimensionArray[3] = $DestHeight;
return $DimensionArray; 	
}

// Call the function.
list($Width, $Height, $DestWidth, $DestHeight) = SetDimensions($Picture);

Thanks again.

AstroTeg

Cool...

If you ever want to "kick it up a notch", you could create a class to hold the dimensions. Then all you do is return the class which would just be one variable. Inside the class would be all your data. You may not wish to disrupt what you have going now and that's fine. But something to ponder in the future...

Weedpacket

Originally posted by Volitics
AstroTeg;

It works great! Here's what I've done.

//......

$DimensionArray = array();
$DimensionArray[0] = $Width;
$DimensionArray[1] = $Height;
$DimensionArray[2] = $DestWidth;
$DimensionArray[3] = $DestHeight;
return $DimensionArray; 	
}

[/B]

You can shorten that a bit by constructing the array and returning it in the same statement:

return array($Width, $Height, $DestWidth, $DestHeight);