Update Problem need big help

Simonhurst

hi guys

any one know where i went wrong here's the sql result output in the browser

been trying to sort this out for a week now and i'am almost bald 🙂

if any one can spare 5 mins to have a look i'd be gratefull heres the code http://falconuk.co.uk/code.zip

TIA

stolzyboy

Your update statement is wrong...

A general form is:

$query = "UPDATE tablename SET fieldname = '$whatever', fieldname1 = '$whateveragain' WHERE fieldname2 = '$something'

and according to the gif you supplied, your variables aren't coming through correctly...

AstroTeg

Sorry, I don't have enough time to look at the code, but I looked at the query (thanks VERY much - this helps greatly!)

You didn't mention what database software you are using (MySQL, MS SQL, Access).

I'm going to wild guess at MySQL. If thats the case, you have a collection of '+' you are using to concatenate your strings. MySQL doesn't like that. You can either concantenate the strings in PHP and send MySQL the finished string, or you can use CONCAT() function in MySQL. CONCAT() works by taking each parameter you give it and puts it together as one string so CONCAT("string1", " ", "string2") equals: "string1 string2" (notice the space inbetween the two words).

Simonhurst

hi guys thanks for the help here

yes its Mysql for the database

sorry the concat() statement i dont know of

i know these all work individualy but when i put it all together thats were my problems happen

i'am tottally new to php and db and trying to learn as i go i,ve been reading the forums and my phpessentials and phpbible book to help me but they only go so far

Simonhurst

Originally posted by stolzyboy
Your update statement is wrong...

A general form is:

$query = "UPDATE tablename SET fieldname = '$whatever', fieldname1 = '$whateveragain' WHERE fieldname2 = '$something'

and according to the gif you supplied, your variables aren't coming through correctly...

hiya

Tried changing $sql = "UPDATE to this $query = "UPDATE
but just got [] in the browser

yeah i was thinking it was the variables but they seem to be ok from what i can see

stolzyboy

I was merely giving you an example, don't use what I gave you as literal, just adapt your query to the example form I supplied.

Simonhurst

hiya well after some more hair pulling ive got it so it looks like this

now when i replace

$result = mysql_query($sql,$conn); if(! $result || mysql_error($conn)){ echo "[$sql]"
. mysql_error($conn); exit; }

with the standard

$sql_result = mysql_query($sql)
or die("Couldn't execute query.");

guess what yep i get the "Couldn't execute query" error pop up

any ideas ?? this really has me stummped now as the pic shows all is ok afaik now

stolzyboy

look at my example again, you are missing SET

Simonhurst

dohhhh sorry bout that 🙂

LOL your not going to belive this now it says "Couldn't modify record!"

think i should give up before i'am tottally bald ?

stolzyboy

change this line:

$sql_result = mysql_query($sql)

to this:

$sql_result = mysql_query($sql) or die(mysql_error());

that will tell you what or where the query is wrong...

Simonhurst

hi Thanks for all your help

its going though now 🙂

just one more problem

the fields that add to the tables example akill = akill + \".$akill.\"

where it was adding to the sum allready in the database isnt doing that now once this is done i'am off to buy a wig 😃

TIA

stolzyboy

if $akill is a number, you don't need it in quotes, otherwise it will treat it like a string and won't add at all

Simonhurst

tried that but it wouldnt go though again

Simonhurst

Guys thank you very very much

had to change it from \".$gkill.\" to this \"$gkill\"

now it works like it should

I wish you all a very happy new year

stolzyboy

NP, have a good one and stop back!

stolzyboy