First attempt at inserting data into mysql

wdermott

Good morning all,
I am using "PHP and MySQL Web Development" to develop an online form but have hit a snag. The code sort of kind of half works when run from within ActiveState Komodo (it writes blank records to the table) but does not work when called from the html page, Insert_ANSI.php is called but displays no message and writes nothing to mySQL. Below is what I have so far in php, I am hesitant to post the html (but have attached it) as it is generated by VisualStudio and is quite ugly, but consists of 3 fields and a submit button.
I tried replacing $HTTP_POST_VARS[] with $_POST_VARS[] but it made no difference.I also get "undefined index" warnings from the debugger but have been led to believe they can be safely ignored.

Any Hints?
TIA
Wayne McDermott

Insert_ANSI.php

<html>
<head>
<title>ANSI form</title>
</head>
<body>

<?php
// create short variable names
$ANSI_NO=$HTTP_POST_VARS['ANSI_NO'];
$ItemName=$HTTP_POST_VARS['ItemName'];
$Description=$HTTP_POST_VARS['Description'];

if (!$ANSI_NO || !$ItemName || !$Description)
{
    echo 'Data not entered';
    exit;
}

@ $db = mysql_pconnect('localhost', 'root', 'cilegon');
if (!$db)
{
    echo 'Error, could not connect to database';
}

mysql_select_db('ansi');
$query = "insert into ansi values ('".$ANSI_NO."', '".$ItemName."', '".$Description."')";
$result = mysql_query($query);
if ($result)
    echo mysql_affected_rows().' ANSI inserted into database.';
?>

</body>
</html>

LordShryku

You may want to post the form up here too. The undefined index warnings are saying that so-and-so index doesn't exist in your array. In this case, probably your $HTTP_POST_VARS(which is depreciated BTW). At the very top of this page, do a print_r($_POST); and see if that outputs anything. It sounds like your variables aren't getting to the second page.

wdermott

Thanks LordShyku,
Here is the html. I will also try your print suggestion. If that does not work I will strip the html down to the basics and see if it is a problem there rather than with php.

Thanks again,

Wayne

<META http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<FONT face="Tahoma"></FONT>
<FORM action="Insert_ANSI.php" method="post">
	<DIV ms_positioning="GridLayout">
		<TABLE height="360" cellSpacing="0" cellPadding="0" width="648" border="0" ms_2d_layout="TRUE">
			<TR vAlign="top">
				<TD width="1" height="79"></TD>
				<TD width="2"></TD>
				<TD width="1"></TD>
				<TD width="1"></TD>
				<TD width="23"></TD>
				<TD width="67"></TD>
				<TD width="2"></TD>
				<TD width="1"></TD>
				<TD width="550"></TD>
			</TR>
			<TR vAlign="top">
				<TD colSpan="7" height="2"></TD>
				<TD colSpan="2" rowSpan="2">
					<INPUT id="ANSI_No" type="text" name="ANSI_No"></TD>
			</TR>
			<TR vAlign="top">
				<TD colSpan="4" height="34"></TD>
				<TD colSpan="2">
					<DIV ms_positioning="FlowLayout">
						<TABLE height="19" cellSpacing="0" cellPadding="0" width="82" border="0" ms_1d_layout="TRUE">
							<TR>
								<TD>ANSI_No&nbsp;:</TD>
							</TR>
						</TABLE>
					</DIV>
				</TD>
				<TD></TD>
			</TR>
			<TR vAlign="top">
				<TD colSpan="8" height="2"></TD>
				<TD rowSpan="2">
					<INPUT id="ItemName" type="text" name="ItemName"></TD>
			</TR>
			<TR vAlign="top">
				<TD colSpan="2" height="35"></TD>
				<TD colSpan="4">
					<DIV ms_positioning="FlowLayout">
						<TABLE height="19" cellSpacing="0" cellPadding="0" width="82" border="0" ms_1d_layout="TRUE">
							<TR>
								<TD>ItemName :</TD>
							</TR>
						</TABLE>
					</DIV>
				</TD>
				<TD colSpan="2"></TD>
			</TR>
			<TR vAlign="top">
				<TD colSpan="3" height="39"></TD>
				<TD colSpan="3">
					<DIV ms_positioning="FlowLayout">
						<TABLE height="19" cellSpacing="0" cellPadding="0" width="81" border="0" ms_1d_layout="TRUE">
							<TR>
								<TD>Description :</TD>
							</TR>
						</TABLE>
					</DIV>
				</TD>
				<TD colSpan="3">
					<INPUT id="Description" type="Description" size="79" name="Description"></TD>
			</TR>
			<TR vAlign="top">
				<TD colSpan="5" height="50"></TD>
				<TD colSpan="4">
					<INPUT type="submit" value="Submit" name="Submit"></TD>
			</TR>
			<TR vAlign="top">
				<TD height="119"></TD>
				<TD colSpan="8">
					<HR width="645" SIZE="1">
				</TD>
			</TR>
		</TABLE>
	</DIV>
</FORM>

ANSI_No

LordShryku

You're right. That's some uuugly HTML. Leave it to Microsoft 😃

Anyway, the first thing I see is a case difference. On the form, you use name="ANSI_No", but then in the PHP, you're looking for $HTTP_POST_VARS['ANSI_NO']. The O shouldn't be capitalized.

Also, just some basic debugging would be to use mysql_error() and echo the query to the screen. Something like this:

$result = mysql_query($query) or die("Error: ".mysql_error()."<br><br>".$query);

wdermott

Thanks Lord, I owe you a beer ! You've given me a number of things to work on. I'll let you know what does the trick when I crack it.

In appreciation

Wayne

wdermott

Here is the minimalist version of both the html and the php, in case anyone can see anything blindingly obvious. It has me stumped and the book I am using is no help.

Hope someone can help !

Wayne

<html>
<body>
<?php
$Description=$HTTP_POST_VARS['Description'];
@ $db = mysql_pconnect('localhost', 'root', 'cilegon');
mysql_select_db('ansi');
$query = "insert into ansi values ('".$Description."')";
echo mysql_affected_rows().' ANSI inserted into database.';
?>
</body>
</html>