Logiced out

[Hanlie]

Hi,

I'm trying to enforce refrential integerity using PHP rather than foreign keys because I just can't get the foreign keys to work in mySQL.

However, I get a funny error ("Parse error: parse error, unexpected $end in c:\inetpub\wwwroot\arms_data_model\deletes\confirm_control_delete.php on line 230") on a row that contains no code - one that occurs after all the code (PHP and HTML) is finished. This makes me think that I forgot a bracket or a semicolon somewhere.

Below is the code that I use to check whether I can delete a record from table arms_control. It should not be deleted if a screen or a report is linked to it and I check that by doing a query and testing whether the number of rows returned are greater than 0.

if ((isset($_POST["MM_delete"])) && ($_POST["MM_delete"] == "delete_control")) {
	if ($totalRows_control_screens > 0 Or $totalRows_control_reports > 0) {
		echo "You can't delete this control because it's linked to the following screen(s):";
		do { 
				echo $row_control_screens['screen_name']; 
				}
		while ($row_control_screens = mysql_fetch_assoc($control_screens)); 
		echo "\nOr it is linked to the following reports:";
		do { 
				echo $row_control_reports['report_name']; 
				}
		while ($row_control_reports = mysql_fetch_assoc($report_screens)); 
	}
	else {
		  $deleteSQL = sprintf("DELETE FROM arms_control WHERE control_id=%s",
    	                   GetSQLValueString($_POST['control_id'], "int"));

	  mysql_select_db($database_arms_data_model, $arms_data_model);
	  $Result1 = mysql_query($deleteSQL, $arms_data_model) or die(mysql_error());

	  $deleteGoTo = "delete_successful.php";
	  if (isset($_SERVER['QUERY_STRING'])) {
    	$deleteGoTo .= (strpos($deleteGoTo, '?')) ? "&" : "?";
	    $deleteGoTo .= $_SERVER['QUERY_STRING'];
	  header(sprintf("Location: %s", $deleteGoTo));
	}

}

Can anyone see a flaw in this logic or is there perhaps a better way of doing it?

Thanks
Hanlie

[planetsim]

if ((isset($_POST["MM_delete"])) && ($_POST["MM_delete"] == "delete_control")) {

  if ($totalRows_control_screens > 0 Or $totalRows_control_reports > 0) {
    echo "You can't delete this control because it's linked to the following screen(s):";

do { 
   echo $row_control_screens['screen_name']; 
} while ($row_control_screens = mysql_fetch_assoc($control_screens)); 

echo "\nOr it is linked to the following reports:";


do { 
   echo $row_control_reports['report_name']; 
} while ($row_control_reports = mysql_fetch_assoc($report_screens)); 
  } else {

 $deleteSQL = sprintf("DELETE FROM arms_control WHERE control_id=%s",
                       GetSQLValueString($_POST['control_id'], "int"));

 mysql_select_db($database_arms_data_model, $arms_data_model);
 $Result1 = mysql_query($deleteSQL, $arms_data_model) or die(mysql_error());

 $deleteGoTo = "delete_successful.php";
 if (isset($_SERVER['QUERY_STRING'])) {
   $deleteGoTo .= (strpos($deleteGoTo, '?')) ? "&" : "?";
   $deleteGoTo .= $_SERVER['QUERY_STRING'];
   header(sprintf("Location: %s", $deleteGoTo));
 }
  }
}

All i can say is indent your code and obvious errors like this will not occur. Id suggest you try that it should work

[TTT]

where is line 230? error is before it...

[Hanlie]

Right before line 230 is the following code:

<?php
mysql_free_result($control_detail);

mysql_free_result($control_screens);

mysql_free_result($control_reports);

mysql_free_result($terms);
?>

And before that is the </html> tag.

[Hanlie]

All i can say is indent your code and obvious errors like this will not occur. Id suggest you try that it should work [/B]

The original code looks much better - I didn't know how to get it to look better in this tiny posting text box.

[planetsim]

I actually opened it up in my editor to fix it and then test it. Like i said it should work. Im assuming that is not the entire code and line 230 will more than likely be

?>

or nothing

[Hanlie]

Hmm, it works you say?

Problem must be somewhere else in the code then.

Back to the drawing board...

Thanks for your help.

[leatherback]

Hi Hanlie,

Hope you noticed and tried (!) the new code posted by planetsim? He added a } to your code, which made it work....

J.

[Hanlie]

Yes, thanks.