[Resolved] using PHP to produce some javascript, and my variable comes up null

[jasonmills58]

so I have PHP write this javascript for a confirmation box before deleting something from my database. I want the message to mention the file by name by way of the variable, but the variable comes back blank, even though it comes back right elsewhere in the form. is my syntax wrong? the box pops up and works correctly, the message just doesn't reflect the data in the variable.
thanks!

print "<script language=\"javascript1.2\">";
print "function checker()"; 
print	"{";
print		"return confirm(\"Are you sure you want to delete the ".$a_row['clientname']." record?\")";
print	"}";
print	"</script>";

[leatherback]

Hi,

The only thing i can think of here is that the statement is not in your data retrieval loop. Could this be?

J.

[jasonmills58]

yeah, thats true. I've been trying to figure out how to reconcile that. see, this part is just the function defintion.

the function call is wrapped in the while loop.

hey, is there a way for me to define a variable for this function? here's my while loop:

while ( $a_row = mysql_fetch_array( $data ) ) {
	print "<tr>\n";
	print "<td><a href=\"viewCalendar.php?clientname=".urlencode( $a_row['clientname'] )."\">" .$a_row['clientname']. "</a></td>\n";
	print "<td>" .$a_row['phone']. "</td>\n";
	print "<td>" .$a_row['email']. "</td>\n";
	print "<td align=\"center\"><a href=\"editClients.php?clientname=".urlencode( $a_row['clientname'] )
			."\"><img src=\"../edit.gif\" width=\"16\" height=\"14\" border=\"0\"></a></td>";
	print "<td align=\"center\"><a href=\"deleteClientAction.php?clientname=".urlencode( $a_row['clientname'] )
			."\"><img src=\"../delete.gif\" onclick=\"return checker()\" width=\"14\" height=\"13\" border=\"0\"></a></td>";

print "</tr>\n";
}
mysql_close ( $link );
print "<script language=\"javascript1.2\">";
print "function checker()"; 
print	"{";
print		"return confirm(\"Are you sure you want to delete the ".$_GET['clientname']." record?\")";
print	"}";
print	"</script>";

maybe i could define "checker()" with some additional attributes that are called on during the while loop?

or maybe i'm just getting loopy... :rolleyes:

[leatherback]

Hey,

OK.. In you while loop, you can fill an array (If you have multiple results, which is unlikely in this case) or a variable with the value you need, and then use that var for your javascript function.

while...
  {
  $clientname = $a_row['clientname'];
  ...
  }

print "<script language=\"javascript1.2\">"; 
print "function checker()";  

print    "{"; 
print        "return confirm(\"Are you sure you want to delete the ".$clientname" record?\")"; 
print    "}"; 
print    "</script>";

[jasonmills58]

isn't that variable definition still trapped in the while loop? anyway, I updated to this and it faulted on the line I have indicated...

while ( $a_row = mysql_fetch_array( $data ) ) {
	$checkname = $a_row['clientname'];
	print "<tr>\n";
	print "<td><a href=\"viewCalendar.php?clientname=".urlencode( $a_row['clientname'] )."\">" .$a_row['clientname']. "</a></td>\n";
	print "<td>" .$a_row['phone']. "</td>\n";
	print "<td>" .$a_row['email']. "</td>\n";
	print "<td align=\"center\"><a href=\"editClients.php?clientname=".urlencode( $a_row['clientname'] )
			."\"><img src=\"../edit.gif\" width=\"16\" height=\"14\" border=\"0\"></a></td>";
	>>>>>>print "<td align=\"center\"><a href=\"deleteClientAction.php?clientname=".urlencode( $a_row['clientname'] )
			."\"><img src=\"../delete.gif\" onclick=\"return checker()\" width=\"14\" height=\"13\" border=\"0\"></a></td>";<<<<<<<

print "</tr>\n";
}
mysql_close ( $link );
print "<script language=\"javascript1.2\">";
print "function checker()"; 
print	"{";
print		"return confirm(\"Are you sure you want to delete the ".$checkname." record?\")";
print	"}";
print	"</script>";

thanks for your help!

[leatherback]

Hi,

By doing it this way, you create a variable which holds the value of that specific $a_row[]. That you can use anywhere in the script, from that point onward. The $a_row[] is only a reference, which only exists within the loop.

I cannot find anything wrong on / above the line indicated..!?

J

[jasonmills58]

well, i went with just hardcoding the javascript into the page, because it started deleting files without running the confirmation box at all. it probably had more to do with me fiddling around with it - but suffice it to say, I still can't pass a PHP variable to my javascript.

I'm confused because it seems like this would be fairly common practice. any more ideas? thanks for everything so far.

[leatherback]

Hi,

Just a short note.. Do not think about it as passing a variable to a script..

All you are doing it producing an html page for the browser to interpret. So wether this code is html, java, css or whatever.. It doesn't matter!

You have to make sure the $variable gets fillid in the while loop. Then in the next part you print / echo / .. the value of the var to the page, in the right location.

If you kee having trouble, I'd suggest to just write a very simple page, say

$result=("select * from database limit 1");

while( $row = mysql_fetch_array($result))
  {
  $myvar = $row['columname'];
  }

$script = "
<script language=\"javascript1.2\">
function checker()
  { 
  return confirm(\"Are you sure you want to delete the ";

$script .= $myvar;

$script .= "
record?\") 
} 
</script>
";

echo $script;

Once you get this to work, go one sep further, and include the rest of the page.

J.

[jasonmills58]

Thanks much Leatherback. This stuff is finally starting to sink in and make sense.
I can't thank you enough.

cheers,
Jason

[leatherback]

np.