drop down box script I want to reuse

byte_me

Trying to create a drop down box script (that I acquired) (to be reused) from a database query
sent a form to it including the field $county.

 <?php
function createSelect ( $Sname, $table, $any = 0, $select_id="" ) { 
# $Sname is the name to be applied to the select control. 
# $table is the name of the table to query. 
# NOTE: This function assumes you are using a lookup table that has 2 fields (id,name) or you only name those 2 fields in your sql statement. 
# $any 0=Without the "Any" option, 1=With the "Any" option, this is a NULL value. 
# $curr_id is used to set the "SELECTED" flag on the select control. 


require_once ("/home/mungojerry/public_html/phpforms/connect.inc");
$table = "clubs"
$sql = "SELECT * FROM $table"; #line12
$sql .= 'WHERE `county` = "$county"';  
$results = mysql_query($sql); 
printf("<select name=\"$Sname\">\n"); 
if ($any == 1) { 
printf("<option \"\">Any\n"); 
} 
while ($row = mysql_fetch_array($results)): 
    $id = $row["id"]; 
    $name = $row["name"]; 
    if ($id == $select_id) { 
        printf("<option SELECTED value=\"$id\">$name\n"); 
    } else { 
        printf("<option value=\"$id\">$name\n"); 
    } 
endwhile; 
printf("</select>\n"); 
}    

?>

get error
Parse error: parse error in /home/mungojerry/public_html/phpforms/selectbox.php on line 12

what is wrong with line 12? I have tried substituting the name of the table instead and no joy?

leatherback

hi,

PhP errors are tricky.. they usually throw an error for the first line AFTER an error occurs. in this case you have a missing ; on line 11

byte_me

Thanks for that, I am obviously missing something on this echo statement cos nothing drops out.

I have cut the code for the mo to see what the query is:

<?php 
function createSelect ( $Sname, $table, $any = 0, $select_id="" ) {  
# $Sname is the name to be applied to the select control. 
# $table is the name of the table to query. 
# NOTE: This function assumes you are using a lookup table that has 2 fields (id,name) or you only name those 2 fields in your sql statement. 
# $any 0=Without the "Any" option, 1=With the "Any" option, this is a NULL value. 
# $curr_id is used to set the "SELECTED" flag on the select control. 


require_once ("/home/mungojerry/public_html/phpforms/connect.inc"); 
$table = "clubs";
$sql = 'SELECT * FROM $table';
$sql .= 'WHERE `county` = $county';  
$results = mysql_query($sql); 
print($results);
echo($results);

I want to see what $results equals so I can see where to go next. I obviously need it in lala language today!!!!

byte_me

PS there is a end
} in the code!! to complete the function

leatherback

You are missing a part of the query..

the output of the query is only a reference id, you can then extract the data:

<?php  

    $table = "clubs"; 
    $sql = 'SELECT * FROM $table'; 
    $sql .= 'WHERE county = $county';   

    $results = mysql_query($sql) or die("An error ocurred :".mysql_error());  

    while($row = mysql_fetch_array($results))
      {
       echo $row[0];
      }

byte_me

echo not producing a result
checked connect.inc is working
db is selected.

I echoed $county and it has the field Essex in it which is what I expected.

The final objective is to select all rows that have Essex as county and populate drop down box with records from clubName field.

I tried to echo $sql but no a peep.....

leatherback

Hi,

Did you remove the quotes from the colum name? Is the query correct? (echo it..)

byte_me

you mean

echo $sql;

I assume. Yes as is above (after the query and outside of the final }

I am trying to echo the bleeding query to check what it is!!

leatherback

Run this code:

<?php
    $county = "Essex";
    $table = "clubs";  

echo $clubs . $county;
    $sql = "SELECT * FROM $table WHERE county = '$county";    

echo $sql;
    $results = mysql_query($sql) or die("An error ocurred :".mysql_error());   

while($row = mysql_fetch_array($results)) 
  { 
   echo $row[0]; 
  }

byte_me

Cut and pasted into new script, added just the include file

Result:

Connected successfullyEssexSELECT * FROM clubs WHERE county = 'EssexAn error ocurred :You have an error in your SQL syntax near ''Essex' at line 1

I obviously connected via the connect.inc to the db (hence the Connected successfully)

leatherback

Oh,

typo in my script, of course the '$county' is between quotes.

byte_me

Ah spotted syntax error on cut & paste, missing ' .

now get
Connected successfullyEssexSELECT * FROM clubs WHERE county = 'Essex'1234

Is $results 1234? this is the number of rows that "fit" query?

leatherback

Well, probably the rows which have county = Essex vave 1,2,3,4 in the first col.
The $row[] will change for every row from the database. It holds an associative array, which you can acces with numbers-> 0.. numberof of cols-1, or the names of your table colums (Such as county)