Alright fellas, still on my wishlist!

influx

Alright, this is pitiful.

People can come to my site, sign up, and their information is stored in a USERS table. They have a unique (auto-increment, primary key) id, username, first name, last name, etc. Now, I have a wishlist for them to fill out when logged in, which uses the table WISHES.

Now, when I want to store their information in the WISHES table, I want their id (a primary, auto-incrementing key from the USERS table to be placed in the WISHES table as well, under w_id). Please take a look at this code for a sec, and i'll ask my question below it.

<?php $idiot = $db_object->query("SELECT id FROM users WHERE username = ".$db_object->quote($_SESSION['username'])); 
$idiot = $idiot->fetchRow(); 

// now we can add them to the database.

$query = "INSERT INTO wishes(
            w_id,
            w_username,
            w_wish1,
            w_wish2,
            w_wish3,
            w_wish4,
            w_wish5,
            w_wish6) 
            VALUES (
            "$idiot['id']",
            '".$_SESSION['username']."',
            '".$_POST['w1']."',
            '".$_POST['w2']."',
            '".$_POST['w3']."',
            '".$_POST['w4']."',
            '".$_POST['w5']."',
            '".$_POST['w6']."')";

mysql_query($query) or die(mysql_error());
?>

Alright, I get a parse error on line 230:

"$idiot['id']",

when I try inputting their unique ID (a primary key) to the wishes table under the row called w_id.

What is wrong with the code? Sorry guys, I'm kind of new to PHP, but I would love your help.

Grisu

you have forgotten the .

it has to be:

".$idiot['id'].",

Grisu

influx

thanks a lot! It works now!

However, I have two more questions:

1) Instead of using the INSERT function, I'd rather use the UPDATE function. What would I have to change in the code to make it UPDATE instead of INSERT?

2) The wishlist is 6 textfields long, and I want the textfields to have an initial value of the wish already. If they have already put in a wish in wishlist textfield #1, I want it to initially be there for them to modify. So, let's say they have a clear wishlist the first time they visit the site. In wishlist textfield 2, they put "MP3 Player," I want it so that the next time they go to the wishlist.php page, it shows "MP3 Player" in textfield 2.

Would I do it by typing something like:

 <input name="w2" type="text" value="<?php '$w_wish2'?>">

THANKS A LOT!

Grisu

1)
if you want to update, the query changes to
"UPDATE table SET field='value', field2='value2'"

2)
close to it.
before writing the form, you should search for the wish-list of the user, let's say the db-row is stored in an db-array (mysql_fetch_array) $arr, then the tag is:
<input name="w2" type="text" value="<?php echo $arr["w_wish2"] ?>">

Grisu

influx

WOW, thanks so much grisu...However, I still have one problem.

I get no parse errors, and it says I successfully added the wishlist to the database, but when I check the database WISHES table, it's empty. Is this because I replaced the INSERT statement with an UPDATE statement?

Do I need to first do an INSERT statement, and use UPDATE thereon after?

influx

bump! please help!

Weedpacket

Well, you can't UPDATE a record that isn't there. So ... look to see if a suitable record exists. If one does, update it; if not, insert a new one.

influx

So, would I use an if statement? like...if something is in the table, UPDATE, if not, INSERT?

influx

Alright, well here is the code for the wishlist again. Basically, the first time going through the code, if the wishes table is empty, it should INSERT the wishes, but the second time, it should UPDATE them. However, this is not the case. It will add two rows into the WISHES table, with 6 different wishes each, but the same ID (w_id) and same USERNAME (w_username). Here is the code, can anybody tell me if I did something wrong? Any help would be much appreciated!

	if (w_id == 0) {

$query = 'INSERT INTO wishes(
            w_id,
            w_username,
            w_wish1,
            w_wish2,
            w_wish3,
            w_wish4,
            w_wish5,
            w_wish6) 
            VALUES (
            '.$idiot['id'].',
            "'.$_SESSION['username'].'", 
            "'.$_POST['c1'].'", 
            "'.$_POST['c2'].'", 
            "'.$_POST['c3'].'", 
            "'.$_POST['c4'].'", 
            "'.$_POST['c5'].'",
            "'.$_POST['c6'].'")';

mysql_query($query) or die(mysql_error());

} else {

$query = 'UPDATE wishes
SET w_id = '.$idiot['id'].',
w_username = "'.$_SESSION['username'].'",
w_wish1 = "'.$_POST['w1'].'",
w_wish2 = "'.$_POST['w2'].'",
w_wish3 = "'.$_POST['w3'].'",
w_wish4 = "'.$_POST['w4'].'",
w_wish5 = "'.$_POST['w5'].'",
w_wish6 = "'.$_POST['w6'].'"
WHERE
w_id = '.$idiot['id'].'';


mysql_query($query) or die(mysql_error()); }

BASICALLY, the default value for "c_id" is 0, so my if statement says if c_id = 0, then nothing has been input, so INSERT it. However, if it isn't zero, then UPDATE it. What could be wrong?

influx

BASICALLY, the default value for "c_id" is 0, so my if statement says if c_id = 0, then nothing has been input, so INSERT it. However, if it isn't zero, then UPDATE it. What could be wrong?

argh, sorry, I meant w_id=0, not c_id=0

Weedpacket

What could be done is do the UPDATE as you would like; but if mysql_affected_rows() returns zero afterwards, do an INSERT.

yousaf931

In the above Reply of

Weedpacket

" Well, you can't UPDATE a record that isn't there. So ... look to see if a suitable record exists. If one does, update it; if not, insert a new one. "

Than why are you using Conditions.

Cheers,
yousaf FAYYAZ.

Grisu

There is no w_id.

First the var would be $w_id (maybe that's already the mistake) and second I did not find a line in your script giving a value to $w_id.

You usually set a session-var with a user-id when the user logs in (for security reasons have a look at the session-description in the PHP-manual). With this user-id you check, if there is a row in your wish-list (SELECT w_id from wishes WHERE w_id = " . $_SESSION["userid"])
If ($tmp = mysql_fetch_row()) {
$sql = "UPDATE ..."
} else {
$sql = "INSERT..."
}

HTH
Grisu

influx

hrm, it still adds more than one row with the same id number and username when I did what you said Grisu; I am totally boggled. I really appreciate all your help...but can you tell me whats wrong, I will now all the code you need to see:

<?php
require('database.php');	// database connect script.

if ($login == 0) {
	die('Sorry you are not logged in, this area is restricted to registered members. You may choose to <a href="login.php">log in</a>!');
}

if (isset($_POST['submit'])) { // if form has been submitted

echo $_SESSION['username'];?></span>, your classes have been updated!

<?php $idiot = $db_object->query("SELECT id FROM users WHERE username = ".$db_object->quote($_SESSION['username'])); 
$idiot = $idiot->fetchRow(); 

// now add them to the database.

If ($tmp = mysql_fetch_row()) { 
$query = 'UPDATE wishes
SET w_id = '.$idiot['id'].',
w_username = "'.$_SESSION['username'].'",
w_wish1 = "'.$_POST['w1'].'",
w_wish2 = "'.$_POST['w2'].'",
w_wish3 = "'.$_POST['w3'].'",
w_wish4 = "'.$_POST['w4'].'",
w_wish5 = "'.$_POST['w5'].'",
w_wish6 = "'.$_POST['w6'].'"
WHERE
w_id = '.$idiot['id'].'';
mysql_query($query) or die(mysql_error()); }

else { 
$query = 'INSERT INTO wishes(
            w_id,
            w_username,
            w_wish1,
            w_wish2,
            w_wish3,
            w_wish4,
            w_wish5,
            w_wish6) 
            VALUES (
            '.$idiot['id'].',
            "'.$_SESSION['username'].'", 
            "'.$_POST['w1'].'", 
            "'.$_POST['w2'].'", 
            "'.$_POST['w3'].'", 
            "'.$_POST['w4'].'", 
            "'.$_POST['w5'].'",
            "'.$_POST['w6'].'")';

mysql_query($query) or die(mysql_error());
}}?>

THANKS SO MUCH.

Grisu

$idiot = $idiot->fetchRow();
// now add them to the database. 
If ($tmp = mysql_fetch_row()) {

I should have been more precise:

$idiot = $idiot->fetchRow();  

// now add them to the database. 

// check if wish exists
$sql = "SELECT w_id from wishes WHERE w_id = " . $idiot["id"];
$result = mysql_query($sql);
If ($tmp = mysql_fetch_row($result)) { 
  // wish exists, update it
  $sql = "UPDATE ..." 
} else { 
  // wish does not exist, add new wish
  $sql = "INSERT..." 
}

does it work?

Grisu

influx

IT WORKED!

thanks so much Grisu, I really do appreciate it.

Now, I have one more problem, I PROMISE!

The problem is this, it's simple:

For the wishlist textfields, if there is a value for, let's say, wish #1, called "MP3 PLAYER," I want it to show MP3 Player in the first textfield (as its initial value) for wish #1, if it exists.

I tried doing it with this command, and the initial value of the textfield is still blank:

<input name="w1" type="text" size="60" maxlength="70" value="<?php echo (isset($w_wish1) ? $w_wish1 : ''); ?>">

Grisu

why so complicate?

<input name="w1" type="text" size="60" maxlength="70" value="<?php echo $w_wish1; ?>">

(please note that this is a HTML-code with an embedded PHP and not PHP-code)

Grisu

Weedpacket

Originally posted by Grisu
why so complicate?
<input name="w1" type="text" size="60" maxlength="70" value="<?php echo $w_wish1; ?>"> 
[/B]

Because if you're coding with error reporting set to E_ALL (which, for the sake of defensive programming is a good idea), this will whinge about $w_wish1 not being set if, in fact, it is not set.

It's not necessary if you've already ensured $w_wish1 has a value by that point.

influx

hmm...
well it still doesnt show up in the textfields after what Grisu said...

but let me tell you the layout of the php page.

it goes something like this:

if (isset($_POST['submit'])) {         // if form has been submitted
INSERT or UPDATE tables }

else {
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<input name="c1" type="text" size="60" maxlength="70" value="<?php echo $c_class1; ?>">

is this statement responsible for screwing it up?:

 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">

Grisu

of course Weedpacket is right. I sometimes do not care so much about that things - sorry.

Some other comments.

First if you think that a certain variable does not have the correct value, just have a look into the source-text in your browser. Or if it is not echoed, just include an echo-command for that. This solves a lot of my problems when I do not know where something is missing, but I think the PHP_SELF thing is o.k.

I guess, that you have the whole thing in one php-file (output the form and edit the database). I also guess, that the <input>-tag is outside of the php-code. Then I still miss, the line where you give a value to $w_wish. We check, if there is some data for the user in your wishes table, but we do not store the values in $w_wish.

Do I miss a line?

Grisu