Tidying up some code.... making it more efficient!

[Spud_Nic]

Hi

I have some php, which uses many many many if statements - which is ok, and works, but I can't help thinking there'd be a better way to write it out, that wasn't as long!!!

I was thinking a Switch statement might work, but not sure how that'd be written in this instance!

The ugly code I have at the moment is:

if ($action == "clearmain") {
$contentdis = "acp";
unlink($mainindexlog);
}
if ($action == "cleargb") {
$contentdis = "acp";
unlink($guestbooklog);
}
if ($action == "clearsb") {
$contentdis = "acp";
unlink($shoutboxlog);
}
if ($action == "clearguv") {
$contentdis = "acp";
unlink($geturlvisitorslog);
}
if ($action == "cleargus") {
$contentdis = "acp";
unlink($geturlsearcheslog);
}
if ($action == "clearwl") {
$contentdis = "acp";
unlink($workloglog);
}
if ($action == "clearqu") {
$contentdis = "acp";
unlink($qulog);
}
if ($action == "clearmini") {
$contentdis = "acp";
unlink($minilog);
}
if ($action == "clearklm") {
$contentdis = "acp";
unlink($klmlog);
}
if ($action == "clearcontact") {
$contentdis = "acp";
unlink($contactlog);
}
if ($action == "clearmbcdrom") {
$contentdis = "acp";
unlink($mbcdromlog);
}
if ($action == "clearmontages") {
$contentdis = "acp";
unlink($montageslog);
}
if ($action == "clearrps") {
$contentdis = "acp";
unlink($rpslog);
}

its so similar - just with different variables there must be a way?
and ideas?

thanks

[njm]

For a start, you can take out the line:

$contentdis = "acp";

from each block. It doesn't change, so isn't dependent on $action.
You could use a switch statement, the syntax is described here
Alternatively, you could build an array of the $action/filename pairs:

$arr = array(
			'clearmain' => $mainindexlog,
			'cleargb' => $guestbooklog,
			// ...
			'clearsb' => $shoutboxlog
			);

unlink($arr[$action]);

I think should work,

hth, njm

[LordShryku]

Arrays would be your good buddy. Here's an idea....

$actions = array("clearmain","cleargb","clearsb","clearguv",
                 "cleargus","clearwl","clearqu","clearmini",
                 "clearklm","clearcontact","clearmbcdrom",
                 "clearmontages","clearrps");

$clears = array("mainindexlog","guestbooklog","shoutboxlog","geturlvisitorslog",
                "geturlsearcheslog","workloglog","qulog","minilog","klmlog",
                "contactlog","mbcdromlog","montageslog","rpslog");

if(isset($action)) {
   if(in_array($action, $actions)) {
      $contentdis = "acp";
      $key = array_search($action, $actions);
      unlink(${$clears[$key]});
   }
}

Everything put in arrays....
Check out the functions and concepts:
variable variables
[man]in_array[/man]
[man]array_search[/man]

[Spud_Nic]

thanks very helpful!!!

i'll try using arrays... something I didn't think of (not yet experienced enough in php!)

thanks for the help!