Problem with file uploader

asultan

I'm trying to make a script that will upload a couple of file depending of the files selected. to run the script I need to pass the name of a company and a product number

I would call the script like this:

example: http://www.mydomain.com/myscript.php?company=mycompany&products=1

this will prompt me to enter a file and upon submition it should upload it to the right folder on the server but I'm having problems where it won't upload the file.

the form will post to it self passing the company, the product and a bool to upload the file.

here is the code:

<?php
									/*
										This is the list of products. To determine wichones to show we do a binary math
										that calculates wich files to show.
										$PM -> 1	$HD -> 2	$AM -> 4	$IT -> 8
										$SM -> 16	$HR -> 32	$PP -> 64	$RM -> 128
									*/

									$PM=1;$HD=2;$AM=4;$IT=8;
									$SM=16;$HR=32;$PP=64;$RM=128;

								/************************ Create directory structure ************************/

									$permiss = 0775;
									$basedir = "../_downloads/~~";
									$dirowner = "eden_clients";

									/*** Variables for file uploading ***/
									$extlimit = "yes"; 
									$limitedext = array(".zip"); 
									$sizelimit = "no"; 
									$sizebytes = "200000";
									$dl = "http://www.eden.com/demos_evals/_clients/_downloads/~~"; 
									$absolute_path = "/home/www/Eden_Main/demos_evals/_clients/_downloads/~~"; 
									$websiteurl = "http://www.eden.com"; 
									$websitename = "Eden Corporation";

									/*** Create directory for the user ***/
									if ($company && $create==true)
									{
										print "<br><b>- Creating client directory ".$basedir.$company."</b><br>";
										generatedir($basedir.$company, $permiss);
									}

									/*** Create directory for the products ***/
									if(($products > 0 && $products < 256) && $company && $create==true)
									{
										if(is_dir($basedir.$company))
										{
											if($products & $PM){
												print "<br><b>- Creating directory for the PM</b><br>";
												generatedir($basedir.$company."/PM", $permiss);
												uploadfile($PMfile,$absolute_path.$company."/PM");							
												//@copy($PMfile, "$absolute_path$company/$PMfile") or die("unable to copy $PMfile");					
											}	
											if($products & $HD){
												print "<br><b>- Creating directory for the HD</b><br>";
												generatedir($basedir.$company."/HD", $permiss);
												uploadfile($HDfile,$absolute_path.$company."/HD");
											}
											if($products & $AM){
												print "<br><b>- Creating directory for the AM</b><br>";
												generatedir($basedir.$company."/AM", $permiss);
												uploadfile($AMfile,$absolute_path.$company."/AM");
											}
											if($products & $IT){
												print "<br><b>- Creating directory for the IT</b><br>";
												generatedir($basedir.$company."/IT", $permiss);
												uploadfile($ITfile,$absolute_path.$company."/IT");
											}
											if($products & $SM){
												print "<br><b>- Creating directory for the SM</b><br>";
												generatedir($basedir.$company."/SM", $permiss);
												uploadfile($SMfile,$absolute_path.$company."/SM");
											}
											if($products & $HR){
												print "<br><b>- Creating directory for the HR</b><br>";
												generatedir($basedir.$company."/HR", $permiss);
												uploadfile($HRfile,$absolute_path.$company."/HR");
											}
											if($products & $PP){
												print "<br><b>- Creating directory for the PP</b><br>";
												generatedir($basedir.$company."/PP", $permiss);
												uploadfile($PPfile,$absolute_path.$company."/PP");
											}
											if($products & $RM){
												print "<br><b>- Creating directory for the RM</b><br>";
												generatedir($basedir.$company."/RM", $permiss);
												uploadfile($RMfile,$absolute_path.$company."/RM");
											}
										}
										else
										{
											print "<br><b>- Creating Product Directories</b><br>";
											failure("Failed");
											print " Directory ".$basedir.$company." doesn't exist<br>";
										}
									}

									function success($word)
									{
										print "<font color=179D4C><b>$word</b></font>";
									}
									function failure($word)
									{
										print "<font color=D72323><b>$word</b></font>";
									}
									function generatedir($path, $mode)
									{
										if(is_dir($path))
										{	failure("Failed");
											print " Directory ".$path." allready exist<br>";
											return false;
										}
										else
										{	mkdir($path,$mode);
											if(is_dir($path))
											{	success("Successful");
												print " Directory created<br>";													
												return true;
											}
											else
											{	failure("Failed");
												print " Unable to create directory ".$path."<br>";
												return false;
											}
										}
									}
									function uploadfile($file, $path)
									{
										if ($file != "") 
										{											
											if (file_exists("$path/$file")) 
											{
												failure("Failed");
												print " File allready exists.<br>";
												return;
											}

											if (($sizelimit == "yes") && ($file_size > $sizebytes)) 
											{
												failure("Failed");
												print " File size exeeded.<br>";
												return;
											}

											$ext = strrchr($file,'.');
											if (($extlimit == "yes") && (!in_array($ext,$limitedext))) 
											{
												failure("Failed");
												print " Unsupported file extension.<br>";
												return;
											}

											if (!@copy($file, "$path/$file"))
											{
												failure("Failed");
												print " Unable to copy the file $file to $path/$file <br>";
												return;
											}
											else
											{
												success("Successful");
												print " File uploaded successfully<br>";													
												return;
											}
										} 
										else 
										{
											failure("Failed");
											print " No file selected.<br>";
											return;
										}											
									}
									function generatelink($url)
									{
										$defurl = ereg_replace ("http://" , "ftp://", $url);
										$defurl = ereg_replace (" " , "+", $defurl);	
										print "<a href=$defurl target=_new>$defurl</a><br>";
									}

									function display_header($products, $company)
									{
										echo "<form method=POST action=$PHP_SELF?products=$products&company=$company&create=true enctype=multipart/form-data>
										<br>Select the files to be uploaded and click the UPLOAD button.<br><br>";
									}
									function display_footer()
									{
										echo "<button name=submit type=submit>UPLOAD</button>
											  </form>";
									}
									function display_product($curprod,$curprodfilename)
									{
										echo "<p>
											  Select the $curprod file to upload: <br>
											  <input type=file name=$curprodfilename size=30>
											  </p>";
									}

									if(($products > 0 && $products < 256) && $company && $create==false)
									{
										display_header($products, $company);
										if($products & $PM)
											display_product("Project Manager","PMfile");
										if($products & $HD)
											display_product("Help Desk","HDfile");
										if($products & $AM)
											display_product("Asset Manager","AMfile");
										if($products & $IT)
											display_product("Issue Tracker","ITfile");
										if($products & $SM)
											display_product("Sales Manager","SMfile");
										if($products & $HR)
											display_product("HR Manager","HRfile");
										if($products & $PP)
											display_product("IT Power Pac","PPfile");
										if($products & $RM)
											display_product("Requirements Manager","RMfile");
										display_footer();
									}
								?>

I would really appreciate if anyone could help. please respond to my email

renaun

What errors are you getting?

Does you web server have permission to write files into the directory your are trying upload the files to?

asultan

Yes I know that the webserver allows me to copy files to that directory because I tested a similar script and it worked.

I'm not getting any errors with the script, but it just doesn't copy the file to the server.

it returns the error:
Unable to copy the file $file to $path/$file wich is the result of trying to copy the file to the server.

this is the original script that I'm trying to modify:

<?
$extlimit = "yes"; //Do you want to limit the extensions of files uploaded
$limitedext = array(".gif",".jpg",".png",".jpeg", ".zip"); //Extensions you want files uploaded limited to.
$sizelimit = "no"; //Do you want a size limit, yes or no?
$sizebytes = "200000"; //size limit in bytes
$dl = "http://www.eden.com/demos_evals/_clients/_downloads/"; //url where files are uploaded
$absolute_path = "/home/www/Eden_Main/demos_evals/_clients/_downloads/"; //Absolute path to where files are uploaded
$websiteurl = "http://www.eden.com"; //Url to you website
$websitename = "Eden Corporation";

switch($action) {
default:
echo"
<html>
<head>
<title>Upload Or Download</title>
</head>
<body>
<a href=$PHP_SELF?action=upload>Upload File</a>
 <a href=$PHP_SELF?action=download>Download File</a>
 <a href=$websiteurl>Return to $websitename</a>
<br><br>
Powered by <a href=http://www.zachwhite.com/>PHP Uploader Downloader</a>
</body>
</html>";
break;
case "download":
echo "
<html>
<head>
<title>File Download</title>
</head>
<body><a href=$PHP_SELF?action=upload>Upload File</a> <a href=$websiteurl>Return to $websitename</a>";
$list = "<table width=700 border=1 bordercolor=#000000 style=\"border-collapse: collapse\">";
$list .= "<tr><td width=700><center><b>Click To Download</b></center></td></tr>";
$dir = opendir($absolute_path);
while($file = readdir($dir)) {
if (($file != "..") and ($file != ".")) {
//Download files with spaces fix by Kokesh
$list .= "<tr><td width=700><a href='$dl/$file'>$file</a></center></td></tr>";
}
}
$list .= "</table>";
echo $list;
echo"
<br><br>
Powered by <a href=http://www.zachwhite.com/>PHP Uploader Downloader</a>
</body>
</html>";
break;

case "upload":
echo"
<html>

<head>
<title>File Upload</title>
</head>

<body>

<form method=POST action=$PHP_SELF?action=doupload enctype=multipart/form-data>
<p>File to upload:<br>
<input type=file name=file size=30>
<p><button name=submit type=submit>
Upload
</button>
</form>
<br><br>
Powered by <a href=http://www.zachwhite.com/>PHP Uploader Downloader</a>
</body>

</html>";
break;


//File Upload
case "doupload":
$dir = "dir";
if ($file != "") {

if (file_exists("$absolute_path/$file_name")) {
die("File already exists");
}

if (($sizelimit == "yes") && ($file_size > $sizebytes)) {
die("File is to big. It must be $sizebytes bytes or less.");
}

$ext = strrchr($file_name,'.');
if (($extlimit == "yes") && (!in_array($ext,$limitedext))) {
die("The file you are uploading doesn't have the correct extension.");
}

@copy($file, "$absolute_path/$file_name") or die("The file you are trying to upload couldn't be copied to the server");

} else {
die("Must select file to upload");
}
echo "
<html>
<head>
<title>File Uploaded</title>
</head>
<body>";
echo $file_name." was uploaded";
echo "<br>
<a href=$PHP_SELF?action=upload>Upload Another File</a>
<a href=$PHP_SELF?action=download> Download File</a>
<a href=$websiteurl> Return to $websitename</a><br><br>
Powered by <a href=http://www.zachwhite.com/>PHP Uploader Downloader</a>
</body>
</html>";
break;

}
?>

renaun

<head>
<title>File Upload</title>
</head>

<body>

<form method=\"POST\" action=\"$PHP_SELF\" enctype=\"multipart/form-data\">
<p>File to upload:<br>
    <input type=\"file\" name=\"file\">
    <input type=\"hidden\" name=\"action\" value=\"doupload\">
    <p><button name=submit type=submit>
	Upload</button>
</form>
<br><br>Powered by 
<a href=http://www.zachwhite.com/>PHP Uploader Downloader</a>
</body>
</html>";
break;


//File Upload
case "doupload":
$dir = "dir";

$file = $_FILES['file'];

$absolute_path = "C:\inetpub\wwwroot";
//$file = $_POST['file'];
if ($file != "") {

if (file_exists($absolute_path."/".$file['name'])) {
      die("File already exists");	}

if (($sizelimit == "yes") && ($file['size'] > $sizebytes)) { 
      die("File is to big. It must be $sizebytes bytes or less."); }

$ext = strrchr($file['name'],'.');
if (($extlimit == "yes") && (!in_array($ext,$limitedext))) {
die("The file you are uploading doesn't have the correct extension.");
}

 move_uploaded_file($file['tmp_name'], $absolute_path."/".$file['name']) 
   or die("The file you are trying to upload couldn't be copied to the server");

} else {
	die("Must select file to upload");
}

There is the code that I changed. Most of big changes were because I don't have register_globals on.

The main change of code was, chaning the line that said:

@copy($file, "$absolute_path/$file_name") 
     or die("The file you are trying to upload couldn't be copied to the server");

to the function move_uploaded_file

move_uploaded_file($file['tmp_name'], $absolute_path."/".$file['name']) 
    or die("The file you are trying to upload couldn't be copied to the server");

PHP docs for move_uploaded_file - http://us4.php.net/manual/en/function.move-uploaded-file.php

asultan

Thanks you for your post, I tryed your sugestions but I'm still getting an error.

For some reason the file name is getting screwed when I post the form this is the errors I get after I run my script:

This is the file: /tmp/phpL3yKgR
This is the path: /home/www/Eden_Main/demos_evals/clients/downloads/~~Abe/HD

Warning: move_uploaded_file(/home/www/Eden_Main/demos_evals/clients/downloads/~~Abe/HD//tmp/phpL3yKgR): failed to open stream: No such file or directory in /home/www/Eden_Main/demos_evals/clients/admin/createuser.php on line 214

Warning: move_uploaded_file(): Unable to move '/tmp/phpL3yKgR' to '/home/www/Eden_Main/demos_evals/clients/downloads/~~Abe/HD//tmp/phpL3yKgR' in /home/www/Eden_Main/demos_evals/clients/admin/createuser.php on line 214

but that wasn't the file name, the absolute path of the file name in my computer was:

C:\Documents and Settings\asultan\My Documents\Resume angie.zip

Any Ideas why this could be happening?😕

renaun

Warning: move_uploaded_file(/home/www/Eden_Main/demos_evals/clients/downloads/~~Abe/HD//tmp/phpL3yKgR): failed to open stream: No such file or directory in /home/www/Eden_Main/demos_evals/clients/admin/createuser.php on line 214

First of all, "(/home/www/Eden_Main/demos_evals/clients/downloads/~~Abe/HD//tmp/phpL3yKgR" doesn't look like a valid path because of the '//' between HD and tmp.

Second lets talk about move_uploaded_file and its parameters. To explain the parameters I need to explain how the file uploading works. When you have a file uploading to the server it is stored into a temporary file, hence why you see (/tmp/phpL3yKgR). This temporary file is the actually stream you will process. You do get other information along with the file, like name, type, size, tmp_name (which is phpL3yKgR in your example above), and error. http://us2.php.net/features.file-upload

So with this information we will be using the 'tmp_name' to get the file stream and will be using 'name' for renaming the tmp file once we move it. How move_uploaded_file works, is there are two parameters 'string filename' and 'string destination'. The first one is the the filename to the temp file. The second is the destination of the file. So your move_uploaded_file call should be something like this, based on what you have provided in your last post.

move_uploaded_file( $file_tmp_name , $absolute_path . $file_name);

I personally was using the Constant $FILE (>PHP4.0.3) which looks like this when the <input> tage name is 'file':

move_uploaded_file( $_FILES['file']['tmp_name'] , $absolute_path . $_FILE['file']['name']);

Where $absolute_path is your predefined path where you want your files moved.

asultan

wooooooooooooohoooooooooooooo

you are the man,

thanks allot

that helped.😃