Error in code. Can anyone spot it?

loureiro

alright im getting an error in my code. here it is:

$sqlUpdate = "UPDATE Company SET company = '".$_POST["company"]."',
				  address1 = '".$_POST["address1"]."',
				  address2 = '".$_POST["address2"]."',
				  city = '".$_POST["city"]."',
				  province = '".$_POST["province"]."',
				  country = '".$_POST["country"]."',
				  postal = '".$_POST["postal"]."',
				  telephone = '".$_POST["telephone"]."',
				  toll = '".$_POST["toll"]."',
				  fax = '".$_POST["fax"]."',
				  website1 = '".$_POST["website1"]."',
				  website2 = '".$_POST["website2"]."',
				  link1 = '".$_POST["link1"]."',
				  link2 = '".$_POST["link2"]."',
				  users = '".$_POST["users"]."',
				  logo1 = NULL,
				  logo2 = NULL,
				  image1 = NULL,
				  image2 = NULL,
				  details = '".$_POST["details"]."',
				  enabledFields = NULL,
				  payment = '".$_POST["payment"]."' WHERE companyID = \"".$_SESSION["companyID"]."\"";

//this is where im getting my error!!!
echo "Your account has been updated successfully. In order to continue to use the client login you must relogin. 
You can do so at <a href=\"http://www.londondigitalone.com/login\?username=".$_SESSION["username"]."&password=".$_SESSION["password"]\" target=\"\_blank\">
[url]http://www.londondigitalone.com/login\?username=[/url]".$_SESSION["username"]."\&password=".$_SESSION["password"]."</a>";

DISPLAY:
Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /home/ziggy/public_html/login/account.php on line 89

Parse error: parse error, expecting ','' or';'' in /home/ziggy/public_html/login/account.php on line 89

AstroTeg

You're missing a period to concatenate the variable to the string in your echo statement:

.$_SESSION["password"]"

it should be:
.$_SESSION["password"] . "

Also notice how the last line changed colors in the forum? This is a great indication there might be a problem (although it doesn't exactly help pinpoint it, but it helps).

loureiro

hey i actually just added extract ($_POST). im gonna try it like this!

AstroTeg

Also note you're not escaping all your double quotes in your echo statement.

A little trick I like to do when working with double quotes:

echo '<a href="mylink">link</a>';

By using single quotes on the outside, I can insert double quotes without having to escape them. I'm being lazy. Although this won't work well if you're trying to do the double-quote-with-PHP-variables trick where you insert PHP variables into your double quoted string.

loureiro

thanks a lot!

swr

Originally posted by loureiro
hey i actually just added extract ($_POST). im gonna try it like this!

Be aware that extract($_POST) has the same security implications as enabling register_globals. More info here:

http://www.php.net/register_globals

Weedpacket

Originally posted by AstroTeg
Also notice how the last line changed colors in the forum? This is a great indication there might be a problem (although it doesn't exactly help pinpoint it, but it helps).

Be aware though that a bug in vBulletin sees it trying to wrap links around URLS that appear inside [php] blocks. A dumb mistake, I know, but I didn't write it 🙂. It can be avoided by unchecking the "Automatically parse URLs" option when you post.

AstroTeg

Ahh... you're right. Nothing like solving one bug based on another bug.

Ok - ignore my comment about the syntax highlighting. That was a freak of nature.