[Resolved] Help needed

[erikhillis]

Here is my code... and my problem is when I call up the page with the code in, and the $num equils 1 or more, the info wont show up, but the "No Statistics available..." will show if the num=0. Whats wrong with my code?

<?php
// Connect to the database
$db = mysql_connect("localhost","xxx","xxx");
mysql_select_db (xxx);
$sql = "SELECT * FROM roster WHERE year='{$_REQUEST['year']}' and team='{$_REQUEST['team']}' order by stats_avg asc";
if (!$result = mysql_query($sql)) {
    print "Invalid query ($sql) : " . mysql_error();
    exit;
}
$num = mysql_num_rows($result);

while ($row = mysql_fetch_assoc($result)) {
}

if ($num == "0") {
echo "<font color=#000000 face=Arial size=2>No statistics available, or no players in database";
} else {
echo "<table width=100% cellpadding=0 cellspacing=0>
<tr>
<td width=15%><font color=#000000 face=Arial size=1>$rows[3]{$row['name']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_avg']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ab']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_runs']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hits']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_2b']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_3b']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hr']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_rbi']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_tb']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_slg']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hbp']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ob']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sac']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sb']}</B></td>
</tr>
</table>";
}

?>

[leatherback]

Hi,

What is causing your problem is the closing tag } after the while statement. You have to move this to afte your echo statement.

Also, can I suggest using sttyles to format your table, and add a class='' tags. this way your site is much more flexible. All you need to do is change one single number in your layoutfiles, and the whole appearence of the site changes.

Have a read about CSS at the w3c website

Oh, and yeah.. Everybody needs help, so please.. Next post use a more informative subject. (Read the posting guidlines as explained in the newbies section)

[rgermain]

Not that anyone probably cares, but I totally agree on looking into using css. Much easier to manage. Better to have to only change one thing. Instead of a bunch! It will also shorten your code!

[erikhillis]

Still dosnt work, though I have changed the code around.

<?php
// Connect to the database
$db = mysql_connect("localhost","xxx","xxx");
mysql_select_db (xxx);
$sql = "SELECT * FROM roster WHERE year='{$_REQUEST['year']}' and team='{$_REQUEST['team']}' order by stats_avg asc";
$num = mysql_num_rows($result);
if (!$result = mysql_query($sql)) {
    print "Invalid query ($sql) : " . mysql_error();
    exit;
}

if ($num == "0") {
echo "<font color=#000000 face=Arial size=2>No statistics available, or no players in database";
} 

else 

{
echo "<table width=100% cellpadding=0 cellspacing=0><tr>
<td width=15%><font color=#000000 face=Arial size=1>$rows[3]{$row['name']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_avg']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ab']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_runs']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hits']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_2b']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_3b']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hr']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_rbi']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_tb']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_slg']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hbp']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ob']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sac']}</B></td>
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sb']}</B></td>
</tr>
</table>";
}

?>

[erikhillis]

Anyone?...:rolleyes:

[LordShryku]

PHP is procedural. This you can't call num_rows before the query, so this won't work:

$num = mysql_num_rows($result);
if (!$result = mysql_query($sql)) {
    print "Invalid query ($sql) : " . mysql_error();
    exit;
} 

[erikhillis]

Is there another way to do what I'm trying to do then?

[erikhillis]

...

[viper78]

try this and tell me if it works

<?php 
// Connect to the database 
$db = mysql_connect("localhost","xxx","xxx"); 
mysql_select_db (xxx); 
$sql = "SELECT * FROM roster WHERE year='{$_REQUEST['year']}' and team='{$_REQUEST['team']}' order by stats_avg asc"; 

if (!$result = mysql_query($sql)) { 
    print "Invalid query ($sql) : " . mysql_error(); 
    exit; 
} 

$num = mysql_num_rows($result); 

if ($num < 1) { 
echo "<font color=#000000 face=Arial size=2>No statistics available, or no players in database"; 
}  

else  

{ 
echo "<table width=100% cellpadding=0 cellspacing=0><tr> 
<td width=15%><font color=#000000 face=Arial size=1>$rows[3]{$row['name']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_avg']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ab']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_runs']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hits']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_2b']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_3b']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hr']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_rbi']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_tb']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_slg']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hbp']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ob']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sac']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sb']}</B></td> 
</tr> 
</table>"; 
} 

?>

i moved your num function after the query and changed the $num == 0 to $num < 1 that checks the database if thers anything in there so if theres less than 1 rows in the database it returns the error.

[TTT]

if (mysql_num_rows($result) != 0) {

//
} else {
echo "<font color=#000000 face=Arial size=2>No statistics available, or no players in database";

}

Other thing... is year and team varchar?
and does this print anything
echo $REQUEST['year']." ".$REQUEST['team'];

[erikhillis]

Viper. I tried that code, same result. Here is an example.

This page has players that need to be viewed. But are not displayed
http://www.canadianthunderbirds.com/stats.php?year=2004&team=Intermediate

And there are no players to view here
http://www.canadianthunderbirds.com/stats.php?year=2004&team=Juniors

[viper78]

I just reread your code and noticed it's missing the while loop and the mysql_fetch_array to grab the info try this.

<?php  

// Connect to the database 
$db = mysql_connect("localhost","xxx","xxx");  

mysql_select_db (xxx);  

$sql = "SELECT * FROM roster WHERE year='{$_REQUEST['year']}' and team='{$_REQUEST['team']}' order by stats_avg asc";  

if (!$result = mysql_query($sql)) {  

    print "Invalid query ($sql) : " . mysql_error();  

    exit;  

}  

$num = mysql_num_rows($result);  

if ($num < 1) {  

echo "<font color=#000000 face=Arial size=2>No statistics available, or no players in database";  

}   

else   

{  

while($row = mysql_fetch_array($result)) {
echo "<table width=100% cellpadding=0 cellspacing=0><tr> 
<td width=15%><font color=#000000 face=Arial size=1>$rows[3]{$row['name']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_avg']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ab']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_runs']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hits']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_2b']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_3b']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hr']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_rbi']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_tb']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_slg']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_hbp']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_so']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_ob']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sac']}</B></td> 
<td width=5%><font color=#000000 face=Arial size=1><center>{$row['stats_sb']}</B></td> 
</tr> 
</table>";  

  }
}  

?>

Try that and let me know.

[erikhillis]

Thanks a million, works nicely. 🙂