POST variables to database not working

TheGringo

I have a page that receives variables in the URL, like so:

[url]http://www.***.com/ordering.php?id=sky3&albumName=Smith[/url]

in the receiving page, I retrieve the vars like this:

$image1 = $HTTP_GET_VARS['id'];
$client1 = $HTTP_GET_VARS['albumName'];

Then I'm trying to stuff these into a MySQL db like so:

$query = "INSERT INTO dd_order"
      . "(client, image) VALUES ('$client1', '$image1')";

but it ain't workin'. I can echo $image1 and $client1 to the screen, so the values must be there, but they don't show up in my database fields. My other vars that I define from a form on this page get inserted fine; just not these two getting passed in. Anyone help me out? Thanks!

dalecosp

Tried this?

$query = "INSERT INTO dd_order
   (client, image) VALUES ($client1, $image1)";

Also, might you need to [man]addslashes/man before writing these strings to the DB?

TheGringo

you mean removing the single-quotes? I get an sql error. Also, the addslashes() didn't seem to do anything.

dalecosp

So, at least in this case, addslashes isn't necessary. Good idea to leave it in, though.

What was the sql error?

A good debugging idea would be to echo the entire query to the screen so you could see it w/o putting it in the db just yet.

TheGringo

when I echo the query, I get

= "INSERT INTO dd_order" . "(client, image, quantity, size) VALUES ('', '', '3', '4x6')";

so, it puts in some of my vars, but not the ones I get via $HTTP_GET_VARS

hmph 🙁

dalecosp

Well ... tried $_GET['foo']?

Secondly, maybe post the larger code excerpt?

TheGringo

yep, tried that too... Here is my whole page:

<html>
<head>
<title>ordering</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

</head>

<body bgcolor="#FFFFFF">
<form action="<?php echo $PHP_SELF ?>" method="POST">

<?php

require("dd_upload_inc.php");
require("dd_functions.php");

function check_mysql()
{
if (mysql_errno() > 0)
{
die("<BR> MySQL error " . mysql_errno() . ": " . mysql_error());
}
}

$db = mysql_connect($host, $usr, $pw);
if (!$db)
{
die("Failed to open connection to MySQL server.");
}

mysql_select_db("$dbname");
check_mysql();

//get posted vars... tried a number of variations here...

$image1 = stripslashes($GET['id']);
$client1 = $GET['set_albumName'];
echo $client1; //echo works fine!!! but won't write to database...

if (isset($placeorder))
{
$query = "INSERT INTO dd_order"."(order_date, client, image, quantity, size, priceper, total, duedate) VALUES ('$order_date1', '$client1', '$image1', '$quantity1', '$size1', '$priceper1', '$total1', '$duedate1')";

$result = mysql_query($query);
check_mysql();

}

$order_date1 = trim($order_date1);
$client1 = trim($client1);
$image1 = trim($image1);
$quantity1 = trim($quantity1);
$size1 = trim($size1);
$priceper1 = trim($priceper1);
$total1 = trim($total1);
$duedate1 = trim($duedate1);

<b>Order Prints <br>
<br>
</b>
<table border="0" cellspacing="0" cellpadding="5">
<tr>
<td align="right">Quantity:</td>
<td>
<input type="text" name="quantity1" size="4" maxlength="4" <?php echo "VALUE=\"$quantity1\"" ?>>
</td>
</tr>
<tr>
<td align="right">Size:</td>
<td>
<select name="size1">
<option selected>Choose...</option>
<option value="wallets">Wallets</option>
<option value="4x6">4 x 6</option>
<option value="5x7">5 x 7</option>
<option value="8x10">8 x 10 </option>
<option value="11x14">11 x 14 </option>
<option value="16x20">16 x 20</option>
<option value="20x24">20 x 24</option>
<option value="24x30">24 x 30</option>
<option value="30x40">30 x 40</option>
<option value="30x48">30 x 48</option>
<option value="30x60">30 x 60</option>
<option value="30x72">30 x 72</option>
<option value="30x84">30 x 84</option>
<option value="30x96">30 x 96</option>
</select>
(larger prints by request)</td>
</tr>
<tr>
<td align="right">Turnaround:</td>
<td>
<select name="turnaround1">
<option selected>Choose...</option>
<option value="1">24-Hour </option>
<option value="4">4-Day </option>
<option value="7">7-Day </option>
</select>
</td>
</tr>

</table>
<input type="submit" name="placeorder" value="Place Order">

</form>
</body>
</html>

dalecosp

Have you got a database description? i.e.

mysql>describe tablename;

TheGringo

sorry, I'm not much of a database guy... you mean something like this:

Table structure for table `dd_order`

CREATE TABLE dd_order (
id int(11) NOT NULL auto_increment,
order_date text NOT NULL,
client varchar(200) NOT NULL default '',
image varchar(200) NOT NULL default '',
quantity int(11) NOT NULL default '0',
size varchar(50) NOT NULL default '',
priceper double NOT NULL default '0',
total double NOT NULL default '0',
duedate text NOT NULL,
PRIMARY KEY (id),
FULLTEXT KEY duedate(duedate)
) TYPE=MyISAM COMMENT='version 1.0';

TheGringo

Still don't understand why this isn't working. Anyone? Help!

LeZeNkO

Where the $query is with the assigned arrays try using " instead of '.....not where the arrays are obviously but ("$fo0,"); etc

Im sure I had a problem like that a few weeks ago

TheGringo

thanks for the reply. I tried it, but it gave me an error (using " instead of ').

I don't understand why I can echo it to the screen, but not insert it into the database! I can assign the value to another variable, echo that to the screen, but if I plug it into the query, it still won't insert. wtf?

daveyboy

what do you see if you do

echo $query;

TheGringo

when I echo the query, I get something like

= "INSERT INTO dd_order" . "(client, image, quantity, size) VALUES ('', '', '3', '4x6')";

so, it puts in some of my vars, but not the ones I get via $_GET

dalecosp

Any possibility that these vars in the GET array are being urlencoded automagically --- for example, you have 'magic quotes' enabled?

</grasping at straws>

TheGringo

magic_quotes_gpc is on; magic_quotes_runtime is off. Not sure what that means exactly to me...

TheGringo

This is kind of interesting... when I add the line

$client1 = $client1."test";

after

$client1 = $_GET['set_albumName'];

it inserts the text "test" into the database... so it seems to me like it is tossing the original value somewhere...

TheGringo

D'oh! clicking on the submit button causes the form to perform its "action", which was reloading the page and wiping out the passed vars... I removed the "action="<?php echo $PHP_SELF ?>" part, and now it works fine. Whew!

Thanks for all the help. I feel smart for figuring it out, and stupid for having done it in the first place.