[Resolved] Need Help - Simple Database Insert

szym9341

I need some help! Please...

database: test
table: typetypes
table columns:
1) type_id (primary key, auto-increment)
2) typetype (char)

I just want a simple code to input a word, then refresh the page allowing me to insert another word... I know I am missing some part of this, but don't know enough to be able to figure it out... can someone PLEASE give me some help?

Also, how do I get this code to be all colored?

<html>
<body>
<?php
//***connection to MYSQL*
$dbcnx = @mysql_connect("localhost", "root", "mypassword");
if (!$dbcnx) {
echo( "<p>Unable to connect to the " .
"database server at this time.</p>" );
exit();
}
//connection to the TEST database********
mysql_select_db("test", $dbcnx);
if (! @mysql_select_db("test") ) {
echo( "<p>Unable to locate the test" .
"database at this time.</p>" );
exit();
}
?>

<form action="<?=$PHP_SELF?>" method="post">
<p>Enter Type:<br />
<input type="text" name="typetype"><br />
<input type="submit" name="submittype" value="SUBMIT" />
</p>
</form>

<?php
if ($submittype == "SUBMIT") {
$sql = "INSERT INTO typetypes SET
type_id='1',
typetype='$typetype'";
}
$result = mysql_query($sql);
?>

</body>
</html>

eoghain

Well first off you are relying on php to have register_globals set to on. This isn't a good thing since it opens up the security on your site.

Secondly your query is a little wierd in that you are telling it what ID to use for your auto_increment field, if you only want to ever have the 1 record this is fine, but I doubt that is what you are looking to do. Also you should have your code that runs your query inside the if clause:

<?php 
if (isset($_POST['submittype'] && $_POST['submittype'] == "SUBMIT") {
   $sql = "INSERT INTO typetypes (type_id, typetype) VALUES (NULL, '" . $_POST['typetype'] . "')"; 
   $result = mysql_query($sql); 
}
?>

And just a note, I find it much easier to write php when you treat your pages as programs. Not intermixing php and html will make your source more readable and easier to debug and fix.

szym9341

Thanks for the reply.. Here is what I did... I still get this error & can't figure out why:

Parse error: parse error, unexpected T_BOOLEAN_AND, expecting ',' or ')' in c:\web\sbu\trial.php on line 18

Ohh.. how do you do that color thing with php code?

trial.html
<html>
<body>
Add Type<br /><br />
<form action="trial.php" method="post">
<input type="text" name="typetype" />
<input type="submit" name = "submittype" value="SUBMIT" />
</form>
</body>
</html>

*trial.php
<?php

//***connection to MYSQL*
$dbcnx = @mysql_connect("localhost", "root", "mypassword");
if (!$dbcnx) {
echo( "<p>Unable to connect to the " .
"database server at this time.</p>" );
exit();
}
//connection to the TEST database********
mysql_select_db("test", $dbcnx);
if (! @mysql_select_db("test") ) {
echo( "<p>Unable to locate the test" .
"database at this time.</p>" );
exit();
}

if (isset($POST['submittype'] && $POST['submittype'] == "SUBMIT") {
$sql = "INSERT INTO typetypes (type_id, typetype) VALUES (NULL, '" . $_POST['typetype'] . "')";

$result = mysql_query($sql);

}
?>

eoghain

To color your php code you put it in a bb tab which is [ php ][ /php ] without the spaces, I needed those to get the tag to display for you instead of being parsed.

Now as for your parsing error. This is where I believe the problem is:

//******connection to MYSQL******* 
$dbcnx = @mysql_connect("localhost", "root", "mypassword"); 
if (!$dbcnx) { 
   echo( "<p>Unable to connect to the " . "database server at this time.</p>" ); 
   exit(); 
}

I'd suggest changing your code to not try to append strings inside your call to echo().

//******connection to MYSQL******* 
$dbcnx = @mysql_connect("localhost", "root", "mypassword"); 
if (!$dbcnx) { 
   echo( "<p>Unable to connect to the database server at this time.</p>" ); 
   exit(); 
}

szym9341

I dropped the "." but I still get the same error.. hmm... driving me crazy!

eoghain

Sorry that was my bad. I though you were showing me only 1 file instead of 2 and I miss counted the lines.

Your problem is here:

if (isset($_POST['submittype'] && $_POST['submittype'] == "SUBMIT") {

You are missing a closing ) to the [man]isset/man call:

if (isset($_POST['submittype']) && $_POST['submittype'] == "SUBMIT") {

szym9341

Thank you, thank you... all is well