can't upload files except plain text files?

getget

I use upload.html and upload.php to select a local file and upload to server.
It seems that if the file is plain text, everything is fine. If the type is pdf, ps, doc, etc, the uploaded file has much smaller size and can't be displayed.

I checked both php.ini and upload.html to make sure that the size of the original file has smaller size than the size/memory limit.

Any suggestions or comments are over welcomed.

The source code is like the following:

##############################################################
############# upload.html
############################

<html>
<head>
<title>Administration - upload new files</title>
</head>
<body>
<h1>Upload new news files</h1>
<form enctype="multipart/form-data" action="upload.php" method="post">
<input type="hidden" name="MAX_FILE_SIZE" value="100000000">
Upload this file: <input name="userfile" type="file">
<input type="submit" value="Send File">
</form>
</body>
</html>

#################################################################
############ upload.php ####################################
<html>
<head>
<title>Uploading...</title>
</head>
<body>
<h1>Uploading file...</h1>
<?php

$userfile = $HTTP_POST_FILES['userfile']['tmp_name'];

$userfile_name = $HTTP_POST_FILES['userfile']['name'];

$userfile_size = $HTTP_POST_FILES['userfile']['size'];

$userfile_type = $HTTP_POST_FILES['userfile']['type'];

$userfile_error = $HTTP_POST_FILES['userfile']['error'];

if ($userfile_error > 0)
{
echo 'Problem: ';
switch ($userfile_error)
{
case 1: echo 'File exceeded upload_max_filesize'; break;
case 2: echo 'File exceeded max_file_size'; break;
case 3: echo 'File only partially uploaded'; break;
case 4: echo 'No file uploaded'; break;
}
exit;
}

// put the file where we'd like it

$upfile = '/uploads/'.$userfile_name;

if (is_uploaded_file($userfile))
{
if (!move_uploaded_file($userfile, $upfile))
{
echo 'Problem: Could not move file to destination directory';
exit;
}
}
else
{
echo 'Problem: Possible file upload attack. Filename: '.$userfile_name;
exit;
}

echo ‘uploaded successfully ';

?>
</body>
</html>

Shawazi

I use this code to upload files onto my site - you need to change the checks cause mine only makes sure images are less than 200X200 and are images. But this is the jist. Maybe you should use copy instead of move?? grouppic was my fieldname instead of userfile just cause.

$group = strtolower($grouppic_name);
	if (ereg("(.jpg|.gif)$",$group)) // if picture is .gif or .jpg
	{ //begin picture gif or jpg
		$size = GetImageSize("$grouppic");
		if ($size[0] <= 200 and $size[1] <= 200)
		{ // begin size
			$result = mysql_query("select * from users where id=\"$yourid\"");
			$row = mysql_fetch_array($result);
			@unlink("../users/bandpics/$row[picloc]");
			copy("$grouppic", "../users/bandpics/$yourname-$group");
			mysql_query("update users set picloc=\"$yourname-$group\" where id=\"$yourid\"");
		$message = "$grouppic_name was uploaded successfully.";


	}
	else
	{
		$message = "$grouppic_name was not uploaded because it is bigger than 200X200.";

	}
}
else
{
	$message = "$grouppic_name was not uploaded because it is not a .jpg or .gif.";

}