image validation script, please check

[Paul_Ferrie]

Hello guys,
Hopfully someone can correct my coding. i am trying to check the values of an image to be submitted in a form.

My problem is building the if statement to check the dimenssions and file type.

Here's what i have so far

 <?  

$fp = @fopen("$imgurl", "r");
$size = getimagesize("$imgurl");  

if($fp){  

    $width = $size[0];  

    $height = $size[1];  

    $imgType = $size[2];


if($width>75){
$fail("image size incorrect");
  elseif
  $height>75;
  $fail("image size incorrect");
  elseif
  $imgType==3;
  $fail("incorrect image type");
  elseif
  $imgType>5;
  $fail("incorrect image type");
  }
  echo "img width = $width  img height = $height img type =  $imgType" ;
  }
  }
  ?>

Now i know that the coding is wrong, i am hoping someone here can fix it for me, pretty sure this code could be tweeked right down.

Cheers
Paul

[leatherback]

Hi,

I am not sure what your errors are... But I suppose you could use plain if statements, not elseifs?

if($width>75)
{
$fail("image size incorrect");
}
if ($height>75)
{
$fail("image size incorrect");
}
if($imgType==3)
{
$fail("incorrect image type");
}
if($imgType>5)
{

$fail("incorrect image type");
}

echo "img width = $width img height = $height img type = $imgType" ;

Otherwise..

Try structuring:

if(...)
 { }
  else
    {
     if ()
       {
        }
     }

J

[Paul_Ferrie]

Sorted now 🙂
thanks for your help

 <?  

$fp = @fopen("$imgurl", "r");
if (!$fp){ 
     print"&retval=1&imgval=false"; 
	}else
if($fp){ 
	$size = getimagesize("$imgurl"); 
    $width = $size[0];  

    $height = $size[1];  

    $imgType = $size[2];
   if($width>75) { 
//$fail("image size incorrect"); 
print "Incorrect image width ";
} else
if ($height>75) { 
//$fail("image size incorrect"); 
print "Incorrect image height ";
} else
if($imgType==3) {
 print "Incorrect image type";
//$fail("incorrect image type"); 
} else
if($imgType>5) {
print "Incorrect image type"; 
//$fail("incorrect image type"); 
} else{
 print"&retval=1&imgval=true"; 
    fclose($fp);  

  }     

}
?>

[Paul_Ferrie]

Hi can you see anything wrong in the code of my last post. Can't get it to work now 🙁
Should have made a backup before i started to tinker some more.

Cheers
Paul

[panreach]

don't forget proper if, elseif, and else syntax:

if ($i==1) {
  echo "it's equal to one.";
}
else {
  echo "it's not equal to one.";
}

or

if ($i==1) {
  echo "it's equal to one.";
}
elseif ($i==3) {
  echo "it's equal to three.";
}
elseif ($i==7) {
  echo "it's equal to seven.";
}
else {
  echo "I don't know what it's equal to.  I know it's not equal to 1, 3, or 7 though!";
}

[Paul_Ferrie]

yes got it sorted thanks

Paul