Error in if statement

Sam_Starling

<?
$time = date("Hi"); 
$day = date("D");

// Monday's Schedule
	if($day == "Mon") 
		{
		if(($time_>=_'0000')_&&_($time_<=_'0459'))_{ include('onair/stacey.php'); }
		if(($time_>=_'0500')_&&_($time_<=_'0959'))_{ include('onair/david.php'); }
		if(($time_>=_'1000') && ($time <= '1459'))_{ include('onair/yasmin.php'); }
		if(($time_>=_'1500') && ($time <= '1859'))_{ include('onair/darren.php'); }
		if(($time_>=_'1900') && ($time <= '2359'))_{ include('onair/brian.php'); }
		}	
	else
		{
		include('onair/notfound.php');
		}
?>

Can anybody see what I've done wrong here?

The error seems to be with...

if(($time_>=_'0000')_&&_($time_<=_'0459'))_{ include('onair/stacey.php'); }

...and...

if ( ($time_=>_'0000')_&&_($time_=<_'0459') )_
{
	include('onair/stacey.php');
}

...doesn't help the matter.

The error is a parse error.

Kind regards, and thanks for any help in advance.
Sam

Sam_Starling

NB: vBulletin seems to be replacing some spaces with underscores within the PHP code. Not sure why. Just take underscores to be spaces.

Thanks 🙂

Sam_Starling

Anyone? Any ideas?

Thanks,
Sam

rheroux

It looks fine to me (other than the underscores of course).

You may want to check to see if the server you're running the script on allows short open tags.

And really, it's always good practice to use the <?php open tag for portability.

slak

 <? 
$time = date("Hi");  

$day = date("D"); 

echo("time: ".$time."<br />day: " .$day."<br />");

// Monday's Schedule 
	if($day == "Tue") { 
        if(($time>=0000) && ($time<=0459)) {
			echo('onair/stacey.php');
		} 
        if(($time>=0500) && ($time<=0959)) {
			echo('onair/david.php');
		} 
        if(($time>=1000) && ($time <= 1459)) {
			echo('onair/yasmin.php');
		} 
        if(($time>=1500) && ($time <= 1859)) {
			echo('onair/darren.php');
		} 
        if(($time>=1900) && ($time <= 2359)) {
			echo('onair/brian.php');
		} 
	}     

    else { 
        echo('onair/notfound.php'); 
	} 
?>

Becareful with your variable names. Some may turn out to be php keywords.

Not having your times enclosed in quotes will speed up execution every so slightly as the parser doesn't have to convert the string to an integer.

I've changed "include" to "echo" in the above script - just so you know to change it back.

The reason why this wasn't working is because today is Tue :p

Sam_Starling

Yeah, I know about the Tue thing 🙂

In reality, the file has Mon, Tue, Wed etc., but that would have been far too long to post.

I've changed the <? to <?php and that hasn't done anything yet.

And should the include be echo?

slak

It's working on my Win32 server here. Darren would be playing if today was Monday.

Yes, change echo to include.

Sam_Starling

Right you are, thanks very much for your help!

slak

Depending on where you host your application, you'll have to set the locale to UK (This is for Lanarkshire's Clan FM, right?) or write a function to use GMT/BST.

If you're using a UK host it should be fine.

Sam_Starling

I'm actually on a US server 🙁
How can I change the $time variable so it is GMT?

Plus:

if(($time>=0000)_&&_($time<=0459))_{ echo('onair/stacey.php'); }

That still isn't working for me!
I've checked the file is what it should be on the server, and I've used <?php, but to no avail!

Any ideas?

slak

You set the locale by using;

setlocale (LC_ALL, 'en_UK');

Or you could grab the epoch and add the number of seconds to make it up to UK time or read up on the date functions 🆒

gmstrftime

Sam_Starling

Thanks! And any more ideas about this error? Getting a bit annoying for me now! 🙁

slak

What's the error message?

Sam_Starling

Parse error on line 8...

slak

I've got 10 minutes before I got to leave work, so if you can post all your code before then, I'll have a quick look.

Cheers.

Sam_Starling

<?php

setlocale(LC_ALL, 'en_UK');

$time_=_strftime("%H%M");
$day = strftime("%u");

// Monday's Schedule
	if($day == "1") 
		{
		if(($time >= '0000')_&&_($time <= '0459'))_{ echo('onair/stacey.php'); }
		if(($time_>=_'0500')_&&_($time_<=_'0959'))_{ echo('onair/david.php'); }
		if(($time_>=_'1000') && ($time <= '1459'))_{ echo('onair/yasmin.php'); }
		if(($time_>=_'1500') && ($time <= '1859'))_{ echo('onair/darren.php'); }
		if(($time_>=_'1900') && ($time <= '2359'))_{ echo('onair/brian.php'); }
		}	
	else
		{
		echo('onair/notfound.php');
		}

// Tuesday's Schedule
	if($day == "2") 
		{
		if(($time_>=_'0000') && ($time <= '0459'))_{ echo('onair/derek.php'); }
		if(($time_>=_'0500') && ($time <= '0959'))_{ echo('onair/david.php'); }
		if(($time_>=_'1000') && ($time <= '1459'))_{ echo('onair/yasmin.php'); }
		if(($time_>=_'1500') && ($time <= '1859'))_{ echo('onair/darren.php'); }
		if(($time_>=_'1900') && ($time <= '2359'))_{ echo('onair/brian.php'); }
		}	
	else
		{
		echo('onair/notfound.php');
		}

// Wednesday's Schedule
	if($day == "3") 
		{
		if(($time_>=_'0000') && ($time <= '0459')) { echo('onair/ryan.php'); }
		if(($time_>=_'0500') && ($time <= '0959')) { echo('onair/david.php'); }
		if(($time_>=_'1000') && ($time <= '1459')) { echo('onair/yasmin.php'); }
		if(($time_>=_'1500') && ($time <= '1859')) { echo('onair/darren.php'); }
		if(($time_>=_'1900') && ($time <= '2359')) { echo('onair/brian.php'); }
		}	
	else
		{
		echo('onair/notfound.php');
		}

// Thursday's Schedule
	if($day == "4") 
		{
		if(($time_>=_'0000') && ($time <= '0459')) { echo('onair/colin.php'); }
		if(($time_>=_'0500') && ($time <= '0959')) { echo('onair/david.php'); }
		if(($time_>=_'1000') && ($time <= '1459')) { echo('onair/yasmin.php'); }
		if(($time_>=_'1500') && ($time <= '1859')) { echo('onair/darren.php'); }
		if(($time_>=_'1900') && ($time <= '2359')) { echo('onair/brian.php'); }
		}	
	else
		{
		echo('onair/notfound.php');
		}

// Friday's Schedule
	if($day == "5") 
		{
		if(($time_>=_'0000') && ($time <= '0459')) { echo('onair/colin.php'); }
		if(($time_>=_'0500') && ($time <= '0959')) { echo('onair/david.php'); }
		if(($time_>=_'1000') && ($time <= '1459')) { echo('onair/yasmin.php'); }
		if(($time_>=_'1500') && ($time <= '1859')) { echo('onair/darren.php'); }
		if(($time_>=_'1900') && ($time <= '2359')) { echo('onair/brian.php'); }
		}	
	else
		{
		echo('onair/notfound.php');
		}

// Saturday's Schedule
	if($day == "6") 
		{
		if(($time_>=_'0000') && ($time <= '0559')) { echo('onair/john_s.php'); }
		if(($time_>=_'0600') && ($time <= '0959')) { echo('onair/john_b.php'); }
		if(($time_>=_'1000') && ($time <= '1429')) { echo('onair/brian.php'); }
		if(($time_>=_'1430') && ($time <= '1859')) { echo('onair/yasmin.php'); }
		if(($time_>=_'1900') && ($time <= '2359')) { echo('onair/billy.php'); }
		}	
	else
		{
		echo('onair/notfound.php')
		}

// Sunday's Schedule
	if($day == "7") 
		{
		if(($time_>=_'0000') && ($time <= '0559')) { echo('onair/derek.php'); }
		if(($time_>=_'0500') && ($time <= '0959')) { echo('onair/john_b.php'); }
		if(($time_>=_'1000') && ($time <= '1359')) { echo('onair/david.php'); }
		if(($time_>=_'1400') && ($time <= '1559')) { echo('onair/aaron.php'); }
		if(($time_>=_'1600') && ($time <= '1859')) { echo('onair/shchart.php'); }
		if(($time_>=_'1900') && ($time <= '2359')) { echo('onair/derek.php'); }
		}	
	else
		{
		echo('onair/notfound.php');
		}
?>

There you go 🙂

rheroux

// Saturday's Schedule 
    if($day == "6")  

        { 
        if(($time_>=_'0000') && ($time <= '0559')) { echo('onair/john_s.php'); } 
        if(($time_>=_'0600') && ($time <= '0959')) { echo('onair/john_b.php'); } 
        if(($time_>=_'1000') && ($time <= '1429')) { echo('onair/brian.php'); } 
        if(($time_>=_'1430') && ($time <= '1859')) { echo('onair/yasmin.php'); } 
        if(($time_>=_'1900') && ($time <= '2359')) { echo('onair/billy.php'); } 
        }     

    else 
        { 
        echo('onair/notfound.php') 
        }

You need a semicolon after that echo statement.

Sam_Starling

Thanks for that.
However, please could check the errors you get when you run the code?
Some people says it runs fine, but doesn't work for me at all!

Kind regards,
Sam

slak

Without being rude, that code is bloated to the max and I'd recommend you read the manual (especially about date, conditional statements, strings, integers). A book would probably be your best bet. There's loads out there 🙂

Anyway - I've tested this on a local (win32, 2.x, 4.3.3) and remote (linux, 1.3x, 4.3.3) server and both work for GMT.

<?php 
setlocale (LC_ALL, 'en_UK');

$time=gmstrftime("%H%M"); 
$day = gmstrftime("%w"); 

echo("Debug Stuff....<br />Time: ".$time."<br />Day: ".$day."<br />");


switch($day) {
	case 0:
        if(($time >= '0000')&&($time <= '0459')){ echo('onair/stacey.php'); } 
        elseif(($time>='0500')&&($time<='0959')){ echo('onair/david.php'); } 
        elseif(($time>='1000') && ($time <= '1459')){ echo('onair/yasmin.php'); } 
        elseif(($time>='1500') && ($time <= '1859')){ echo('onair/darren.php'); } 
        elseif(($time>='1900') && ($time <= '2359')){ echo('onair/brian.php'); } 
		else {
			echo('onair/notfound.php');
		}
	break;

case 1:
    if(($time>='0000') && ($time <= '0459')){ echo('onair/derek.php'); } 
    elseif(($time>='0500') && ($time <= '0959')){ echo('onair/david.php'); } 
    elseif(($time>='1000') && ($time <= '1459')){ echo('onair/yasmin.php'); } 
    elseif(($time>='1500') && ($time <= '1859')){ echo('onair/darren.php'); } 
    elseif(($time>='1900') && ($time <= '2359')){ echo('onair/brian.php'); }
	else {
		echo('onair/notfound.php');
	}
break;

case 2:
    if(($time>='0000') && ($time <= '0459')) { echo('onair/ryan.php'); } 
    elseif(($time>='0500') && ($time <= '0959')) { echo('onair/david.php'); } 
    elseif(($time>='1000') && ($time <= '1459')) { echo('onair/yasmin.php'); } 
    elseif(($time>='1500') && ($time <= '1859')) { echo('onair/darren.php'); } 
    elseif(($time>='1900') && ($time <= '2359')) { echo('onair/brian.php'); } 
	else {
		echo('onair/notfound.php');
	}
break;

case 3:
    if(($time>='0000') && ($time <= '0459')) { echo('onair/colin.php'); } 
    elseif(($time>='0500') && ($time <= '0959')) { echo('onair/david.php'); } 
    elseif(($time>='1000') && ($time <= '1459')) { echo('onair/yasmin.php'); } 
    elseif(($time>='1500') && ($time <= '1859')) { echo('onair/darren.php'); } 
    elseif(($time>='1900') && ($time <= '2359')) { echo('onair/brian.php'); } 
	else {
		echo('onair/notfound.php');
	}
break;

case 4:
    if(($time>='0000') && ($time <= '0459')) { echo('onair/colin.php'); } 
    elseif(($time>='0500') && ($time <= '0959')) { echo('onair/david.php'); } 
    elseif(($time>='1000') && ($time <= '1459')) { echo('onair/yasmin.php'); } 
    elseif(($time>='1500') && ($time <= '1859')) { echo('onair/darren.php'); } 
    elseif(($time>='1900') && ($time <= '2359')) { echo('onair/brian.php'); } 
	else {
		echo('onair/notfound.php');
	}
break;

case 5:
    if(($time>='0000') && ($time <= '0559')) { echo('onair/johns.php'); } 
    elseif(($time>='0600') && ($time <= '0959')) { echo('onair/johnb.php'); } 
    elseif(($time>='1000') && ($time <= '1429')) { echo('onair/brian.php'); } 
    elseif(($time>='1430') && ($time <= '1859')) { echo('onair/yasmin.php'); } 
    elseif(($time>='1900') && ($time <= '2359')) { echo('onair/billy.php'); } 
	else {
		echo('onair/notfound.php');
	}
break;

case 6:
    if(($time>='0000') && ($time <= '0559')) { echo('onair/derek.php'); } 
    elseif(($time>='0500') && ($time <= '0959')) { echo('onair/johnb.php'); } 
    elseif(($time>='1000') && ($time <= '1359')) { echo('onair/david.php'); } 
    elseif(($time>='1400') && ($time <= '1559')) { echo('onair/aaron.php'); } 
    elseif(($time>='1600') && ($time <= '1859')) { echo('onair/shchart.php'); } 
    elseif(($time>='1900') && ($time <= '2359')) { echo('onair/derek.php'); } 
	else {
		echo('onair/notfound.php');
	}
break;
}
?>

Sam_Starling

OK, I'm about to go off and buy a PHP book on Amazon, you'll be glad to hear 🙂

And I'm going to ask my host why the PHP script isn't working...

Any suggestions on how to streamline the code?

Thanks
Sam