download script

tennhio

I tried this script to download file from my web site:

save.php

$nomefile = substr (strrchr ($mitt, "/"), 1);
header("Content-type: application/save");
header("Content-Disposition: attachment; filename=".$nomefile);
header( "Content-Description: File Transfert");
readfile($mitt);

?>

Link to download in my web page is something like this:
http://myweb/save.php?mitt=ftp://user:pwd@ftpsite/filename.ext
The browser open correctly "save as" dialog but result is a 0 byte file.
I tried to add "fpassthru" after "readfile" but the result is the same.
If I add an "echo" of some string just before and after "readfile", I can see strings in downloaded file.
Can U help me

AstroTeg

Try this content type: application/octet-stream

Also, whats up with the ftp user and password being sent to the web server? Is this a user/password combo you don't mind sharing with your users of that page?

tennhio

Ok AstroTeg, I tried application/octet-stream but file is 0 byte.
The problem could be the remote URL of "readfile" ? I can't use local filesystem naming because some files is stored in other ftp sites.

AstroTeg

Make sure $mitt has a value. I'd predict if you don't have $mitt = $_GET['mitt']; already in your code, $mitt will be null (which would be a good reason why you're getting a 0 length file).

Also note you have one super huge security hole which will allow folks to read just about any file on your web server your script has access to.

tennhio

Cecked!!! $mitt has the right value.
I tried using an HTTP url address instead of FTP (save.php?mitt=http://myweb/nomefile.ext)
and ALL IS OK. Why "readfile" not accept ftp????

cosminb

also check to see if the fopen wrappers are enabled in php.ini

AstroTeg

You may have to use PHP's FTP functions to do FTP...

tennhio

How should be the code to download file with php function directly in STDOUT so the browser can grab the file after the header definitions?