eliminating extra array element

denniston

I'm using the following code to split a databse feild into an array, and then print the array-formatted. In this particular feild are an undetermined amount of questions, after each question a response (textbox) is printed. I'm using the question marks in the feild as my seperator, the problem is that I end up with one extra element after the last "?"

$str2 = $myrow[$question];
$question2 = preg_split ("/[?]+/", $str2);
foreach($question2 as $value2) {
print "<br>$value2?<br><TEXTAREA ROWS=5 COLS=48></TEXTAREA><br>";
}

dotbob

Quickfix:

Instead of using foreach to step through your array, use...

for($i=0;$i < (count($question2)-1);$i++)
{
print "<br>".$question2[$i]."?<br><TEXTAREA ROWS=5 COLS=48></TEXTAREA><br>"; 
}

This should retrieve all data in the array with the exception of the last element.

Hope this helps.

AstroTeg

Any reason not to use explode? Every odd number would be the question and every even number would be the answer. Just a thought...

denniston

I'm using this:
$str2 = $myrow[$question];
$question2 = preg_split ("/[?]+/", $str2);
for($i=0;$i < (count($question2)-1);$i++){
print "<br>".$question2[$i]."?<br><TEXTAREA ROWS=5 COLS=48></TEXTAREA><br>";
}

which seems to work great...unless there is no "?" in the questions
i.e. "Do (...work to do)."

dotbob

Can you not store the questions within the db field seperated by an obscure character i.e. ;

For example: question1?;question2?;question3

That way, as AstroTeg said, you could explode the returned field on every instance of ; and you would have a perfect array.

When storing the data in the DB though, make sure that you don't add a ; after the last question or you will return an empty element after you have exploded the data.

An example of this:

$str2 = $myrow[$question]; 
$arr_example = explode(";",$str2);

if(isarray($arr_example))
{
foreach($arr_example as $arr_element)
{
print "<br>".$arr_element."?<br><TEXTAREA ROWS=5 COLS=48></TEXTAREA><br>"; 
}
}