Please HELP with Warning:Invalid argument

[lilamy30]

Hello i have a rateme script and it all seems to work ok untill i try to update profile
thats when i get this message

Warning: Invalid argument supplied for foreach() in /home/southern/public_html/mm/profile.php on line 14

profile.php

PHP Code

<?php
require_once("includes/config.php");
require_once("includes/functions.php");
require_once("includes/tpl_engine.class");
require_once("includes/checklogin.php");
$connect = dbconnect($DBHost, $DBName, $DBUser, $DBPass);

IF(isset($POST['Submit']))
{
mysql_query("UPDATE outoften_users SET group_id = '" . $POST['group'] . "',user_email = '" . $POST['email'] . "' WHERE user_id = '" . $SESSION['id'] . "' LIMIT 1;");

$custom = "UPDATE `outoften_custom` SET ";
$count = 0;
foreach ($_POST['custom'] as $key => $value)
{
    $count = $count + 1;
    IF(count($_POST['custom']) > 1)
    {
        IF($count == 1)
        {
            $custom .= " `" . $key . "` = '" . $value . "'";
        }
        ELSE
        {
            $custom .= ", `" . $key . "` = '" . $value . "'";
        }
    }
    ELSE
    {
        $custom .= "`" . $key . "` = '" . $value . "'";
    }
}
$custom .= " WHERE `user_id` = '" . $_SESSION['id'] . "' LIMIT 1 ;";
mysql_query($custom);

}

$page = new HtmlTemplate ("templates/" . $tpl_name . "/profile.html");
$page->SetParameter ("OVERALL_HEADER", get_header($tpl_name,$site_title));
$page->SetParameter ("LEFT_MENU", get_left_menu($tpl_name,''));
$query = "SELECT * FROM outoften_users WHERE user_id='" . $SESSION['id'] . "' LIMIT 1";
$query_result = mysql_query ($query);
while ($info = mysql_fetch_array($query_result))
{
$page->SetParameter ("FIELD_USERNAME", $info['user_username']);
$page->SetParameter ("FIELD_EMAIL", $info['user_email']);
$page->SetParameter ("GROUP_LIST", get_profile_group_list($info['group_id']));
$page->SetParameter ("USER_ID", $SESSION['id']);
$page->SetParameter ("CUSTOM_FIELDS", get_custom_profile_fields($info['user_id'],$connect,$DBName));
}
$page->SetParameter ("RIGHT_MENU", get_right_menu($tpl_name,$cache_time));
$page->SetParameter ("OVERALL_FOOTER", get_footer($tpl_name));
$page->CreatePageEcho();
?>

and here is the tpl_engine class

PHP Code

<?php
class HtmlTemplate {

var $template;
var $html;
var $parameters = array();

function HtmlTemplate ($template)
{
    $this->template = $template;
    $this->html = implode ("", (file($this->template)));
}

function SetParameter ($variable, $value)
{
    $this->parameters[$variable] = $value;
}

function CreatePageEcho () 
{

    foreach ($this->parameters as $key => $value) 
    {
        $template_name = '{' . $key . '}';
        $this->html = str_replace ($template_name, $value, $this->html);
    }    
    echo $this->html;
}
function CreatePageReturn () 
{

    foreach ($this->parameters as $key => $value) 
    {
        $template_name = '{' . $key . '}';
        $this->html = str_replace ($template_name, $value, $this->html);
    }    
    return $this->html;
}

}
?>

if you need more INFO let me

[ClevaTreva]

Hi

It's quite late here and I've had some(!!) beer, BUT

the foreach section has one too many }'s, I think. Shouldn't it be like this:

foreach ($_POST['custom'] as $key => $value) 
{ 
$count = $count + 1; 
IF(count($_POST['custom']) > 1) 
{ 
IF($count == 1) 
{ 
$custom .= " `" . $key . "` = '" . $value . "'"; 
} 
ELSE 
{ 
$custom .= ", `" . $key . "` = '" . $value . "'"; 
} 
} 
ELSE 
{ 
$custom .= "`" . $key . "` = '" . $value . "'"; 
} 
$custom .= " WHERE `user_id` = '" . $_SESSION['id'] . "' LIMIT 1 ;"; 
mysql_query($custom); 
} 

Just a quick thought. Gonna get some sleep. :o

Trevor

[lilamy30]

No thats what thought but that was not it

[ahundiak]

I assume line 14 is:
foreach ($_POST['custom'] as $key => $value)

Which means that $_POST['custom'] is not an array. I don't see where in your template code any elements with a name of custom[] are being generated.

Maybe you meant to use CUSTOM_FIELDS?

If not, please paste the html source with the custom[] elements.

And surround your posted code with [ PHP]
and [ /PHP]. Much easier to read.

[lilamy30]

<?php
require_once("includes/config.php");
require_once("includes/functions.php");
require_once("includes/tpl_engine.class");

$connect = dbconnect($DBHost, $DBName, $DBUser, $DBPass);

$page = new HtmlTemplate ("templates/$tpl_name/register.html");

IF(isset($POST['Submit']))
{
IF($POST['username'] == "")
{
$page->SetParameter ("USERNAME_ERROR", "<br>You did not complete the username field");
$error = 1;
}
ELSE
{
$page->SetParameter ("USERNAME_ERROR", "");
}
IF($POST['password'] == "")
{
$page->SetParameter ("PASSWORD_ERROR", "<br>You did not complete the password field");
$error = 1;
}
ELSE
{
$page->SetParameter ("PASSWORD_ERROR", "");
}
IF($POST['password'] != $POST['password2'])
{
$page->SetParameter ("PASSWORD_ERROR", "<br>Your passwords did not match");
$error = 1;
}
IF($POST['email'] == "")
{
$page->SetParameter ("EMAIL_ERROR", "<br>You did not complete the email field");
$error = 1;
}
ELSE
{
$page->SetParameter ("EMAIL_ERROR", "");
}

$page->SetParameter ("FIELD_USERNAME", $_POST['username']);
$page->SetParameter ("FIELD_EMAIL", $_POST['email']);

IF(!isset($error))
{
	$sql = "INSERT INTO `outoften_users` ( `user_id` , `group_id` , `user_username` , `user_password` , `user_email` , `user_ratings` , `user_totalratings` , `user_avgrating` ) VALUES ('', '" . $_POST['group'] . "', '" . $_POST['username'] . "', '" . md5($_POST['password']) . "', '" . $_POST['email'] . "', '0', '0', '0.00');";
	mysql_query($sql);
	$query_string = "INSERT INTO `outoften_custom` ( `user_id`";
	foreach ($_POST['custom'] as $key => $value) {
		$query_string .= " , `" . $key . "`";
	}
	$query_string .= " ) VALUES ('" . mysql_insert_id() . "'";
	foreach ($_POST['custom'] as $key => $value) {
		$query_string .= " , '" . $value . "'";
	}
	$query_string .= ");";
	$signup_id = mysql_insert_id();
	mysql_query($query_string);
	require_once("includes/email.php");
	$email = implode("", file("templates/" . $tpl_name . "/emails/signup.txt"));
	$email = eregi_replace("{USERNAME}", $_POST['username'], $email);
	$email = eregi_replace("{PASSWORD}", $_POST['password'], $email);
	$email = eregi_replace("{URL}", $site_url . "login.php", $email);

	$addy = $_POST['email'];
	$m= new Mail;
	$m->From($admin_email);
	$m->To($addy);
	$m->Subject($site_title . " Registration Details");
	$m->Body($email);
	$m->Send();
	setcookie("outoften[userid]", $user_id,time()[phone]);
	setcookie("outoften[user]", $_POST['username'],time()[phone]);
	setcookie("outoften[pass]", md5($_POST['password']),time()[phone]);
	session_start();
	$_SESSION['id'] = $signup_id;
	$_SESSION['username'] = $_POST['username'];

	header("Location: index.php");
	exit;
}

}
ELSE
{
$page->SetParameter ("USERNAME_ERROR", "");
$page->SetParameter ("PASSWORD_ERROR", "");
$page->SetParameter ("PASSWORD_ERROR", "");
$page->SetParameter ("EMAIL_ERROR", "");
$page->SetParameter ("FIELD_USERNAME", "");
$page->SetParameter ("FIELD_EMAIL", "");
}
$page->SetParameter ("OVERALL_HEADER", get_header($tpl_name,$site_title));
$page->SetParameter ("LEFT_MENU", get_left_menu($tpl_name,''));
$page->SetParameter ("GROUP_LIST", get_group_list($tpl_name));
$page->SetParameter ("CUSTOM_FIELDS", get_custom_fields($connect,$DBName));
$page->SetParameter ("RIGHT_MENU", get_right_menu($tpl_name,$cache_time));
$page->SetParameter ("OVERALL_FOOTER", get_footer($tpl_name));
$page->CreatePageEcho();

?>

<?php

[ahundiak]

Not really. I asked for the html code. Html is what actually ends up getting sent to the browser. Most browsers have some sort of "View Source" command.

The thing is, $_POST['custom'] is looking for data with a name of custom[]. The closest line that I can see is:
$page->SetParameter ("CUSTOM_FIELDS", get_custom_fields($connect,$DBName));

In any event, by looking at the actual generated html it should be possible to verify if any custom elements are being generated.

And I really don't see where your template processor is handling arrays. Even if get_custom_fields returns an array the template processor thinks it's a string.

You might try adding:
error_reporting(E_ALL);
To the top of the script and tracking down any other warnings that come up.

[lilamy30]

this is the functions.php

function get_custom_fields($connect,$DBName)
{
$fields = mysql_list_fields($DBName, "outoften_custom", $connect);
$columns = mysql_num_fields($fields);

$array = "<table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"5\">";
for ($i = 0; $i < $columns; $i++) {
	$field_name = mysql_field_name($fields, $i);
	$name = $field_name;
	$len = mysql_field_len($fields, $i);
	IF($name != "user_id")
	{
		$name = eregi_replace("user_", " ", $name);
		$name = eregi_replace("_", " ", $name);
		$names = explode(" ", $name);
		$name = "";
		$count = count($names);
		$count = $count;
		$i = 0;
		foreach ($names as $value) {
			$i = $i + 1;
			$first = substr($value, 0, 1);
			$after = strlen($value);
			$name .= strtoupper($first) . substr($value, 1, $after);
			IF($count != $i)
			{
				$name .= " ";
			}
		}
		$array .= "<tr>";
		$array .= "<td width=\"150\"><div align=\"right\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\">" . $name . ":</font></div></td>";
		$array .= "<td><input name=\"custom[" . $name . "]\" type=\"text\" size=\"30\" maxlength=\"" . $len . "\"></td>";
		$array .= "</tr>";
	}
}
$array .= "</table>";
return $array;

}
function get_user_info($id)
{
IF($id != 0)

[ahundiak]

Good luck. I know you are new to the board so I'll give you a farewell hint. If someone is trying to help you then read their responses and provide any requested information.