Connecting

[Billett]

Hi, im using the following code which works fine in connection and displaying my data base but is there a way i can cut down the query section of it as its too complecated

    <?php
    $server= "***.*.*.*"; //localhost

$databasename = "test"; 
$tablename= "user";    
$connection = mysql_connect("$server");
if(!$connection
{
echo "Couldn't make a connection!!!";
exit; 
}
$db = mysql_select_db("$databasename",$connection);
if(!$db)
{
echo "The database disapeared!";
mysql_close($connection);
exit; 
}


$query = "SELECT * FROM user ";
$result = mysql_query($query) or die("Query failed : " . mysql_error());

print "<table border=0
 cellpadding=5 BORDERCOLOR=#FFCC33>\n";
    while ($line = mysql_fetch_array($result, MYSQL_ASSOC)) {
        print "\t<tr>\n";
        foreach ($line as $col_value) {
            print "\t\t<td>$col_value</td>\n";
        }
        print "\t</tr>\n";
    }
    print "</table>\n";


mysql_free_result($result);

mysql_close($connection);

 ?>

[szym9341]

$dbcnx = @mysql_connect("localhost", "user", "password");
if (!$dbcnx) {
   echo ( "<p>Unable to connect to the MySQL Server</p>" );
   exit ();
}
mysql_select_db("yourdatabase");
if (! @mysql_select_db("yourdatabase")){
  echo ("<p>Unable to connect to the database at this time</p>");
  exit();
}

[planetsim]

mysql_select_db("yourdatabase");
if (! @mysql_select_db("yourdatabase"))

Why have it twice. If you run it purely in the if statement it will still select the database, it also doesnt require the @ to supress any errors because if there is it will return false

[szym9341]

Do you mean I should just keep it the same way, except remove the "@" symbols?

$dbcnx = mysql_connect("localhost", "user", "password"); 
if (!$dbcnx) { 
   echo ( "<p>Unable to connect to the MySQL Server</p>" ); 
   exit (); 
} 
mysql_select_db("yourdatabase"); 
if (! mysql_select_db("yourdatabase")){ 
  echo ("<p>Unable to connect to the database at this time</p>"); 
  exit(); 
}

[planetsim]

$dbcnx = mysql_connect("localhost", "user", "password"); 
if (!$dbcnx) { 
   echo  "<p>Unable to connect to the MySQL Server</p>"; 
   exit (); 
} 
if (!mysql_select_db("yourdatabase")){ 
  echo "<p>Unable to connect to the database at this time</p>"; 
  exit(); 
}

Hmm.. i didnt know i was that unclear i think i did say do not have it twice but anyway. Basically it will just be parsed anyway so it will select the database but if false will return the error, and exit the script.

Also you dont need the parenthesis for the echo statement its just an extra load on the server.