Input from for to database

[Billett]

Ive created a table of which i would like some data to be entered from a form but when i do this i seem to the number 1 in every column istead of what i entered

mysql table output:

mysql> select * from user;
+--------+-------+-------------+--------------------------+
| name | email | username | password |
+--------+-------+-------------+--------------------------+
| 1 | 1 | 1 | 606717496665bcba |
+--------+-------+-------------+--------------------------+
1 row in set (0.00 sec)

my php code is as follows

<?PHP
$page_title = 'Register!';
include ('./header.inc');

if (isset($_POST['submit'])) {

if (strlen($_POST['name']) > 0) {
	$name = TRUE;
} else {
	$name = FALSE;
	echo '<p><font color="red">***Please enter your name***</font></p>';
}

if (strlen($_POST['email']) > 0) {
	$email = TRUE;
} else {
	$email = FALSE;
	echo '<p><font color="red">***Please enter your email address***</font></p>';
}

if (strlen($_POST['username']) > 0) {
	$username = TRUE;
} else {
	$username = FALSE;
	echo '<p><font color="red">***Please enter your username***</font></p>';
}

if (strlen($_POST['password1']) >0) {
if ($_POST['password1'] == $_POST['password2']) {
	$password = TRUE;
} else {
	$password = FALSE;
	echo '<p><font color="red">***Passwords dont match***</font></p>';
}
} else {

$password = FALSE;
echo '<p><font color="red">***Please enter your password***</font></p>';
}

if ($name && $email && $username && $password) {

require_once ('./connect1.php');

$query = "insert into user (name, email, username, password) values ('$name', '$email', '$username', 

PASSWORD('$password'))"; 
$result = mysql_query($query); 

echo '<p>You are now registered</p>';

include ('./footer.inc');
exit();

} else {
	echo '<p> Please go <a href="http://billett.hopto.org/PHP/register.php">back</a> and try again</p>';
	}
} else {

?>

<form action="<?PHP echo $_SERVER['PHP_SELF']; ?>" method="post">

<fieldset>
<legend><font color="red">Enter Your Information Below </font></legend>

<p><b>Name:</b> <INPUT type="text" name="name" size="20" maxlength="40"></p>

<p><b>Email Address:</b> <INPUT type="text" name="email" size="40" maxlength="60"></p>

<p><b>Username:</b> <INPUT type="text" name="username" size="20" maxlength="40"></p>

<p><b>Password:</b> <INPUT type="password" name="password1" size="20" maxlength="40"></p>

<p><b>Confirm Password:</b> <INPUT type="password" name="password2" size="20" maxlength="40"></p>
</fieldset>

<div align="center"><input type="submit" name="submit" value="Finish Registration" />
</div>

</form>

<?php

}
include ('./footer.inc');
?>

[sfullman]

Your form looks OK, but what I'mnoticing is the top-- your command line SQL prompt is telling you your value in username and email is 1 -- so you shouldn't be surprised, the command line is probably not lying.

You may have name, email, and username fields set to type integer, with a default value of 1, I don't know, but you need to check this first.

Try entering a record directly from the SQL command prompt and then select it again and see if the values persisted, OR you can do:

DESCRIBE table mytable

I believe.

Looks like you don't have any primary key in your table, that's probably OK. Also, your queries will fail for a name like O'Reilly because of the ', you need to add slashes (unless you have magic quotes turned on).

Sam

[Shrike]

Your setting values like $username, $password etc to TRUE or FALSE, so it's hardly surprising that they get entered into the database as 1 🙂

[Billett]

how can i change this but keep the validation?

[Shrike]

$username_check = TRUE instead of $username = TRUE

... etc ....

if($username_check && $password_check && ... etc ...

instead of

if($username && $password && ... etc ...

[Billett]

i changed it so it loos like this as u said and it entered blank values into the table

if (isset($_POST['submit'])) {

if (strlen($_POST['name']) > 0) {
	$name_check = TRUE;
} else {
	$name_check = FALSE;
	echo '<p><font color="red">***Please enter your name***</font></p>';
}

if (strlen($_POST['email']) > 0) {
	$email_check = TRUE;
} else {
	$email_check = FALSE;
	echo '<p><font color="red">***Please enter your email address***</font></p>';
}

if (strlen($_POST['username']) > 0) {
	$username_check = TRUE;
} else {
	$username_check = FALSE;
	echo '<p><font color="red">***Please enter your username***</font></p>';
}

if (strlen($_POST['password1']) >0) {
if ($_POST['password1'] == $_POST['password2']) {
	$password_check = TRUE;
} else {
	$password = FALSE;
	echo '<p><font color="red">***Passwords dont match***</font></p>';
}
} else {

$password_check = FALSE;
echo '<p><font color="red">***Please enter your password***</font></p>';
}

if ($name_check && $email_check && $username_check && $password_check) {

require_once ('./connect1.php');

$query = "insert into tester (name, email, username, password) values ('$name', '$email', '$username', 

PASSWORD('$password'))"; 
$result = mysql_query($query); 

echo '<p>You are now registered</p>';

include ('./footer.inc');

[weevil]

Try changing it to this

$query = "insert into tester (name, email, username, password) values ('$_POST[name]', '$_POST[email]', 
'$_POST[username]', PASSWORD('$_POST[password1]'))";  

[Billett]

thank you it worked fine 🙂